================
@@ -174,6 +176,82 @@ struct StatisticsOptions {
std::optional<bool> m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ explicit SummaryStatistics(std::string name, std::string impl_type)
+ : m_total_time(), m_impl_type(impl_type), m_name(name), m_count(0) {}
+
+ std::string GetName() const { return m_name; };
+ double GetTotalTime() const { return m_total_time.get().count(); }
+
+ uint64_t GetSummaryCount() const {
+ return m_count.load(std::memory_order_relaxed);
+ }
+
+ StatsDuration &GetDurationReference() { return m_total_time; };
+
+ std::string GetSummaryKindName() const { return m_impl_type; }
+
+ llvm::json::Value ToJSON() const;
+
+ /// Basic RAII class to increment the summary count when the call is
complete.
+ class SummaryInvocation {
+ public:
+ SummaryInvocation(std::shared_ptr<SummaryStatistics> summary_stats)
+ : m_stats(summary_stats),
+ m_elapsed_time(summary_stats->GetDurationReference()) {}
+ ~SummaryInvocation() { m_stats->OnInvoked(); }
+
+ /// Delete the copy constructor and assignment operator to prevent
+ /// accidental double counting.
+ /// @{
+ SummaryInvocation(const SummaryInvocation &) = delete;
+ SummaryInvocation &operator=(const SummaryInvocation &) = delete;
+ /// @}
+
+ private:
+ std::shared_ptr<SummaryStatistics> m_stats;
+ ElapsedTime m_elapsed_time;
+ };
+
+private:
+ void OnInvoked() noexcept { m_count.fetch_add(1, std::memory_order_relaxed);
}
+ lldb_private::StatsDuration m_total_time;
+ const std::string m_impl_type;
+ const std::string m_name;
+ std::atomic<uint64_t> m_count;
+};
+
+typedef std::shared_ptr<SummaryStatistics> SummaryStatisticsSP;
+
+/// A class that wraps a std::map of SummaryStatistics objects behind a mutex.
+class SummaryStatisticsCache {
+public:
+ /// Get the SummaryStatistics object for a given provider name, or insert
+ /// if statistics for that provider is not in the map.
+ SummaryStatisticsSP
+ GetSummaryStatisticsForProviderName(lldb_private::TypeSummaryImpl &provider)
{
----------------
Michael137 wrote:
Personally I'm still not very happy with this setup, but if others are fine
with how this is structured, I won't block this PR.
I think handing out references/pointers to data in the presence of threads
shouldn't be taken lightly. All we want to do here is:
1. Collect stats
2. Update stats in the thread-safe map
If we can just have a `SummaryStatisticsCache::Update(SummaryInvocation)` API.
The summary invocation just records `ElapsedTime`. Then in the `Update` API we
do:
1. If no `SummaryStats` entry exists. Create one
2. Otherwise, add `ElapsedTime` to the running total. Increment the m_count
counter.
That'd make (in my opinion) all of this much easier to reason about. And would
also avoid copying/moving all these strings around.
Wdyt? @bulbazord @clayborg @Jlalond
https://github.com/llvm/llvm-project/pull/102708
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
