Author: Med Ismail Bennani
Date: 2024-07-25T00:12:06-07:00
New Revision: 2914a4b88837177d4a91a99525c1a3117242236d
URL:
https://github.com/llvm/llvm-project/commit/2914a4b88837177d4a91a99525c1a3117242236d
DIFF:
https://github.com/llvm/llvm-project/commit/2914a4b88837177d4a91a99525c1a3117242236d.
https://github.com/labath approved this pull request.
Yikes, I didn't realize this was new code. @feg208, we need to fix this soon.
I'm approving this because it strictly improves upon the current situation, but
I don't think it's not a complete fix. I think we can skip over the `comm`
field w
Author: David Spickett
Date: 2024-07-25T09:15:03+01:00
New Revision: f48c16631de07b47e0721b88bd8004e63897f29a
URL:
https://github.com/llvm/llvm-project/commit/f48c16631de07b47e0721b88bd8004e63897f29a
DIFF:
https://github.com/llvm/llvm-project/commit/f48c16631de07b47e0721b88bd8004e63897f29a.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/100387
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I have merged https://github.com/llvm/llvm-project/pull/100387 to fix this
instead, because it needed some background knowledge to do correctly.
But never the less, thank you @xgupta for making the effort to do this PR, it
has uncovered some unsafe code that only recently
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-07-25T01:19:23-07:00
New Revision: c3a2efceb53e1e3ab9b92e5bf6518ab51f4713a9
URL:
https://github.com/llvm/llvm-project/commit/c3a2efceb53e1e3ab9b92e5bf6518ab51f4713a9
DIFF:
https://github.com/llvm/llvm-project/commit/c3a2efceb53e1e3ab9b92e5bf6518ab51f4713a9.
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,7 +18,7 @@ def test_set_use_source_cache_false(self):
self.set_use_source_cache_and_test(False)
@skipIf(hostoslist=no_match(["windows"]))
-@skipIf(oslist=["windows"]) # Fails on windows 11
+@expectedFailureAll(oslist=["windows"])
la
https://github.com/labath commented:
I'm somewhat surprised to see this many x86 xfails, given that we already have
an arm64 windows bot, and that none of the tests I see here are very
architecture-specific.
I wonder if this could be due to how you've configured your build.
@DavidSpickett, do
@@ -1,3 +1,5 @@
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
labath wrote:
This is particularly concerning, given that this test just operates on static
binary data (expressed in yaml form). There should be nothing target-specific
here.
Maybe we could start by
@@ -1,4 +1,5 @@
# UNSUPPORTED: system-windows
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
labath wrote:
This shouldn't be necessary given the UNSUPPORTED clause above.
https://github.com/llvm/llvm-project/pull/100476
___
@@ -1,3 +1,4 @@
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
labath wrote:
something like `system-windows && target-x86_64` ought to do it. However, like
I said in the other review, I think we ought to figure out why are these
failing for you.
https://github.c
@@ -1,3 +1,4 @@
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
# Make sure lldb can handle filenames with single quotes in them.
# RUN: %clang_host %p/Inputs/hello.c -g -o "%t-'pat"
labath wrote:
And this looks like you may have a different shell (one that handle
@@ -1,4 +1,5 @@
# UNSUPPORTED: system-windows
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
DavidSpickett wrote:
And this test I'm pretty sure is only failing due to cmd line syntax issues,
but no confirmation yet.
https://github.com/llvm/llvm-project/pull/1004
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/99266
>From a54680b17e560460b67646622a674b574f2673b6 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 15 Jul 2024 22:52:40 +0200
Subject: [PATCH] [LLDB][test] Update Makefile.rules to support Windows
@@ -296,11 +313,13 @@ endif
CFLAGS += $(CFLAGS_EXTRAS)
CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS)
LD = $(CC)
-LDFLAGS ?= $(CFLAGS)
+# Copy common options to the linker flags (dwarf, arch. & etc).
+#Note: we get some 'garbage' options for linker here (such as -I, --isyste
@@ -296,11 +313,13 @@ endif
CFLAGS += $(CFLAGS_EXTRAS)
CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS)
LD = $(CC)
-LDFLAGS ?= $(CFLAGS)
+# Copy common options to the linker flags (dwarf, arch. & etc).
+#Note: we get some 'garbage' options for linker here (such as -I, --isyste
dzhidzhoev wrote:
> > > What exactly does it help with? Given that you're canonicalizing to a
> > > forward slash, does that mean that some of the tools you use don't accept
> > > backslashes (perhaps because they come from cygwin or the like)?
> >
> >
> > As far as I understand, MinGW make,
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/99266
>From 1b2018229eb9d53a4f6cda1fb4f60229afa07367 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 15 Jul 2024 22:52:40 +0200
Subject: [PATCH] [LLDB][test] Update Makefile.rules to support Windows
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> When we were setting up cross-platform build and testing config, we had a
> multi-screen list of errors we had to solve. Also, we were unsure about the
> environment in which we would run this. Therefore we decided to bulk
> normalize all paths and some flags. But now I see tha
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Shivam Gupta
Date: 2024-07-25T16:59:39+05:30
New Revision: 2ba3fe7356f065757a2279f65e4ef5c8f1476293
URL:
https://github.com/llvm/llvm-project/commit/2ba3fe7356f065757a2279f65e4ef5c8f1476293
DIFF:
https://github.com/llvm/llvm-project/commit/2ba3fe7356f065757a2279f65e4ef5c8f1476293.diff
https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian`
running on `lldb-x86_64-debian` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/162/builds/2857
Here is the relevant piece of the build log f
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/100561
Reverts llvm/llvm-project#94779
Due to bot failures: https://lab.llvm.org/buildbot/#/builders/18/builds/1371
>From b85152008f41e8136f5e21db875a63b464f8c10f Mon Sep 17 00:00:00 2001
From: David Spickett
D
Author: David Spickett
Date: 2024-07-25T13:18:11+01:00
New Revision: a466db2b32cccfdbd8bbd27cfa2fb51651192075
URL:
https://github.com/llvm/llvm-project/commit/a466db2b32cccfdbd8bbd27cfa2fb51651192075
DIFF:
https://github.com/llvm/llvm-project/commit/a466db2b32cccfdbd8bbd27cfa2fb51651192075.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/100561
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Reverts llvm/llvm-project#94779
Due to bot failures: https://lab.llvm.org/buildbot/#/builders/18/builds/1371
---
Full diff: https://github.com/llvm/llvm-project/pull/100561.diff
1 Files Affected:
-
DavidSpickett wrote:
The code looks ok but as landed it turned `A && B && C` into `A || B || C`,
despite that looking logical.
@medismailben can you figure out the intent here, I'm assuming this was your
code originally.
https://github.com/llvm/llvm-project/pull/94779
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/99266
>From 1d074bad4006134d164e96e21f9105b167212d53 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 15 Jul 2024 22:52:40 +0200
Subject: [PATCH] [LLDB][test] Update Makefile.rules to support Windows
@@ -80,9 +78,21 @@ endif
# Also reset BUILDDIR value because "pwd" returns cygwin or msys path
# which needs to be converted to windows path.
#--
-ifeq "$(OS)" "Windows_NT"
- SHELL = $(WINDIR)\system32\cm
@@ -418,11 +437,28 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
endif
+# No C++ library has been specifieed. Use libstdc++ by default.
+ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB)))
+ # If no explicit request was made, but we have paths to a custo
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94844
>From 5fe77213524d05581eca70b8a0d25e03fe8df793 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 8 Jun 2024 11:52:08 +0530
Subject: [PATCH 1/2] [lldb] Adjust the for loop condition to prevent
unintended incr
@@ -456,21 +492,15 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem
$(SDKROOT)/usr/include/c++/v1
LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++
+else
+ifneq (,$(findstring clang,$
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/99266
>From 1d074bad4006134d164e96e21f9105b167212d53 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 15 Jul 2024 22:52:40 +0200
Subject: [PATCH 1/2] [LLDB][test] Update Makefile.rules to support Windo
@@ -267,7 +274,9 @@ endif
CFLAGS += $(CFLAGS_EXTRAS)
CXXFLAGS += -std=c++11 $(CFLAGS) $(ARCH_CXXFLAGS)
LD = $(CC)
-LDFLAGS ?= $(CFLAGS)
+# Copy common options to the linker flags (dwarf, arch. & etc).
+# Note: we get some 'garbage' options for linker here (such as -I, --isystem
@@ -456,21 +492,15 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem
$(SDKROOT)/usr/include/c++/v1
LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++
+else
+ifneq (,$(findstring clang,$
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -378,11 +387,28 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
endif
+# No C++ library has been specifieed. Use libstdc++ by default.
+ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB)))
+ # If no explicit request was made, but we have paths to a custo
@@ -378,11 +387,28 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
endif
+# No C++ library has been specifieed. Use libstdc++ by default.
+ifeq (,$(filter 1, $(USE_LIBSTDCPP) $(USE_LIBCPP) $(USE_SYSTEM_STDLIB)))
+ # If no explicit request was made, but we have paths to a custo
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/99266
>From 0e513196fcf3cbcd13b7af941c4afc1ddf8be227 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 15 Jul 2024 22:52:40 +0200
Subject: [PATCH] [LLDB][test] Update Makefile.rules to support Windows
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/100577
I ran into this when LTO completely emptied two compile units, so they ended up
with the same hash (see #100375). Although, ideally, the compiler would try to
ensure we don't end up with a hash collision even in
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
I ran into this when LTO completely emptied two compile units, so they ended up
with the same hash (see #100375). Although, ideally, the compiler would
try to ensure we don't end up with a hash collision even
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From 11cabeefae5c7ecd44543eb8bfbba02430165a93 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH] [lldb][test] Support remote run of Shell tests
1. This
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/95986
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
Updated:
Added documentation lines.
Added TEST_ prefix to cmake variables to indicate they doesn't affect lldb
build (as proposed here
https://discourse.llvm.org/t/rfc-lldb-support-remote-run-of-shell-tests/80072/5)
Shell tests remote execution can now be disabled with
`-DLLD
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/100586
It has been markad as XFAIL here de2ddc8f3146bd87152ea86b533541039541efe1, but
I haven't found the reason for that, and apparently, it passes against the
Linux target.
>From ea3f6bfd82e71b0c831fa438bb12f119
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
It has been markad as XFAIL here de2ddc8f3146bd87152ea86b533541039541efe1, but
I haven't found the reason for that, and apparently, it passes against the
Linux target.
---
Full diff: https://githu
https://github.com/dzhidzhoev converted_to_draft
https://github.com/llvm/llvm-project/pull/100586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev ready_for_review
https://github.com/llvm/llvm-project/pull/100586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
The only way that this could succeed on the breakpoint but fail on the location
is that there are more than one locations and the one you are setting it on
(the zeroth) is not the one that's hit. Since this test is "does a breakpoint
condition on a location work" not "does th
jimingham wrote:
BTW, another reason I want to focus here on direction and not on explicitly
stating "reverse continue" and "actual resume" is that a lot of "forward"
motion in a debug session with reverse debugging capability is actually going
to be going "forward" but using the "reverse" mac
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/99266
>From 4699a3b956b6684ca811baa50a13c6235f24be3f Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Mon, 15 Jul 2024 22:52:40 +0200
Subject: [PATCH] [LLDB][test] Update Makefile.rules to support Windows
@@ -456,21 +492,15 @@ ifeq (1, $(USE_SYSTEM_STDLIB))
endif
CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem
$(SDKROOT)/usr/include/c++/v1
LDFLAGS += -L$(SDKROOT)/usr/lib -Wl,-rpath,$(SDKROOT)/usr/lib -lc++
+else
+ifneq (,$(findstring clang,$
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/99266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/100624
This is useful for language runtimes that compute register values by inspecting
the state of the currently running process. Currently, there are no mechanisms
enabling these runtimes to set register valu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This is useful for language runtimes that compute register values by inspecting
the state of the currently running process. Currently, there are no mechanisms
enabling these runtimes to s
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -75,6 +77,18 @@ lldb::SaveCoreStyle SBSaveCoreOptions::GetStyle() const {
return m_opaque_up->GetStyle();
}
+SBError SBSaveCoreOptions::SetProcess(lldb::SBProcess process) {
+ return m_opaque_up->SetProcess(process.GetSP());
+}
+
+SBError SBSaveCoreOptions::AddThread(lld
Author: Vladislav Dzhidzhoev
Date: 2024-07-25T20:25:40+02:00
New Revision: 792b673d36a86ab9d45ed3b259a3fc7020826b76
URL:
https://github.com/llvm/llvm-project/commit/792b673d36a86ab9d45ed3b259a3fc7020826b76
DIFF:
https://github.com/llvm/llvm-project/commit/792b673d36a86ab9d45ed3b259a3fc7020826b7
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/100586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/100628
This patch remove XFAIL decorator from tests which are passing on x86 Windows.
Corresponding XFAILs for AArch64 were removed here 7daa9a9b40a22.
>From 4d606e2b6991d382ee1ee688a86b2154cb70cb66 Mon Sep 17 00:0
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This patch remove XFAIL decorator from tests which are passing on x86 Windows.
Corresponding XFAILs for AArch64 were removed here 7daa9a9b40a22.
---
Full diff: https://github.com/llvm/llvm-project/
https://github.com/dzhidzhoev edited
https://github.com/llvm/llvm-project/pull/100628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,7 +18,7 @@ def test_set_use_source_cache_false(self):
self.set_use_source_cache_and_test(False)
@skipIf(hostoslist=no_match(["windows"]))
-@skipIf(oslist=["windows"]) # Fails on windows 11
+@expectedFailureAll(oslist=["windows"])
ke
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,7 +18,7 @@ def test_set_use_source_cache_false(self):
self.set_use_source_cache_and_test(False)
@skipIf(hostoslist=no_match(["windows"]))
-@skipIf(oslist=["windows"]) # Fails on windows 11
+@expectedFailureAll(oslist=["windows"])
ke
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-07-25T13:32:24-07:00
New Revision: c1d1a752cea105dba1aa999bc90feb5faa974bec
URL:
https://github.com/llvm/llvm-project/commit/c1d1a752cea105dba1aa999bc90feb5faa974bec
DIFF:
https://github.com/llvm/llvm-project/commit/c1d1a752cea105dba1aa999bc90feb5faa974bec.
@@ -0,0 +1,58 @@
+//===--- DirectToIndirectFCR.h - RISC-V specific pass
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -8001,6 +8001,12 @@ NamedDecl *Sema::ActOnVariableDeclarator(
}
}
+ if (getLangOpts().HLSL) {
+if (R->isHLSLSpecificType() && !NewVD->isImplicit()) {
+ Diag(D.getBeginLoc(), diag::err_hlsl_intangible_type_cannot_be_declared);
llvm-beanz wrot
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/100659
We faced the issue running cross api tests in 8 threads. The executable is
installed to the target by the process `lldb-server platform`, but launched by
the another process `lldb-server gdbserver`. We got the
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
We faced the issue running cross api tests in 8 threads. The executable is
installed to the target by the process `lldb-server platform`, but launched by
the another process `lldb-server gdbserver`. We go
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b1f263e4c2466a693609a3930f53b9887be67b5b
6e24f75be4c779ed336a3894ac5312b0fc0e845c --e
@@ -201,7 +201,7 @@ struct ForkLaunchInfo {
execve(info.argv[0], const_cast(info.argv), info.envp);
#if defined(__linux__)
- if (errno == ETXTBSY) {
+ for (int i = 0; i < 50; ++i) {
bulbazord wrote:
Maybe it would be a good idea to make the timeout config
https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/100660
This causes a number of tests be `UNRESOLVED` on Windows if `getCompiler()` has
a space in the name, because `getCompilerBinary()` unconditionally splits on
whitespace and returns the first result, which
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
Changes
This causes a number of tests be `UNRESOLVED` on Windows if `getCompiler()` has
a space in the name, because `getCompilerBinary()` unconditionally splits on
whitespace and returns the first result, wh
mysterymath wrote:
The reland broke the Fuchsia Windows build with a similar error to the LLVM
Windows bots, but I wasn't able to cleanly revert this commit without detailed
knowledge of the contents. Could you revert this (preferentially) or fix
forward?
https://github.com/llvm/llvm-project/
@@ -18,7 +18,7 @@ def test_set_use_source_cache_false(self):
self.set_use_source_cache_and_test(False)
@skipIf(hostoslist=no_match(["windows"]))
-@skipIf(oslist=["windows"]) # Fails on windows 11
+@expectedFailureAll(oslist=["windows"])
ke
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/100624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
This looks good to me. One small nit on the Dump method.
As a bit of background, this would be very unusual for a normal UnwindPlan that
is reused for a function in many different contexts (different places on the
stack during the pr
@@ -153,6 +155,9 @@ void UnwindPlan::Row::RegisterLocation::Dump(Stream &s,
if (m_type == atDWARFExpression)
s.PutChar(']');
} break;
+ case isConstant:
+s.Printf("=%x", m_location.offset);
jasonmolenda wrote:
Should the Printf be `("=0x%" PRI
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100660
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -158,7 +158,7 @@ class LLDB_API SBProcess {
lldb::SBError Destroy();
- lldb::SBError Continue();
+ lldb::SBError Continue(RunDirection direction = RunDirection::eRunForward);
clayborg wrote:
@jimingham: do you want all process control function to rema
@@ -170,7 +170,7 @@ class DWARFUnit : public UserID {
/// both cases correctly and avoids crashes.
DWARFCompileUnit *GetSkeletonUnit();
- void SetSkeletonUnit(DWARFUnit *skeleton_unit);
+ bool LinkToSkeletonUnit(DWARFUnit &skeleton_unit);
clayborg wrote:
@@ -718,13 +720,11 @@ DWARFCompileUnit *DWARFUnit::GetSkeletonUnit() {
return llvm::dyn_cast_or_null(m_skeleton_unit);
}
-void DWARFUnit::SetSkeletonUnit(DWARFUnit *skeleton_unit) {
- // If someone is re-setting the skeleton compile unit backlink, make sure
- // it is sett
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/100666
MAX_PATH is definitely larger than 6 bytes we are expecting for this message,
and could be rather large depending on the target OS (4K for some Linux OSs).
Since the buffer gets allocated on the stack we bette
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
MAX_PATH is definitely larger than 6 bytes we are expecting for this message,
and could be rather large depending on the target OS (4K for some Linux OSs).
Since the buffer gets allocated on the stack we
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/100659
>From 21fd03faa1224d44bd132a0b53d66d896210a044 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 26 Jul 2024 01:48:35 +0400
Subject: [PATCH] [lldb] Improved lldb-server stability for remote launching
W
@@ -0,0 +1,194 @@
+//===--- DirectToIndirectFCR.cpp - RISC-V specific pass
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/100477
>From 5a32aac6f71c24bc111a1139b69a7568203dae69 Mon Sep 17 00:00:00 2001
From: kendal
Date: Thu, 25 Jul 2024 15:26:38 -0700
Subject: [PATCH] [lldb][test][win][x86_64] Remove XFAIL from passing API tests
--
@@ -201,7 +201,7 @@ struct ForkLaunchInfo {
execve(info.argv[0], const_cast(info.argv), info.envp);
#if defined(__linux__)
- if (errno == ETXTBSY) {
+ for (int i = 0; i < 50; ++i) {
slydiman wrote:
I think it is redundant. Currently lldb-server contains a
https://github.com/dlav-sc edited
https://github.com/llvm/llvm-project/pull/99336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/100477
>From ac737efe9cb7d9fa690a6dfaa8ba7c6e006913c1 Mon Sep 17 00:00:00 2001
From: kendal
Date: Thu, 25 Jul 2024 15:52:47 -0700
Subject: [PATCH] [lldb][test][win][x86_64] XFAIL already failing API tests
These
kendalharland wrote:
Thanks for the assistance @labath and @DavidSpickett. After fixing my cmake
configuration I'm actually seeing a few tests unexpectedly pass with different
options:
CMAKE_C_COMPILER clang-cl.exe
CMAKE_CXX_COMPILER clang-cl.exe
CMAKE_BUILD_TYPE Release
medismailben wrote:
> The reland broke the Fuchsia Windows build with a similar error to the LLVM
> Windows bots, but I wasn't able to cleanly revert this commit without
> detailed knowledge of the contents. Could you revert this (preferentially) or
> fix forward?
>
> https://luci-milo.appspo
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 143 matches
Mail list logo
