https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/100660
This causes a number of tests be `UNRESOLVED` on Windows if `getCompiler()` has
a space in the name, because `getCompilerBinary()` unconditionally splits on
whitespace and returns the first result, which might just be`"C:\Program"` if
using a compiler such as `clang-cl` `cl` from Visual studio's installation
directory.
>From c779fac5e7f5fbabaa79c98b31e20e7d567d1cd7 Mon Sep 17 00:00:00 2001
From: kendal <kendal@thebrowser.company>
Date: Thu, 25 Jul 2024 14:59:25 -0700
Subject: [PATCH] [lldb][test] Remove getCompilerBinary() helper
---
lldb/packages/Python/lldbsuite/test/lldbplatformutil.py | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
b/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
index e3c6fd1a99568..0bbe1db424630 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbplatformutil.py
@@ -266,16 +266,11 @@ def getCompiler():
return module.getCompiler()
-def getCompilerBinary():
- """Returns the compiler binary the test suite is running with."""
- return getCompiler().split()[0]
-
-
def getCompilerVersion():
"""Returns a string that represents the compiler version.
Supports: llvm, clang.
"""
- compiler = getCompilerBinary()
+ compiler = getCompiler()
version_output = subprocess.check_output([compiler, "--version"],
errors="replace")
m = re.search("version ([0-9.]+)", version_output)
if m:
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
