labath wrote:
I think that `operator==` should represent the strictest possible way to
compare two objects, and ideally mean "the two objects are interchangable".
Interchangeability implies transitivity, and that doesn't hold here because an
object with no checksum can match two other objects
labath wrote:
We should also add a test case for the new API. You can just take an existing
test case with some synthetic values (e.g. `TestFormattersSBAPI.py`), add some
Get(Non)SyntheticValue calls, and make sure they do what they should.
https://github.com/llvm/llvm-project/pull/95959
_
labath wrote:
Can't say I'm excited to see this feature (although I admit it is looking less
daunting than I originally feared). Can you explain why you need this feature?
Is there some particular aspect of lldb's remote operation that you think isn't
well covered by the existing tests? Is th
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94779
>From b8a387d82ed90c98f6bc9c0c7f9bc9da0d8e4d18 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Fri, 7 Jun 2024 23:21:15 +0530
Subject: [PATCH 1/2] [LLDB][NFC] Fix a cppcheck warning in
Python/Interfaces/Scripte
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/95678
>From 74efb6ae3187fe1e67e61cdca1f99b9de8146db4 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sun, 16 Jun 2024 00:21:51 +0530
Subject: [PATCH 1/2] [LLDB] Add an assert to verify sign_bit_pos is within the
vali
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/95905
>From 9429eefc79b310731bafa63cf4db46eea3b0756e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 17 Jun 2024 13:45:24 +0200
Subject: [PATCH 1/2] [lldb/DWARF] Fix type definition search with simple
template n
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if (type
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if (type
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/95905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/95675
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if (type
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/95905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM! (minor nit)
https://github.com/llvm/llvm-project/pull/96013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/96013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4744,11 +4744,12 @@
TypeSystemClang::GetBitSize(lldb::opaque_compiler_type_t type,
ExecutionContext exe_ctx(exe_scope);
Process *process = exe_ctx.GetProcessPtr();
if (process) {
-ObjCLanguageRuntime *objc_runtime = ObjCLanguageRuntime::Get(*proce
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if (type
Michael137 wrote:
Ah got it, thanks for clarifying.
> so we could instead just check if the field is empty.
Couldn't find an existing API for this on `FieldDecl`. Here "empty" would be
"field is of a type which is empty"? Which might still cause complications
because a `CXXRecordDecl::isEmpty
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if (type
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/4] Add support for DW_OP_WASM_location to DWARFExpression
efriedma-quic wrote:
It's not that hard to compute "no-data": non-RecordDecls are never no-data,
RecordDecls are no-data if they don't have a vtable pointer (isDynamicClass()),
and all fields are no-data. We can save it in the CGRecordLayout.
Assuming that's the route we want to go, of course
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/95905
>From 9429eefc79b310731bafa63cf4db46eea3b0756e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 17 Jun 2024 13:45:24 +0200
Subject: [PATCH 1/3] [lldb/DWARF] Fix type definition search with simple
template n
@@ -3073,14 +3073,43 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
// See comments below about -gsimple-template-names for why we attempt to
// compute missing template parameter names.
-ConstString template_params;
-if (type
Author: Pavel Labath
Date: 2024-06-20T08:09:02+02:00
New Revision: c2f976649a5ef405b224bfe36267966cdd394057
URL:
https://github.com/llvm/llvm-project/commit/c2f976649a5ef405b224bfe36267966cdd394057
DIFF:
https://github.com/llvm/llvm-project/commit/c2f976649a5ef405b224bfe36267966cdd394057.diff
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/95905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
24 matches
Mail list logo
