[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/87740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

@@ -64,6 +64,32 @@ class DWARFAcceleratorTable { return std::nullopt; } +/// Returns the type signature of the Type Unit associated with this +/// Accelerator Entry or std::nullopt if the Type Unit offset is not +/// recorded in this Accelerator Entry. +

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

@@ -1741,45 +1741,61 @@ lldb::ModuleSP SymbolFileDWARF::GetExternalModule(ConstString name) { return pos->second; } -DWARFDIE -SymbolFileDWARF::GetDIE(const DIERef &die_ref) { - // This method can be called without going through the symbol vendor so we - // need to lock t

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

https://github.com/labath commented: Most of the patch is very clean, but I'm bothered by the `getForeignTUSkeletonCUOffset` function, how it opens up with a mostly redundant (the callers checks this already) call to `getForeignTUTypeSignature`, and then proceeds with a reimplementation of `g

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

@@ -1726,44 +1725,59 @@ lldb::ModuleSP SymbolFileDWARF::GetExternalModule(ConstString name) { return pos->second; } -DWARFDIE -SymbolFileDWARF::GetDIE(const DIERef &die_ref) { - // This method can be called without going through the symbol vendor so we - // need to lock t

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

@@ -0,0 +1,127 @@ +// REQUIRES: lld + +// This test will make a type that will be compiled differently into two +// different .dwo files in a type unit with the same type hash, but with +// differing contents. Clang's type unit signature is based only on the mangled +// name of th

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

@@ -0,0 +1,127 @@ +// REQUIRES: lld + +// This test will make a type that will be compiled differently into two +// different .dwo files in a type unit with the same type hash, but with +// differing contents. Clang's type unit signature is based only on the mangled +// name of th

[Lldb-commits] [lldb] [lldb][test] Add test for completing ObjCObjectType (PR #95405)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/95405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b650764 - [lldb][test] Add test for completing ObjCObjectType (#95405)

Author: Michael Buch Date: 2024-06-14T11:49:12+01:00 New Revision: b650764b16b5c8790325775ac5f87f0b1c0beca7 URL: https://github.com/llvm/llvm-project/commit/b650764b16b5c8790325775ac5f87f0b1c0beca7 DIFF: https://github.com/llvm/llvm-project/commit/b650764b16b5c8790325775ac5f87f0b1c0beca7.diff

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

Michael137 wrote: > A possibly silly question, but my understanding was that this effort will > better align us with the interfaces that are used within clang (for compiling > modules I think). Is that correct? Regarding Clang interfaces, one of the main benefits of this patch is that we can

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/90075 >From a6e96025f399b27395778656aa720ea97d3d1e92 Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Fri, 7 Jun 2024 11:23:24 +0300 Subject: [PATCH] [lldb][riscv] Fix setting breakpoint for undecoded instruction

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareBreakpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareBreakpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

ayermolo wrote: > Most of the patch is very clean, but I'm bothered by the > `getForeignTUSkeletonCUOffset` function, how it opens up with a mostly > redundant (the callers checks this already) call to > `getForeignTUTypeSignature`, and then proceeds with a reimplementation of > `getCUOffset`

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/95007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

@@ -209,6 +209,14 @@ class LLDB_API SBProcess { lldb::addr_t ReadPointerFromMemory(addr_t addr, lldb::SBError &error); + lldb::SBAddressRangeList + FindRangesInMemory(const void *buf, uint64_t size, SBAddressRangeList &ranges, + uint32_t alignment, ui

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

https://github.com/bulbazord commented: Sorry for coming in a bit late here, I know this has been in review for a while. I didn't look at this in great detail, but I did look at the changes you're making to the SBAPI. Can you change the reference parameters that are input-only to be marked `co

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

@@ -209,6 +209,14 @@ class LLDB_API SBProcess { lldb::addr_t ReadPointerFromMemory(addr_t addr, lldb::SBError &error); + lldb::SBAddressRangeList + FindRangesInMemory(const void *buf, uint64_t size, SBAddressRangeList &ranges, bulbazord wrote: Could you

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/95571 New fixes: - properly init the `std::optional` to an empty vector as opposed to `{}` (which was effectively `std::nullopt`). >From 018c7a6052add708e0b0d09b911a904b52199da5 Mon Sep 17 00:00:00 2001 From: Vy Ngu

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes New fixes: - properly init the `std::optional` to an empty vector as opposed to `{}` (which was effectively `std::nullopt`). --- Full diff: https://github.com/llvm/llvm-project/pull/95571.diff 7

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] Reapply PR/87550 (again) (PR #95571)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bbe9119d9cb37662faafe7fe273e792b1b70145e ac59dccc8f0c9d75ceca2cc4019535426301211a --

[Lldb-commits] [lldb] [lldb] Tweak Python interpreter workaround on macOS (PR #95582)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/95582 Avoid copying the Python interpreter when running in a virtual environment as it will already have its own copy of the Python interpreter. Also leave a breadcrumb that we're running with a different Python

[Lldb-commits] [lldb] [lldb] Tweak Python interpreter workaround on macOS (PR #95582)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Avoid copying the Python interpreter when running in a virtual environment as it will already have its own copy of the Python interpreter. Also leave a breadcrumb that we're running with a different

[Lldb-commits] [lldb] [lldb] Tweak Python interpreter workaround on macOS (PR #95582)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/95582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Tweak Python interpreter workaround on macOS (PR #95582)

https://github.com/felipepiovezan approved this pull request. https://github.com/llvm/llvm-project/pull/95582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4368726 - [lldb] Tweak Python interpreter workaround on macOS (#95582)

Author: Jonas Devlieghere Date: 2024-06-14T11:52:27-07:00 New Revision: 436872693a8a57487bf4510437183878d1e35cfb URL: https://github.com/llvm/llvm-project/commit/436872693a8a57487bf4510437183878d1e35cfb DIFF: https://github.com/llvm/llvm-project/commit/436872693a8a57487bf4510437183878d1e35cfb.d

[Lldb-commits] [lldb] [lldb] Tweak Python interpreter workaround on macOS (PR #95582)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/95582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/thetruestblue created https://github.com/llvm/llvm-project/pull/95586 Currently, the instrumentation runtime is caching a library the first time it sees it in the module list. However, in some rare cases on Darwin, the cached pre-run unloaded modules are different from the r

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/95586 >From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001 From: Blue Gaston Date: Fri, 14 Jun 2024 12:53:27 -0400 Subject: [PATCH] [LLDB] Don't cache module sp when Activate() fails. Currentl

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/thetruestblue closed https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

@@ -44,6 +44,30 @@ void SBStatisticsOptions::SetSummaryOnly(bool b) { bool SBStatisticsOptions::GetSummaryOnly() { return m_opaque_up->summary_only; } +void SBStatisticsOptions::SetIncludeTargets(bool b) { + m_opaque_up->include_targets = b; +} + +bool SBStatisticsOptions::

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

@@ -133,7 +133,9 @@ struct ConstStringStats { struct StatisticsOptions { bool summary_only = false; bool load_all_debug_info = false; - bool include_transcript = false; + bool include_targets = true; + bool include_modules = true; clayborg wrote: Do we

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

@@ -133,7 +133,9 @@ struct ConstStringStats { struct StatisticsOptions { bool summary_only = false; bool load_all_debug_info = false; - bool include_transcript = false; clayborg wrote: I would move this line that was removed back to where it was on line 1

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

@@ -77,12 +78,33 @@ class CommandObjectStatsDump : public CommandObjectParsed { break; case 's': m_stats_options.summary_only = true; +// In the "summary" mode, the following sections should be omitted by +// default unless their correspond

[Lldb-commits] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/thetruestblue reopened https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/thetruestblue ready_for_review https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (thetruestblue) Changes Currently, the instrumentation runtime is caching a library the first time it sees it in the module list. However, in some rare cases on Darwin, the cached pre-run unloaded modules are different from the runtim

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

labath wrote: > BOLT does as I mentioned in: [#87740 > (comment)](https://github.com/llvm/llvm-project/pull/87740#issuecomment-2060023287) I'm sorry, I missed that part. I'm bit of late to the party here. > > It will put all the CUs/Tus into one one module, thus for foreign TUs both > DW_IDX

[Lldb-commits] [lldb] 445fc51 - [lldb][test] Force dwarf4 usage in test requiring it (#95449)

Author: Felipe de Azevedo Piovezan Date: 2024-06-14T12:40:30-07:00 New Revision: 445fc51800d391d0c912d8c6c918b016e0604319 URL: https://github.com/llvm/llvm-project/commit/445fc51800d391d0c912d8c6c918b016e0604319 DIFF: https://github.com/llvm/llvm-project/commit/445fc51800d391d0c912d8c6c918b016e

[Lldb-commits] [lldb] [lldb][test] Force dwarf4 usage in test requiring it (PR #95449)

https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/95449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add options to "statistics dump" to control what sections are dumped (PR #95075)

https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/95075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

https://github.com/adrian-prantl commented: Very excited to see this happening! https://github.com/llvm/llvm-project/pull/95100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/95100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

@@ -228,6 +246,9 @@ class DWARFASTParserClang : public lldb_private::plugin::dwarf::DWARFASTParser { void LinkDeclToDIE(clang::Decl *decl, const lldb_private::plugin::dwarf::DWARFDIE &die); + void RegisterDIE(lldb_private::plugin::dwarf::DWARFDebugInfo

[Lldb-commits] [lldb] [WIP][lldb] Use forward decls with redeclared definitions instead of minimal import for records (PR #95100)

@@ -279,9 +281,16 @@ class SemaSourceWithPriorities : public clang::ExternalSemaSource { return nullptr; } + /// Call ExternalASTSource::CompleteRedeclChain(D) + /// on each AST source. Returns as soon as we got + /// a definition for D. void CompleteRedeclChain(c

[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

@@ -200,7 +200,10 @@ def test_commands(self): # Get output from the console. This should contain both the # "exitCommands" that were run after the second breakpoint was hit # and the "terminateCommands" due to the debugging session ending -output

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/95606 Currently, two SupportFiles with the same FileSpec are considered different if one of them has a Checksum and the other doesn't. However, this is overly strict. It's totally valid to mix LineTables that do

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

JDevlieghere wrote: Credit to @jasonmolenda for uncovering this bug. https://github.com/llvm/llvm-project/pull/95606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Currently, two SupportFiles with the same FileSpec are considered different if one of them has a Checksum and the other doesn't. However, this is overly strict. It's totally valid to mix LineTables

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

https://github.com/jimingham approved this pull request. The previous check does seem overly restrictive. LGTM https://github.com/llvm/llvm-project/pull/95606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/95606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

https://github.com/jasonmolenda approved this pull request. Thanks for coming up with the right fix, this looks good to me. https://github.com/llvm/llvm-project/pull/95606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

JDevlieghere wrote: Thanks for the overwhelming support :-) https://github.com/llvm/llvm-project/pull/95606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 19ad7a0 - [lldb] Fix the semantics of SupportFile equivalence (#95606)

Author: Jonas Devlieghere Date: 2024-06-14T14:25:03-07:00 New Revision: 19ad7a046b5cf435ba95c100170fc0e36231d620 URL: https://github.com/llvm/llvm-project/commit/19ad7a046b5cf435ba95c100170fc0e36231d620 DIFF: https://github.com/llvm/llvm-project/commit/19ad7a046b5cf435ba95c100170fc0e36231d620.d

[Lldb-commits] [lldb] [lldb] Fix the semantics of SupportFile equivalence (PR #95606)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/95606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/jimingham approved this pull request. LGTM I also looked at this a bit, and couldn't come up with a reliable way to write a test. https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

@@ -60,6 +60,8 @@ void InstrumentationRuntime::ModulesDidLoad( if (CheckIfRuntimeIsValid(module_sp)) { SetRuntimeModuleSP(module_sp); Activate(); +if (IsActive()) + SetRuntimeModuleSP({}); // Don't cache module if activation failed. --

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

@@ -60,6 +60,8 @@ void InstrumentationRuntime::ModulesDidLoad( if (CheckIfRuntimeIsValid(module_sp)) { SetRuntimeModuleSP(module_sp); Activate(); +if (IsActive()) + SetRuntimeModuleSP({}); // Don't cache module if activation failed. --

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/95586 >From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001 From: Blue Gaston Date: Fri, 14 Jun 2024 12:53:27 -0400 Subject: [PATCH 1/2] [LLDB] Don't cache module sp when Activate() fails. Curr

[Lldb-commits] [lldb] [LLDB] Don't cache module sp when Activate() fails. (PR #95586)

https://github.com/thetruestblue edited https://github.com/llvm/llvm-project/pull/95586 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove SupportFile::Update and use the original Checksum (PR #95623)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/95623 When Jason was looking into the issue caused by #95606 he suggested using the Checksum from the original file in LineEntry. I like the idea because it makes sense semantically, but also allows us to get rid

[Lldb-commits] [lldb] [lldb] Remove SupportFile::Update and use the original Checksum (PR #95623)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes When Jason was looking into the issue caused by #95606 he suggested using the Checksum from the original file in LineEntry. I like the idea because it makes sense semantically, but also allows us to

[Lldb-commits] [lldb] [lldb] Remove SupportFile::Update and use the original Checksum (PR #95623)

https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/95623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

clayborg wrote: > Most of the patch is very clean, but I'm bothered by the > `getForeignTUSkeletonCUOffset` function, how it opens up with a mostly > redundant (the callers checks this already) call to > `getForeignTUTypeSignature`, and then proceeds with a reimplementation of > `getCUOffset`

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -791,26 +812,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +retur

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -81,38 +82,42 @@ Status MinidumpFileBuilder::AddHeaderAndCalculateDirectories() { // Now offset the file by the directores so we can write them in later. offset_t directory_offset = m_expected_directories * directory_size; m_saved_data_size += directory_offset; - //

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -797,20 +794,89 @@ void MinidumpFileBuilder::AddLinuxFileStreams( } } -Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { - constexpr size_t header_size = sizeof(llvm::minidump::Header); - constexpr size_t directory_size = sizeof(llvm::minidump::Directory

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -28,17 +29,90 @@ #include "llvm/ADT/StringRef.h" #include "llvm/BinaryFormat/Minidump.h" #include "llvm/Support/ConvertUTF.h" +#include "llvm/Support/Endian.h" #include "llvm/Support/Error.h" +#include "llvm/TargetParser/Triple.h" #include "Plugins/Process/minidump/Minid

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -20,25 +20,104 @@ #include "lldb/Target/RegisterContext.h" #include "lldb/Target/StopInfo.h" #include "lldb/Target/ThreadList.h" +#include "lldb/Utility/DataBufferHeap.h" #include "lldb/Utility/DataExtractor.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -791,26 +812,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams( size_t size = memory_buffer->getBufferSize(); if (size == 0) continue; - AddDirectory(stream, size); + error = AddDirectory(stream, size); + if (error.Fail()) +retur

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Add 64b support to LLDB's minidump file builder. (PR #95312)

@@ -858,10 +953,247 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { return error; } -size_t MinidumpFileBuilder::GetDirectoriesNum() const { - return m_directories.size(); +static size_t GetLargestRange(const Process::CoreFileMemoryRanges &ranges) { +

[Lldb-commits] [lldb] [lldb] Adds additional fields to ProcessInfo (PR #91544)

https://github.com/feg208 closed https://github.com/llvm/llvm-project/pull/91544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8f74725 - [lldb] Adds additional fields to ProcessInfo (#91544)

Author: Fred Grim Date: 2024-06-14T18:30:23-07:00 New Revision: 8f74725731bf431fb97929e1dd962e9a0db20865 URL: https://github.com/llvm/llvm-project/commit/8f74725731bf431fb97929e1dd962e9a0db20865 DIFF: https://github.com/llvm/llvm-project/commit/8f74725731bf431fb97929e1dd962e9a0db20865.diff LOG

[Lldb-commits] [lldb] [lldb] Adds additional fields to ProcessInfo (PR #91544)

feg208 wrote: @JDevlieghere and @clayborg sorry for the line noise. It's merged https://github.com/llvm/llvm-project/pull/91544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits