https://github.com/bulbazord commented:

Sorry for coming in a bit late here, I know this has been in review for a while.

I didn't look at this in great detail, but I did look at the changes you're 
making to the SBAPI. Can you change the reference parameters that are 
input-only to be marked `const`? Downstream we maintain some clang-based 
tooling that generates code from the SBAPI headers and having input-only 
reference parameters marked as `const` makes a difference for us.

https://github.com/llvm/llvm-project/pull/95007
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to