https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/95078
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-06-12T09:33:35+01:00
New Revision: 1efd5c22893e4a186453f6aaf44fee747f1d63bf
URL:
https://github.com/llvm/llvm-project/commit/1efd5c22893e4a186453f6aaf44fee747f1d63bf
DIFF:
https://github.com/llvm/llvm-project/commit/1efd5c22893e4a186453f6aaf44fee747f1d63bf.diff
Author: Michael Buch
Date: 2024-06-12T09:34:12+01:00
New Revision: 860f0b542ae32c507959201146242cd716222041
URL:
https://github.com/llvm/llvm-project/commit/860f0b542ae32c507959201146242cd716222041
DIFF:
https://github.com/llvm/llvm-project/commit/860f0b542ae32c507959201146242cd716222041.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/95175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/91452
>From d9d0e0de9d57cefc8be78efa5ba9254127c68521 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 8 May 2024 10:47:54 +0100
Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Report progress when parsing
ty
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/85058
>From 60086c78d9be91704158f45e19813217289757b7 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 11 Jun 2024 13:41:18 +
Subject: [PATCH 1/2] [lldb] Do not produce field information for registers
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/85058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Rebased so that commit #1 here is
https://github.com/llvm/llvm-project/pull/95125.
> It looks like svcr is for SME & mte_ctrl is for MTE. Neither of these are
> currently supported in FreeBSD. When they are supported the appropriate HWCAP
> flags (and ID_AA64* registers)
DavidSpickett wrote:
Eventually we'll need to pass the OS type to the detector, but this is not
needed now and quite easy to add when it is needed.
https://github.com/llvm/llvm-project/pull/85058
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
Author: Michael Buch
Date: 2024-06-12T10:33:03+01:00
New Revision: d32afb39fd90a305fc116a7161a2b4c4556117d4
URL:
https://github.com/llvm/llvm-project/commit/d32afb39fd90a305fc116a7161a2b4c4556117d4
DIFF:
https://github.com/llvm/llvm-project/commit/d32afb39fd90a305fc116a7161a2b4c4556117d4.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/91452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Only buildkite test failure was `TestConcurrentVFork`, which seemed unrelated.
https://github.com/llvm/llvm-project/pull/91452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
labath wrote:
> > * when you say "slower", what exactly does that mean. How much slow down
> > are we talking about?
> > * the "increased number of DWARF searches", is that due to clang asking for
> > definitions of types more eagerly? If yes, do you have some examples of
> > where are these e
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/95227
…ARFDIE
This puts them closer to the other two functions doing something very similar.
I've tried to stick to the original logic of the functions as much as possible,
though I did apply some easy simplifications
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
…ARFDIE
This puts them closer to the other two functions doing something very similar.
I've tried to stick to the original logic of the functions as much as possible,
though I did apply some easy simplificati
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/95227
>From 096b84cd00ce5858bc0562e72660ca68d17c9edc Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 12 Jun 2024 09:18:35 +0200
Subject: [PATCH] [lldb] Move DWARFDeclContext functions from
DWARFDebugInfoEntry to
feg208 wrote:
@clayborg I don't have commit access. Can you merge this?
https://github.com/llvm/llvm-project/pull/91544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM, the `GetDWARFDeclContext` implementation is definitely easier to grok now
https://github.com/llvm/llvm-project/pull/95227
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
Michael137 wrote:
> "completing (getting the definition) of the method's arguments and/or return
> types", or something else? My understanding is that we're currently always
> adding the declaration of the methods when completing the class, but that we
> don't eagerly complete the types argume
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/93808
>From eaf50dc4a1f5285676c16b59c4149483d94fb986 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Thu, 9 May 2024 04:53:23 +
Subject: [PATCH] [lldb][test] Disable PIE for some API tests
These tests
Author: Vladislav Dzhidzhoev
Date: 2024-06-12T17:10:20+02:00
New Revision: f6a2ca4f22e3d737a7aa488a4edde88d53dc8b26
URL:
https://github.com/llvm/llvm-project/commit/f6a2ca4f22e3d737a7aa488a4edde88d53dc8b26
DIFF:
https://github.com/llvm/llvm-project/commit/f6a2ca4f22e3d737a7aa488a4edde88d53dc8b2
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/93808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -810,6 +809,65 @@ const char *SBProcess::GetBroadcasterClass() {
return ConstString(Process::GetStaticBroadcasterClass()).AsCString();
}
+lldb::SBAddressRangeList
+SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
+ SBAddressRangeL
@@ -2007,6 +2007,124 @@ size_t Process::ReadMemory(addr_t addr, void *buf,
size_t size, Status &error) {
}
}
+void Process::DoFindInMemory(lldb::addr_t start_addr, lldb::addr_t end_addr,
+ const uint8_t *buf, size_t size,
+
ldionne wrote:
For tidying up the libc++ review queue, please remove the `libc++` tag once you
rebase this (the small changes in `libcxx` will go away).
https://github.com/llvm/llvm-project/pull/93388
___
lldb-commits mailing list
lldb-commits@lists.l
felipepiovezan wrote:
hi @dzhidzhoev, I think this commit is causing the arm lldb incremental bots to
fail.
Could you have a look or revert if you think the fix is not obvious? This is
our most important bot, so it would be nice to get it green again
https://green.lab.llvm.org/job/llvm.org/view
felipepiovezan wrote:
@dzhidzhoev I think @labath 's suggestion might fix this (LD_EXTRAS)
https://github.com/llvm/llvm-project/pull/93808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
Author: Felipe de Azevedo Piovezan
Date: 2024-06-12T09:32:54-07:00
New Revision: c5790206f719c8fac168ae488420f31800d55cf0
URL:
https://github.com/llvm/llvm-project/commit/c5790206f719c8fac168ae488420f31800d55cf0
DIFF:
https://github.com/llvm/llvm-project/commit/c5790206f719c8fac168ae488420f3180
felipepiovezan wrote:
Pushed a fix
https://github.com/llvm/llvm-project/pull/93808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,31 @@
+import lldb
+
+SINGLE_INSTANCE_PATTERN = "there_is_only_one_of_me"
+DOUBLE_INSTANCE_PATTERN = "there_is_exactly_two_of_me"
+
+
+def GetAddressRanges(test_base):
mbucko wrote:
Why not just store them all on stack and only use one region to search
cmtice wrote:
> There was one comment that should probably be removed. This looks okay to me
> at this stage.
Jim, If this looks ok to you, could you officially mark it as approved please?
https://github.com/llvm/llvm-project/pull/87197
___
lldb-comm
cmtice wrote:
Review ping? Does this look ok to everyone now? I would really like to get this
PR committed (I have more waiting behind it). Thanks in advance!
https://github.com/llvm/llvm-project/pull/87197
___
lldb-commits mailing list
lldb-commits@
@@ -0,0 +1,31 @@
+import lldb
+
+SINGLE_INSTANCE_PATTERN = "there_is_only_one_of_me"
+DOUBLE_INSTANCE_PATTERN = "there_is_exactly_two_of_me"
+
+
+def GetAddressRanges(test_base):
clayborg wrote:
You will want to check that multiple memory ranges works, so you nee
@@ -2007,6 +2007,124 @@ size_t Process::ReadMemory(addr_t addr, void *buf,
size_t size, Status &error) {
}
}
+void Process::DoFindInMemory(lldb::addr_t start_addr, lldb::addr_t end_addr,
+ const uint8_t *buf, size_t size,
+
@@ -810,6 +809,65 @@ const char *SBProcess::GetBroadcasterClass() {
return ConstString(Process::GetStaticBroadcasterClass()).AsCString();
}
+lldb::SBAddressRangeList
+SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
+ SBAddressRangeL
@@ -810,6 +809,65 @@ const char *SBProcess::GetBroadcasterClass() {
return ConstString(Process::GetStaticBroadcasterClass()).AsCString();
}
+lldb::SBAddressRangeList
+SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
+ SBAddressRangeL
@@ -810,6 +809,65 @@ const char *SBProcess::GetBroadcasterClass() {
return ConstString(Process::GetStaticBroadcasterClass()).AsCString();
}
+lldb::SBAddressRangeList
+SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
+ SBAddressRangeL
@@ -810,6 +809,65 @@ const char *SBProcess::GetBroadcasterClass() {
return ConstString(Process::GetStaticBroadcasterClass()).AsCString();
}
+lldb::SBAddressRangeList
+SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
+ SBAddressRangeL
@@ -810,6 +809,65 @@ const char *SBProcess::GetBroadcasterClass() {
return ConstString(Process::GetStaticBroadcasterClass()).AsCString();
}
+lldb::SBAddressRangeList
+SBProcess::FindRangesInMemory(const void *buf, uint64_t size,
+ SBAddressRangeL
https://github.com/jimingham approved this pull request.
LGTM at this point.
https://github.com/llvm/llvm-project/pull/87197
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/95312
Currently, LLDB does not support taking a minidump over the 4.2gb limit imposed
by uint32. In fact, currently it writes the RVA's and the headers to the end of
the file, which can become corrupted due to the hea
llvmbot wrote:
@llvm/pr-subscribers-llvm-binary-utilities
Author: Jacob Lalonde (Jlalond)
Changes
Currently, LLDB does not support taking a minidump over the 4.2gb limit imposed
by uint32. In fact, currently it writes the RVA's and the headers to the end of
the file, which can become cor
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d6bbe2e20ff21cc2d31106742dfe1711ae5c641e
c592936dedb0dc494b03144d741ce57ac0b27809 --
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/95318
This commit refactors the typemaps and static functions used in the SWIG
typemaps and wrappers to be in their own SWIG files that are included in the
main `python.swig` file.
>From 51ea2794e3ea5369d519710
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This commit refactors the typemaps and static functions used in the SWIG
typemaps and wrappers to be in their own SWIG files that are included in the
main `python.swig` file.
---
Full diff: https:
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/95318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/95318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,119 @@
+/*
+ Typemaps specific to callback functions in LLDB. If editing this file
+ use the Python C API to access Python objects instead of using
PythonDataObjects.
medismailben wrote:
nit: it would be nice to put the Python C API documentation link
@@ -0,0 +1,119 @@
+/*
+ Typemaps specific to callback functions in LLDB. If editing this file
+ use the Python C API to access Python objects instead of using
PythonDataObjects.
+*/
+
+// For Log::LogOutputCallback
+%typemap(in) (lldb::LogOutputCallback log_callback, void *baton)
@@ -0,0 +1,119 @@
+/*
+ Typemaps specific to callback functions in LLDB. If editing this file
+ use the Python C API to access Python objects instead of using
PythonDataObjects.
+*/
+
+// For Log::LogOutputCallback
+%typemap(in) (lldb::LogOutputCallback log_callback, void *baton)
Author: Jason Molenda
Date: 2024-06-12T15:58:03-07:00
New Revision: 45927d730bcd2aa3380834ca8db96e32a8b2f2b1
URL:
https://github.com/llvm/llvm-project/commit/45927d730bcd2aa3380834ca8db96e32a8b2f2b1
DIFF:
https://github.com/llvm/llvm-project/commit/45927d730bcd2aa3380834ca8db96e32a8b2f2b1.diff
https://github.com/bulbazord commented:
Is this just moving code around? The summary says what you're doing but not
why, what's the motivation?
https://github.com/llvm/llvm-project/pull/95318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/95312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/95312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
@@ -59,39 +68,67 @@ class MinidumpFileBuilder {
// Add ThreadList stream, containing information about all threads running
// at the moment of core saving. Contains information about thread
// contexts.
- lldb_private::Status AddThreadList(const lldb::ProcessSP &process_
@@ -40,7 +46,7 @@ lldb_private::Status WriteString(const std::string &to_write,
/// the data on heap.
class MinidumpFileBuilder {
public:
- MinidumpFileBuilder() = default;
+ MinidumpFileBuilder(lldb::FileUP&& core_file):
m_core_file(std::move(core_file)) {};
---
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
@@ -59,39 +68,67 @@ class MinidumpFileBuilder {
// Add ThreadList stream, containing information about all threads running
// at the moment of core saving. Contains information about thread
// contexts.
- lldb_private::Status AddThreadList(const lldb::ProcessSP &process_
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
@@ -59,39 +68,67 @@ class MinidumpFileBuilder {
// Add ThreadList stream, containing information about all threads running
// at the moment of core saving. Contains information about thread
// contexts.
- lldb_private::Status AddThreadList(const lldb::ProcessSP &process_
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
@@ -59,39 +68,67 @@ class MinidumpFileBuilder {
// Add ThreadList stream, containing information about all threads running
// at the moment of core saving. Contains information about thread
// contexts.
- lldb_private::Status AddThreadList(const lldb::ProcessSP &process_
@@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
}
}
-Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
- constexpr size_t header_size = sizeof(llvm::minidump::Header);
- constexpr size_t directory_size = sizeof(llvm::minidump::Directory
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/95350
Support case-insensitive regex matches for `SBTarget::FindGlobalFunctions` and
`SBTarget::FindGlobalVariables`.
>From a2a362aeaf3d091c04a2eaefc604962730aa483c Mon Sep 17 00:00:00 2001
From: Jonas Devliegher
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Support case-insensitive regex matches for `SBTarget::FindGlobalFunctions` and
`SBTarget::FindGlobalVariables`.
---
Full diff: https://github.com/llvm/llvm-project/pull/95350.diff
5 Files Affected
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
3fce14569fc3611eddca41db055143285244736a...a2a362aeaf3d091c04a2eaefc604962730aa483c
lldb/
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/95350
>From a2a362aeaf3d091c04a2eaefc604962730aa483c Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 12 Jun 2024 21:44:02 -0700
Subject: [PATCH 1/2] [lldb] Support case-insensitive regex matches
Suppo
medismailben wrote:
LGTM, may be we could also support this for the command line
```
(lldb) target modules lookup -F square
1 match found in /tmp/step:
Address: step[0x00013ee8] (step.__TEXT.__text + 0)
Summary: step`square at step.c:3
(lldb) target modules lookup -F Squa
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/95350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From 3b239e683362e8f9a1a9f9b9904ef4f77f4a4b3a Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 12 Jun 2024 22:11:12 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
74 matches
Mail list logo