================ @@ -797,20 +822,75 @@ void MinidumpFileBuilder::AddLinuxFileStreams( } } -Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const { - constexpr size_t header_size = sizeof(llvm::minidump::Header); - constexpr size_t directory_size = sizeof(llvm::minidump::Directory); +Status MinidumpFileBuilder::AddMemory(const ProcessSP &process_sp, + SaveCoreStyle core_style) { + Status error; + + Process::CoreFileMemoryRanges ranges_for_memory_list; ---------------- clayborg wrote:
It might be useful to create two Process::CoreFileMemoryRanges lists: one for 32 bit and one for 64 bit and have a variable that keeps track of what was already added: ``` uint64_t ranges_32_size = 0; Process::CoreFileMemoryRanges ranges_32; Process::CoreFileMemoryRanges ranges_64; ``` Then we can add regions to each list as needed below without having to remove anything from the `ranges` list below? https://github.com/llvm/llvm-project/pull/95312 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits