[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/91570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath requested changes to this pull request. You did not respond to my comment about generalizing this to accept a single "url" parameter. I'm not saying it has to be implemented that way, but I would like to hear your thoughts on it, as it definitely has some advantages (a

[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,142 @@ +""" +Test lldb-dap "port" configuration to "attach" request +""" + + +import dap_server +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil +from lldbsuite.test import lldbplatformutil +import lldb

[Lldb-commits] [lldb] [lldb/DWARF] Bypass the compres^Wconstruction of DIERefs in debug_names (PR #93296)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -183,27 +181,22 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( llvm::function_ref callback) { // Keep a list of incomplete types as fallback for when we don't find the // complete type. - DIEArray incomplete_types; + std::vector incomplete_types; -

[Lldb-commits] [lldb] 53d79fe - [lldb/DWARF] Bypass the compres^Wconstruction of DIERefs in debug_names (#93296)

2024-05-29 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-29T09:17:24+02:00 New Revision: 53d79feec93ef99e2ba0ac8cfc6cf2f81d28bf8a URL: https://github.com/llvm/llvm-project/commit/53d79feec93ef99e2ba0ac8cfc6cf2f81d28bf8a DIFF: https://github.com/llvm/llvm-project/commit/53d79feec93ef99e2ba0ac8cfc6cf2f81d28bf8a.diff

[Lldb-commits] [lldb] [lldb/DWARF] Bypass the compres^Wconstruction of DIERefs in debug_names (PR #93296)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2cfea14 - [lldb-dap] Add timestamps to protocol logs (#93540)

2024-05-29 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-29T09:27:32+02:00 New Revision: 2cfea14a57ad8443c6898d2310abb4346dc92ad2 URL: https://github.com/llvm/llvm-project/commit/2cfea14a57ad8443c6898d2310abb4346dc92ad2 DIFF: https://github.com/llvm/llvm-project/commit/2cfea14a57ad8443c6898d2310abb4346dc92ad2.diff

[Lldb-commits] [lldb] [lldb-dap] Add timestamps to protocol logs (PR #93540)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93540 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareWatchpointSize(const ArchSpec &arch, labath wrote: Doesn't this return t

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareWatchpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -115,8 +148,23 @@ Status NativeProcessSoftwareSingleStep::SetupSoftwareSingleStepping( emulator_up->SetWriteMemCallback(&WriteMemoryCallback); emulator_up->SetWriteRegCallback(&WriteRegisterCallback); - if (!emulator_up->ReadInstruction()) -return Status("Read ins

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -94,6 +94,39 @@ static lldb::addr_t ReadFlags(NativeRegisterContext ®siter_context) { LLDB_INVALID_ADDRESS); } +static int GetSoftwareWatchpointSize(const ArchSpec &arch, + lldb::addr_t ne

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,27 @@ +""" +Test that we can set up software breakpoint even if we failed to decode and execute instruction +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class TestBreakpoin

[Lldb-commits] [lldb] [lldb] Remove DWARFDebugInfo DIERef footguns (PR #92894)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/92894 >From e416051b09147b1083765795f711bb972e42a893 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Mon, 20 May 2024 14:51:52 + Subject: [PATCH] [lldb] Remove DWARFDebugInfo DIERef footguns DWARFDebugInfo doesn'

[Lldb-commits] [lldb] [lldb] Remove DWARFDebugInfo DIERef footguns (PR #92894)

2024-05-29 Thread Pavel Labath via lldb-commits
@@ -195,17 +195,17 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass( if (!ref) continue; -DWARFUnit *cu = m_debug_info.GetUnit(*ref); -if (!cu || !cu->Supports_DW_AT_APPLE_objc_complete_type()) { - incomplete_types.push_back(*ref); - continue; -

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Pavel Labath via lldb-commits
labath wrote: > I have a follow up question. It sounds like you've answered it yourself. :) With this kind of debug info, lldb would think this refers to a global entity and return it for queries like `::InnerState`. Without that entry, lldb will (correctly) look up the context in the DIE tr

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Sorry for the delayed response, just got back from vacation. > What do these numbers include? Is it just the operation it self, or > everything leading up to it as well. > Thanks for doing this. What do these numbers include? Is it just the > operation it self, or everything

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Pavel Labath via lldb-commits
labath wrote: > Discussed with Pavel, I applied this change to #92328 so we can ensure the > DIEs from the index is always definition DIEs and avoid duplicate/expensive > checks later. To elaborate, I suggested Zequan does this, because I think there's consensus that this is a good way to fil

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-29 Thread David Spickett via lldb-commits
DavidSpickett wrote: The new tests are flaky on Windows on Arm, I'm looking into it. https://github.com/llvm/llvm-project/pull/92014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] Refactor DWARFDIE::Get{Decl, TypeLookup}Context (PR #93291)

2024-05-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM! (seems like we could probably add unit-tests for this in `lldb/unittests/SymbolFile/DWARF/DWARFDIETest.cpp`? But not a blocker) https://github.com/llvm/llvm-project/pull/93291 ___ lldb-c

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-29 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov updated https://github.com/llvm/llvm-project/pull/93297 >From d30c3b7017bd9f4b9f442ee728d7e3d7847c60cf Mon Sep 17 00:00:00 2001 From: Alexey Merzlyakov Date: Fri, 24 May 2024 11:54:16 +0300 Subject: [PATCH 1/2] Add RegisterContextPOSIXCore for RISC-V 64 Fix

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-29 Thread Alexey Merzlyakov via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-29 Thread Alexey Merzlyakov via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] 971f1aa - [lldb][Test][Windows] Fix flaky address range API tests

2024-05-29 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-05-29T10:07:47Z New Revision: 971f1aaad3ca3680bfbab76212f498ca15b280a2 URL: https://github.com/llvm/llvm-project/commit/971f1aaad3ca3680bfbab76212f498ca15b280a2 DIFF: https://github.com/llvm/llvm-project/commit/971f1aaad3ca3680bfbab76212f498ca15b280a2.diff LOG

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-29 Thread David Spickett via lldb-commits
DavidSpickett wrote: The tests were hitting a deadlock trying to kill the test process in async debug mode. So I've just changed it to sync mode, as I didn't see any reason to be async here. It's a symptom of something greater I expect but I don't have time to dig into it at the moment. http

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-29 Thread Alexey Merzlyakov via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-29 Thread Alexey Merzlyakov via lldb-commits
https://github.com/AlexeyMerzlyakov edited https://github.com/llvm/llvm-project/pull/93297 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add RegisterContextPOSIXCore for RISC-V 64 (PR #93297)

2024-05-29 Thread Alexey Merzlyakov via lldb-commits
@@ -0,0 +1,84 @@ +//===-- RegisterContextPOSIXCore_riscv64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] 23a09b9 - [lldb][Test] Remove some xfails for AArch64 Linux

2024-05-29 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-05-29T10:28:10Z New Revision: 23a09b99313edb67d267a974be6cebfdfd97c7c8 URL: https://github.com/llvm/llvm-project/commit/23a09b99313edb67d267a974be6cebfdfd97c7c8 DIFF: https://github.com/llvm/llvm-project/commit/23a09b99313edb67d267a974be6cebfdfd97c7c8.diff LOG

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-29 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/93458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] Refactor DWARFDIE::Get{Decl, TypeLookup}Context (PR #93291)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/93291 >From 8463c2433609216499fe5d04c3397a3113071a49 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 24 May 2024 10:17:40 + Subject: [PATCH 1/2] [lldb/DWARF] Refactor DWARFDIE::Get{Decl,TypeLookup}Context A

[Lldb-commits] [lldb] [lldb/DWARF] Refactor DWARFDIE::Get{Decl, TypeLookup}Context (PR #93291)

2024-05-29 Thread Pavel Labath via lldb-commits
labath wrote: Good idea. I've added one quick test. I'll add more as I work on these functions further. PTAL https://github.com/llvm/llvm-project/pull/93291 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb/DWARF] Refactor DWARFDIE::Get{Decl, TypeLookup}Context (PR #93291)

2024-05-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. nice! tests also LGTM https://github.com/llvm/llvm-project/pull/93291 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-29 Thread Michael Buch via lldb-commits
Michael137 wrote: @labath baseline for just attaching is approximately `3 s` for LLDB and `2.5 s`. Baselines for attaching *and* stopping at the breakpoint are in the `break only` rows of the table. https://github.com/llvm/llvm-project/pull/91452 ___

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Now that we don't search for the definition DIE when initially parsing a DIE, we could probably move this progress report to when we look for `FindDefinitionTypeForDIE`, which seems to be the most expensive part of the `DWARFASTParser` https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] 8e12904 - [lldb/DWARF] Refactor DWARFDIE::Get{Decl, TypeLookup}Context (#93291)

2024-05-29 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-29T14:19:49+02:00 New Revision: 8e1290432adf33a7aeca65a53d1faa7577ed0e66 URL: https://github.com/llvm/llvm-project/commit/8e1290432adf33a7aeca65a53d1faa7577ed0e66 DIFF: https://github.com/llvm/llvm-project/commit/8e1290432adf33a7aeca65a53d1faa7577ed0e66.diff

[Lldb-commits] [lldb] [lldb/DWARF] Refactor DWARFDIE::Get{Decl, TypeLookup}Context (PR #93291)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93291 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/DWARF] Follow DW_AT_signature when computing type contexts (PR #93675)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/93675 This is necessary to correctly resolve the context within types, as the name of the type is only present in the type unit. (The DWARFYAML enthusiasm didn't last long, as it does not support type units. It can st

[Lldb-commits] [lldb] [lldb/DWARF] Follow DW_AT_signature when computing type contexts (PR #93675)

2024-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This is necessary to correctly resolve the context within types, as the name of the type is only present in the type unit. (The DWARFYAML enthusiasm didn't last long, as it does not support type units. It can

[Lldb-commits] [lldb] [WIP] [lldb][Progress] Report progress when completing types from DWARF (PR #91452)

2024-05-29 Thread Pavel Labath via lldb-commits
labath wrote: > @labath baseline for just attaching is approximately `3 s` for LLDB and `2.5 > s`. Baselines for attaching _and_ stopping at the breakpoint are in the > `break only` rows of the table. Thanks. I think this resolves my concerns about this patch. If we do find a particularly exp

[Lldb-commits] [lldb] [lldb/DWARF] Follow DW_AT_signature when computing type contexts (PR #93675)

2024-05-29 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/93675 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (PR #93688)

2024-05-29 Thread Miro Bucko via lldb-commits
https://github.com/mbucko created https://github.com/llvm/llvm-project/pull/93688 Summary: Moving CommandObjectMemoryFind::FastSearch() to Process::FindInMemory(). Plan to expose FindInMemory as public API in SBProcess. Test Plan: ninja check-lldb Reviewers: clayborg Subscribers: Tasks: lld

[Lldb-commits] [lldb] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (PR #93688)

2024-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Summary: Moving CommandObjectMemoryFind::FastSearch() to Process::FindInMemory(). Plan to expose FindInMemory as public API in SBProcess. Test Plan: ninja check-lldb Reviewers: clayborg Subscribers: Tasks: ll

[Lldb-commits] [lldb] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (PR #93688)

2024-05-29 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bbca20f0b1ab7c6ea36a84e88a6abb07f94ca80b b6ac1147a441d774c8a5ea4c2de620b72be151e2 --

[Lldb-commits] [lldb] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (PR #93688)

2024-05-29 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/93688 >From 6e461bef5a7f3bda3ff413168b3cc2a26b41cdb0 Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Wed, 29 May 2024 06:38:22 -0700 Subject: [PATCH] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process

[Lldb-commits] [lldb] 799316f - [lldb][NFC] Pass Stream& to ToXML methods in RegisterFlags

2024-05-29 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-05-29T14:27:30Z New Revision: 799316ff26cc82d60f276dc62c4a69b5bba1aef3 URL: https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3 DIFF: https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3.diff LOG

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-29 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/90063 >From 722704c323a68d426e127308f8e247fb7f94e414 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 11 Mar 2024 10:51:22 + Subject: [PATCH] [lldb] Add register field enum class This represents the

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-29 Thread David Spickett via lldb-commits
@@ -13,11 +13,42 @@ #include #include +#include "llvm/ADT/StringSet.h" + namespace lldb_private { class StreamString; class Log; +class FieldEnum { +public: + struct Enumerator { +uint64_t m_value; +// Short name for the value. Shown in tables and when printi

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-29 Thread David Spickett via lldb-commits
@@ -13,11 +13,42 @@ #include #include +#include "llvm/ADT/StringSet.h" + namespace lldb_private { class StreamString; class Log; +class FieldEnum { +public: + struct Enumerator { +uint64_t m_value; +// Short name for the value. Shown in tables and when printi

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-29 Thread David Spickett via lldb-commits
@@ -13,11 +13,42 @@ #include #include +#include "llvm/ADT/StringSet.h" + namespace lldb_private { class StreamString; class Log; +class FieldEnum { +public: + struct Enumerator { +uint64_t m_value; +// Short name for the value. Shown in tables and when printi

[Lldb-commits] [lldb] [lldb] Add register field enum class (PR #90063)

2024-05-29 Thread David Spickett via lldb-commits
DavidSpickett wrote: Rebased to include https://github.com/llvm/llvm-project/commit/799316ff26cc82d60f276dc62c4a69b5bba1aef3 and have addressed the open comments. https://github.com/llvm/llvm-project/pull/90063 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-29 Thread Michael Buch via lldb-commits
Michael137 wrote: I'm going to revert this for now until since the bots have been red for a while now https://github.com/llvm/llvm-project/pull/92865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] fe82a3d - Revert "[Support] Remove terminfo dependency (#92865)"

2024-05-29 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2024-05-29T16:20:42+01:00 New Revision: fe82a3da36196157c0caa1ef2505186782f750d1 URL: https://github.com/llvm/llvm-project/commit/fe82a3da36196157c0caa1ef2505186782f750d1 DIFF: https://github.com/llvm/llvm-project/commit/fe82a3da36196157c0caa1ef2505186782f750d1.diff

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > > Discussed with Pavel, I applied this change to #92328 so we can ensure the > > DIEs from the index is always definition DIEs and avoid duplicate/expensive > > checks later. > > To elaborate, I suggested Zequan does this, because I think there's consensus > that this

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: thanks for well-written summary @dwblaikie ! https://github.com/llvm/llvm-project/pull/91808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove DWARFDebugInfo DIERef footguns (PR #92894)

2024-05-29 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/92894 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cfb209b - [lldb][lldb-dap] Cleanup breakpoint filters. (#87550)

2024-05-29 Thread via lldb-commits
Author: Vy Nguyen Date: 2024-05-29T12:22:42-04:00 New Revision: cfb209b92a26f16ed7413b32da20fc436eff8c58 URL: https://github.com/llvm/llvm-project/commit/cfb209b92a26f16ed7413b32da20fc436eff8c58 DIFF: https://github.com/llvm/llvm-project/commit/cfb209b92a26f16ed7413b32da20fc436eff8c58.diff LOG

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

2024-05-29 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/87550 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update LLDB testsuite's Makefile.rules in order to support the cross builds on Windows host. (PR #93639)

2024-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladimir Vereschaka (vvereschaka) Changes These changes do the following: * avoids usage of $(findstring) within $(CC) to detect a type of specified C compiler. Also they change a way to get a counterpart C++ compiler instead of modifying

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-29 Thread Michael Buch via lldb-commits
Michael137 wrote: FYI, the `TestAddressRange` tests are failing on the macOS buildbots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/4764/execution/node/97/log/ ``` == FAIL: test_address_range_print_resolv

[Lldb-commits] [lldb] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (PR #93688)

2024-05-29 Thread via lldb-commits
https://github.com/jimingham approved this pull request. It's not a good idea in general to have useful algorithms in the CommandObjects, that leads to code duplication - people can't be expected to scour the CommandObjects for stealable code So this sort of move is a good tidying up even

[Lldb-commits] [lldb] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (PR #93688)

2024-05-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/93688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2655897 - [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (#93688)

2024-05-29 Thread via lldb-commits
Author: Miro Bucko Date: 2024-05-29T10:37:57-07:00 New Revision: 265589785ccf043492e4e0ab88c2830eae7d3496 URL: https://github.com/llvm/llvm-project/commit/265589785ccf043492e4e0ab88c2830eae7d3496 DIFF: https://github.com/llvm/llvm-project/commit/265589785ccf043492e4e0ab88c2830eae7d3496.diff LO

[Lldb-commits] [lldb] [nfc][lldb] Move FastSearch from CommandObjectMemoryFind to Process (PR #93688)

2024-05-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/93688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix formatter tests for clang version 15 (PR #93710)

2024-05-29 Thread Miro Bucko via lldb-commits
https://github.com/mbucko created https://github.com/llvm/llvm-project/pull/93710 Summary: Test Plan: ninja check-lldb Reviewers: clayborg Subscribers: Tasks: Tags: >From b6c70ac7b4c479fcdeb5d5c8b06da5a16ae468c4 Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Wed, 29 May 2024 10:28:16 -07

[Lldb-commits] [lldb] [lldb][test] Fix formatter tests for clang version 15 (PR #93710)

2024-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Miro Bucko (mbucko) Changes Summary: Test Plan: ninja check-lldb Reviewers: clayborg Subscribers: Tasks: Tags: --- Full diff: https://github.com/llvm/llvm-project/pull/93710.diff 15 Files Affected: - (modified) lldb/test/API/comman

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/93712 Use the packaging [1] module for parsing version numbers, instead of pkg_resources which is distributed with setuptools. I recently switched over to using the latter, knowing it was deprecated (in favor of

[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)

2024-05-29 Thread Miro Bucko via lldb-commits
mbucko wrote: If the a.out is not there then the address was not resolved, I will investigate. https://github.com/llvm/llvm-project/pull/92014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Use the packaging [1] module for parsing version numbers, instead of pkg_resources which is distributed with setuptools. I recently switched over to using the latter, knowing it was deprecated (in f

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Augusto Noronha via lldb-commits
https://github.com/augusto2112 approved this pull request. https://github.com/llvm/llvm-project/pull/93712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/93712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove setupterm workaround on macOS (PR #93714)

2024-05-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/93714 Remove setupterm workaround on macOS which caused an issues after the removal of the terminfo dependency. There's a comment that explains why the workaround is present, but neither Jim nor I were able to re

[Lldb-commits] [lldb] [lldb] Remove setupterm workaround on macOS (PR #93714)

2024-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Remove setupterm workaround on macOS which caused an issues after the removal of the terminfo dependency. There's a comment that explains why the workaround is present, but neither Jim nor I were ab

[Lldb-commits] [lldb] [lldb] Remove setupterm workaround on macOS (PR #93714)

2024-05-29 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/93714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht approved this pull request. LGTM, but heads up for @mysterymath if this causes issues w/ Fuchsia's build https://github.com/llvm/llvm-project/pull/93712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [clang] [lldb] [llvm] Revert "[IR] Update ptrauth const prop test to avoid constant icmp." (PR #93715)

2024-05-29 Thread Francis Visoiu Mistrih via lldb-commits
https://github.com/francisvm created https://github.com/llvm/llvm-project/pull/93715 None error: too big or took too long to generate ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [clang] [lldb] [llvm] Revert "[IR] Update ptrauth const prop test to avoid constant icmp." (PR #93715)

2024-05-29 Thread Francis Visoiu Mistrih via lldb-commits
https://github.com/francisvm closed https://github.com/llvm/llvm-project/pull/93715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/93712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove setupterm workaround on macOS (PR #93714)

2024-05-29 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/93714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: > > I have a follow up question. > > It sounds like you've answered it yourself. :) > > With this kind of debug info, lldb would think this refers to a global entity > and return it for queries like `::InnerState`. Without that entry, lldb will > (correctly) look up the contex

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Daniel Thornburgh via lldb-commits
mysterymath wrote: At least at present, this will probably break Fuchsia's build; the Python we ship includes `pkg_resources` but not `packaging`. Is the default `cpython` build from source intended to build and install `packaging`? Is this something that changed recently? https://github.com/

[Lldb-commits] [lldb] [lldb] Remove setupterm workaround on macOS (PR #93714)

2024-05-29 Thread via lldb-commits
jimingham wrote: I tried running this lldb on a vt100 terminal, and ran lldb under lldb, but doing: (top-lldb) env TERM=vt100 (top-lldb) run in case it was switching the terminal that was causing the issue. We don't work wonderfully in a vt100 terminal, for instance if you do: ``` (lldb) bre

[Lldb-commits] [lldb] [lldb][lldb-dap] Cleanup breakpoint filters. (PR #87550)

2024-05-29 Thread via lldb-commits
gulfemsavrun wrote: We started seeing lldb test failures in `TestDAP*`. ``` == FAIL: test_commands (TestDAP_launch.TestDAP_launch.test_commands) Tests the "initCommands", "preRunCommands", "stopCommands",

[Lldb-commits] [lldb] Revert "[lldb][lldb-dap] Cleanup breakpoint filters." (PR #93739)

2024-05-29 Thread via lldb-commits
https://github.com/gulfemsavrun created https://github.com/llvm/llvm-project/pull/93739 Reverts llvm/llvm-project#87550 because it broke `TestDAP*` lldb tests. >From 9f72683d223dd8b05ba5efc7590fbb9c725d55c1 Mon Sep 17 00:00:00 2001 From: gulfemsavrun Date: Wed, 29 May 2024 13:44:48 -0700 Subje

[Lldb-commits] [lldb] Revert "[lldb][lldb-dap] Cleanup breakpoint filters." (PR #93739)

2024-05-29 Thread via lldb-commits
https://github.com/gulfemsavrun edited https://github.com/llvm/llvm-project/pull/93739 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb][lldb-dap] Cleanup breakpoint filters." (PR #93739)

2024-05-29 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (gulfemsavrun) Changes Reverts llvm/llvm-project#87550 because it broke `TestDAP*` lldb tests. https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8746585790559468897/overview --- Full diff: https://gi

[Lldb-commits] [lldb] 6595e7f - Revert "[lldb][lldb-dap] Cleanup breakpoint filters." (#93739)

2024-05-29 Thread via lldb-commits
Author: gulfemsavrun Date: 2024-05-29T13:56:37-07:00 New Revision: 6595e7fa1b5588f860aa057aac47c43623169584 URL: https://github.com/llvm/llvm-project/commit/6595e7fa1b5588f860aa057aac47c43623169584 DIFF: https://github.com/llvm/llvm-project/commit/6595e7fa1b5588f860aa057aac47c43623169584.diff

[Lldb-commits] [lldb] Revert "[lldb][lldb-dap] Cleanup breakpoint filters." (PR #93739)

2024-05-29 Thread via lldb-commits
https://github.com/gulfemsavrun closed https://github.com/llvm/llvm-project/pull/93739 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c6c08ee - [lldb] Remove setupterm workaround on macOS (#93714)

2024-05-29 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-29T14:21:06-07:00 New Revision: c6c08eee37bada190bd1aa4593c88a5e2c8cdaac URL: https://github.com/llvm/llvm-project/commit/c6c08eee37bada190bd1aa4593c88a5e2c8cdaac DIFF: https://github.com/llvm/llvm-project/commit/c6c08eee37bada190bd1aa4593c88a5e2c8cdaac.d

[Lldb-commits] [lldb] [lldb] Remove setupterm workaround on macOS (PR #93714)

2024-05-29 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/93714 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-05-29 Thread Michael Buch via lldb-commits
Michael137 wrote: Unfortunately this breaks `TestCPPAccelerator.py` on the macOS buildbots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/4788/execution/node/97/log/ ``` Ran command: "log enable dwarf lookups -f/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/lldb

[Lldb-commits] [lldb] [lldb] Use packaging module instead of pkg_resources (PR #93712)

2024-05-29 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > At least at present, this will probably break Fuchsia's build; the Python we > ship includes `pkg_resources` but not `packaging`. Is the default `cpython` > build from source intended to build and install `packaging`? Is this > something that changed recently? I'm not su

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/91808 >From 0cc1be6988e6ab5498151f32485f525a66133be2 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Fri, 10 May 2024 13:49:22 -0700 Subject: [PATCH 1/2] Improve performance of .debug_names lookups when DW_IDX_pare

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Alexander Yermolovich via lldb-commits
ayermolo wrote: I have another question. For the same example. I see: ``` Name 4 { Hash: 0x2F94396D String: 0x0049 "_Z9get_statev" Entry @ 0x112 { Abbrev: 0x2 Tag: DW_TAG_subprogram DW_IDX_die_offset: 0x0023 DW_IDX_parent: } ...

[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

2024-05-29 Thread Greg Clayton via lldb-commits
clayborg wrote: So I am trying to lookup `std::ios_base` in my example for a real definitions, but I end up with thousands of forward declarations due to the DWARF snippet in my original summary string. So when I lookup `std::ios_base`, I found thousands of `DW_AT_declaration` entries for `s

[Lldb-commits] [lldb] 3e023d8 - [lldb] Remove DWARFDebugInfo DIERef footguns (#92894)

2024-05-29 Thread via lldb-commits
Author: Pavel Labath Date: 2024-05-30T07:48:59+02:00 New Revision: 3e023d87d8e9a7bcf0a2feb2cee9b9ca47643a7e URL: https://github.com/llvm/llvm-project/commit/3e023d87d8e9a7bcf0a2feb2cee9b9ca47643a7e DIFF: https://github.com/llvm/llvm-project/commit/3e023d87d8e9a7bcf0a2feb2cee9b9ca47643a7e.diff

[Lldb-commits] [lldb] [lldb] Remove DWARFDebugInfo DIERef footguns (PR #92894)

2024-05-29 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/92894 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits