labath wrote:

> @labath baseline for just attaching is approximately `3 s` for LLDB and `2.5 
> s`. Baselines for attaching _and_ stopping at the breakpoint are in the 
> `break only` rows of the table.

Thanks. I think this resolves my concerns about this patch. If we do find a 
particularly expensive/hot place reporting progress events, we can always 
remove it.

> Now that we don't search for the definition DIE when initially parsing a DIE, 
> we could probably move this progress report to `FindDefinitionTypeForDIE`, 
> which seems to be the most expensive part of the `DWARFASTParser`

SGTM

https://github.com/llvm/llvm-project/pull/91452
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to