https://github.com/DavidSpickett approved this pull request.
Testing sounds like more effort than it's worth, let's not block this on that.
https://github.com/llvm/llvm-project/pull/74414
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrot
https://github.com/mariusz-sikora-at-amd updated
https://github.com/llvm/llvm-project/pull/74576
>From 23759746b66c33028ad2340b1e98067ebf1f8074 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Tue, 28 Jun 2022 15:24:24 -0700
Subject: [PATCH] [AMDGPU] GFX12: select @llvm.prefetch intri
@@ -959,6 +967,32 @@ def : GCNPat <
}
} // let OtherPredicates = [HasShaderCyclesRegister]
+def SIMM24bitPtr : ImmLeaf (Imm);}]
+>;
+
+multiclass SMPrefetchPat {
+ def : GCNPat <
+(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32
cache_type)),
+(!cas
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/74616
>From 69580e5f77514fecf0aabe2a80c98881f9bd7288 Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Tue, 7 Feb 2023 16:27:27 +
Subject: [PATCH 1/2] [AMDGPU] Add GFX12 encoding for VINTERP instructions
---
.../Disa
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/74616
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-12-07T11:38:26Z
New Revision: 7de53a8cfe45f60334dc3765c0bfc94beaf09883
URL:
https://github.com/llvm/llvm-project/commit/7de53a8cfe45f60334dc3765c0bfc94beaf09883
DIFF:
https://github.com/llvm/llvm-project/commit/7de53a8cfe45f60334dc3765c0bfc94beaf09883.diff
LOG:
@@ -959,6 +967,32 @@ def : GCNPat <
}
} // let OtherPredicates = [HasShaderCyclesRegister]
+def SIMM24bitPtr : ImmLeaf (Imm);}]
+>;
+
+multiclass SMPrefetchPat {
+ def : GCNPat <
+(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32
cache_type)),
+(!cas
https://github.com/mariusz-sikora-at-amd updated
https://github.com/llvm/llvm-project/pull/74576
>From 23759746b66c33028ad2340b1e98067ebf1f8074 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin
Date: Tue, 28 Jun 2022 15:24:24 -0700
Subject: [PATCH 1/2] [AMDGPU] GFX12: select @llvm.prefetch i
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/9] [lldb] colorize symbols in image look
junior-jl wrote:
In the last commit:
- Added the conditions `prefix.empty()` and `suffix.empty()` to the 'no color'
path.
- Added missing arguments to `PutCStringColorHighlighted` call in
`SymbolContext` (line 177).
I had to copy the same statements from line 99 here. Is it better if I declar
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
junior-jl wrote:
> You could do:
s->PutCStringColorHighlighted(symbol->GetName().GetStringRef(), pattern,
target_sp ? target_sp->GetDebugger().GetRegexMatchAnsiPrefix() :
"",
target_sp ? target_sp->GetDebugger().GetRegexMatchAnsiSuffix() :
"");
I
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Re
junior-jl wrote:
> If the prefix and suffix are empty. Not prefix or suffix is empty.
I tried this now and I guess it's not correct. For example, if I have a prefix
(red color) and no suffix, the text does not go back to normal and will be
forever red. Or am I doing something wrong?
> Or rath
junior-jl wrote:
> I tried this now and I guess it's not correct. For example, if I have a
> prefix (red color) and no suffix, the text does not go back to normal and
> will be forever red. Or am I doing something wrong?
 thr list
Process 2960 stopped
thread #53: tid = 0x03a0, 0x7ff84582db34
ntdll.dll`NtWaitForMultipleObjects + 20
thread #29: tid = 0x04ec
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: oltolm (oltolm)
Changes
This PR adds support for thread names in lldb on Windows.
```
(lldb) thr list
Process 2960 stopped
thread #53: tid = 0x03a0, 0x7ff84582db34
ntdll.dll`NtWaitForMultipleObjects + 20
thread #29: tid = 0x04ec, 0
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dfd36aa70ec1cff0529272b00f6c6a81bf0cc49c
b9accfb579b6d2718ad12ee55dacf38257693d56 --
https://github.com/oltolm updated
https://github.com/llvm/llvm-project/pull/74731
>From 9383b8b92849c71a96b4b4e7e55f615d8f2efedb Mon Sep 17 00:00:00 2001
From: oltolm
Date: Fri, 1 Dec 2023 16:49:13 +0100
Subject: [PATCH] lldb: add support for thread names on Windows
---
.../Windows/Common/Tar
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 01/10] [lldb] colorize symbols in image lo
junior-jl wrote:
> > I tried this now and I guess it's not correct. For example, if I have a
> > prefix (red color) and no suffix, the text does not go back to normal and
> > will be forever red. Or am I doing something wrong?
>
> This is expected. We don't expect many people to do this but if
https://github.com/JMazurkiewicz updated
https://github.com/llvm/llvm-project/pull/74655
>From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Wed, 6 Dec 2023 14:03:51 +0100
Subject: [PATCH 1/9] [libc++] Fix `take_view::__sentinel`'s `operator==`
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?=
https://github.com/yi-wu-arm updated
https://github.com/llvm/llvm-project/pull/71222
>From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001
From: Yi Wu
Date: Mon, 6 Nov 2023 19:55:06 +
Subject: [PATCH 01/10] FDATE extension implementation: get date and time in
ctime format
https://github.com/yi-wu-arm updated
https://github.com/llvm/llvm-project/pull/71222
>From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001
From: Yi Wu
Date: Mon, 6 Nov 2023 19:55:06 +
Subject: [PATCH 01/11] FDATE extension implementation: get date and time in
ctime format
https://github.com/JMazurkiewicz updated
https://github.com/llvm/llvm-project/pull/74655
>From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Wed, 6 Dec 2023 14:03:51 +0100
Subject: [PATCH 01/10] [libc++] Fix `take_view::__sentinel`'s `operator=
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/74687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM, small typo
https://github.com/llvm/llvm-project/pull/74687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -558,7 +558,10 @@ class Process : public
std::enable_shared_from_this,
///
/// Subclasses that override this method should always call this superclass
/// method.
- virtual void Finalize();
+ /// If you are running Finalize in your Process subclass Destructor, pass
@@ -33,6 +34,9 @@
using namespace lldb;
using namespace lldb_private;
+using GetThreadDescriptionFunctionPtr = HRESULT
+WINAPI (*)(HANDLE hThread, PWSTR *ppszThreadDescription);
+
clayborg wrote:
Can we just `#include ` and avoid manually declaring a
functio
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
https://github.com/bulbazord commented:
The implementation looks fine to me. Can you write a test?
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
clayborg wrote:
@JDevlieghere Can you delete the `llvm-project/lldb/tools/lldb-vscode`
directory from git after this commit to clean up our codebase? There are still
two copies of the `lldb-dap` code in the sources:
```
lldb/tools/lldb-dap
lldb/tools/lldb-vscode
```
I worry someone might make P
@@ -959,6 +967,32 @@ def : GCNPat <
}
} // let OtherPredicates = [HasShaderCyclesRegister]
+def SIMM24bitPtr : ImmLeaf (Imm);}]
+>;
+
+multiclass SMPrefetchPat {
+ def : GCNPat <
+(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32
cache_type)),
+(!cas
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/74687
>From 64505f573341c16a62eda786c4710d3a7233cecc Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Wed, 6 Dec 2023 17:01:06 -0800
Subject: [PATCH 1/2] We need to generate events when finalizing, or we won't
know t
https://github.com/clayborg approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/74687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> @JDevlieghere Can you delete the `llvm-project/lldb/tools/lldb-vscode`
> directory from git after this commit to clean up our codebase? There are
> still two copies of the `lldb-dap` code in the sources:
>
> ```
> lldb/tools/lldb-dap
> lldb/tools/lldb-vscode
> ```
>
> I wor
kevinfrei wrote:
> > This change broke building against LLVM dylib:
> > ```
> > /usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld:
> > cannot find -lLLVMDebuginfod: No such file or directory
> > collect2: error: ld returned 1 exit status
> > samu: subcommand failed
> > `
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/74748
There are some typescript vscode extensions that are effectively wrappers of
lldb-dap, and they commonly configure the debug adapter in particular ways
using initCommands, among other settings. An unfor
@@ -959,6 +967,32 @@ def : GCNPat <
}
} // let OtherPredicates = [HasShaderCyclesRegister]
+def SIMM24bitPtr : ImmLeaf (Imm);}]
+>;
+
+multiclass SMPrefetchPat {
+ def : GCNPat <
+(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32
cache_type)),
+(!cas
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/74748
>From 07bd16ac9bbc4f9868d1b541e003aa95bf6ae8be Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Wed, 29 Nov 2023 18:12:54 -0500
Subject: [PATCH] [lldb-dap] Introduce the new privateConfiguration set
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/74748
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/pizzud closed https://github.com/llvm/llvm-project/pull/66139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
pizzud wrote:
I've been kind of leaving this in limbo while we sort out the shared_ptr one
and I agree it probably makes more sense to make bugprone-unique-pointer-move
as a parallel to shared-pointer in [PR
#67467](https://github.com/llvm/llvm-project/pull/67467) and consider
performance-hea
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
There are some typescript vscode extensions that are effectively wrappers of
lldb-dap, and they commonly configure the debug adapter in particular ways
using initCommands, among other settings. A
clayborg wrote:
Sounds like some configs don't create `LLVMDebuginfod` target possibly because
it isn't enabled. Is there a cmake option to disable `LLVMDebuginfod` or some
magic in the Cmake config file for this target?
https://github.com/llvm/llvm-project/pull/70996
_
@@ -959,6 +967,32 @@ def : GCNPat <
}
} // let OtherPredicates = [HasShaderCyclesRegister]
+def SIMM24bitPtr : ImmLeaf (Imm);}]
+>;
+
+multiclass SMPrefetchPat {
+ def : GCNPat <
+(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32
cache_type)),
+(!cas
@@ -0,0 +1,21 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Recommends avoiding moving out of a smart pointer when moving the pointer is
EugeneZelenko wrot
@@ -0,0 +1,21 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Recommends avoiding moving out of a smart pointer when moving the pointer is
+cheaper.
+
+Given a smart pointer
https://github.com/clayborg commented:
I am not a fan of making a whole extra duplication of "initCommands" just to
make these commands not show up in the debug console. Wouldn't a setting like:
```
"showCommandsInDebugConsole": ["always", "error-only", "never"]
```
Would this achieve the sam
https://github.com/JMazurkiewicz updated
https://github.com/llvm/llvm-project/pull/74655
>From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Wed, 6 Dec 2023 14:03:51 +0100
Subject: [PATCH 01/10] [libc++] Fix `take_view::__sentinel`'s `operator=
clayborg wrote:
Another idea would be to add a command that allows users to specify the console
to log LLDB commands from `*Commands` settings by allowing them to specify a
console. From the DAP spec we have:
```
/**
* The output category. If not specified or if the category is not
*
clayborg wrote:
> > @JDevlieghere Can you delete the `llvm-project/lldb/tools/lldb-vscode`
> > directory from git after this commit to clean up our codebase? There are
> > still two copies of the `lldb-dap` code in the sources:
> > ```
> > lldb/tools/lldb-dap
> > lldb/tools/lldb-vscode
> > ```
@@ -175,3 +179,30 @@ Status TargetThreadWindows::DoResume() {
return Status();
}
+
+const char *TargetThreadWindows::GetName() {
+ Log *log = GetLog(LLDBLog::Thread);
+ HMODULE hModule = ::LoadLibraryW(L"Kernel32.dll");
+ if (hModule) {
+auto GetThreadDescription =
+
https://github.com/Fulgen301 edited
https://github.com/llvm/llvm-project/pull/74731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kevinfrei wrote:
> Sounds like some configs don't create `LLVMDebuginfod` target possibly
> because it isn't enabled. Is there a cmake option to disable `LLVMDebuginfod`
> or some magic in the Cmake config file for this target?
Nothing that I could find. The library is written such that if the
https://github.com/clayborg commented:
Sounds like there is good reason for linking in the kernel32.dll, so code looks
good to me. A windows only test that creates a thread with a known name would
be great to add where we verify the name is correct.
https://github.com/llvm/llvm-project/pull/74
davemgreen wrote:
Hello. I think that if you removed undef from the first instruction the result
would still be incorrect. With:
```
$x8 = ORRXrs $xzr, $x0, 0, implicit $w0
$w8 = ORRWrs $wzr, $w0, 0, implicit-def $x8
```
The second instruction will zero-extend the w0 register to x8. It would be
https://github.com/jasonmolenda approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/74687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
The change itself LGTM, but I'd like to either have an inline comment (e.g.
`Finalize(/*destructing=*/false)) `or use an enum value to convey the meaning
of those values.
https://github.com/llvm/llvm-project/pull/74687
walter-erquinigo wrote:
@clayborg , the main issue is to allow users to use the regular initCommands
and at the same time have another way for the vscode extension to issue their
own initCommands and control the output of these specific commands without
interfering with the initCommands provid
https://github.com/huixie90 approved this pull request.
LGTM with green CI
https://github.com/llvm/llvm-project/pull/74655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -183,7 +183,7 @@ class take_view<_View>::__sentinel {
template
requires sentinel_for,
iterator_t<__maybe_const<_OtherConst, _View>>>
_LIBCPP_HIDE_FROM_ABI
- friend constexpr bool operator==(const _Iter<_Const>& __lhs, const
__sentinel& __rhs) {
+ friend constexpr
https://github.com/huixie90 edited
https://github.com/llvm/llvm-project/pull/74655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/huixie90 edited
https://github.com/llvm/llvm-project/pull/74655
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
- P
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/74772
In optimized code we can end up with return address being the next instruction
in a different block. If we are dealing with location lists, we want to
decrement the PC value so it's within the calling block r
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
In optimized code we can end up with return address being the next instruction
in a different block. If we are dealing with location lists, we want to
decrement the PC value so it's within the calling bloc
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/74772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/74772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/74773
There was duplicated (and complex) code querying whether tags were type-like
tags (i.e. class or struct); this has been factored out into a helper function.
There was also a comment about not comparing id
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
There was duplicated (and complex) code querying whether tags were type-like
tags (i.e. class or struct); this has been factored out into a helper function.
There was also a comment about
@@ -2947,29 +2951,18 @@ TypeSP
SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE(
m_index->GetCompleteObjCClass(
type_name, must_be_implementation, [&](DWARFDIE type_die) {
-bool try_resolving_type = false;
-
// Don't try and resolve the DIE we ar
@@ -3128,36 +3121,11 @@
SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) {
if (type_system &&
!type_system->SupportsLanguage(GetLanguage(*type_die.GetCU(
return true;
- bool try_resolving_type = false;
- // Don
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2947,29 +2951,18 @@ TypeSP
SymbolFileDWARF::FindCompleteObjCDefinitionTypeForDIE(
m_index->GetCompleteObjCClass(
type_name, must_be_implementation, [&](DWARFDIE type_die) {
-bool try_resolving_type = false;
-
// Don't try and resolve the DIE we ar
@@ -183,7 +183,7 @@ class take_view<_View>::__sentinel {
template
requires sentinel_for,
iterator_t<__maybe_const<_OtherConst, _View>>>
_LIBCPP_HIDE_FROM_ABI
- friend constexpr bool operator==(const _Iter<_Const>& __lhs, const
__sentinel& __rhs) {
+ friend constexpr
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/74687
>From 64505f573341c16a62eda786c4710d3a7233cecc Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Wed, 6 Dec 2023 17:01:06 -0800
Subject: [PATCH 1/3] We need to generate events when finalizing, or we won't
know t
Author: jimingham
Date: 2023-12-07T14:36:27-08:00
New Revision: 9d3aec5535adfdeb10a400e92cecc1cc0a5e26a6
URL:
https://github.com/llvm/llvm-project/commit/9d3aec5535adfdeb10a400e92cecc1cc0a5e26a6
DIFF:
https://github.com/llvm/llvm-project/commit/9d3aec5535adfdeb10a400e92cecc1cc0a5e26a6.diff
LOG
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/74687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74773
>From 9f38564875620a44a982a50492d87ee431baffcd Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 7 Dec 2023 13:41:44 -0800
Subject: [PATCH 1/2] [SymbolFileDWARF][NFC] Remove duplicated c
https://github.com/jasonmolenda approved this pull request.
This looks good to me. Do you think we take the frame variable test in
API/functionalities/location-list-lookup/TestLocationListLookup.py and add it
to your test? They're testing the same thing, and getting there the same way
so I'm
Michael137 wrote:
> This looks good to me. Do you think we take the frame variable test in
> API/functionalities/location-list-lookup/TestLocationListLookup.py and add it
> to your test? They're testing the same thing, and getting there the same way
> so I'm not sure there's value to having th
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/74773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/74772
>From 2352f67789c04f86c8a0f7ad8940d782288750b8 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 7 Dec 2023 21:35:41 +
Subject: [PATCH 1/2] [lldb][Symbol] Make sure we decrement PC before checking
lo
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/74772
>From 2352f67789c04f86c8a0f7ad8940d782288750b8 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 7 Dec 2023 21:35:41 +
Subject: [PATCH 1/3] [lldb][Symbol] Make sure we decrement PC before checking
lo
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/74772
>From 2352f67789c04f86c8a0f7ad8940d782288750b8 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 7 Dec 2023 21:35:41 +
Subject: [PATCH 1/4] [lldb][Symbol] Make sure we decrement PC before checking
lo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
This patch revives the effort to get this Phabricator patch into upstream:
https://reviews.llvm.org/D137900
This patch was accepted before in Phabricator but I found some
-gsimple-template-names issues that
clayborg wrote:
@adrian-prantl This patch is exactly the same as it was back when you accepted
it in Phabricator with two things added:
- fixes for -gsimple-template-names
- updated the new `SBType::FindDirectNestedType(...)`
All tests pass on macOS.
https://github.com/llvm/llvm-project/pull/7
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
42bba97fc24f045f593fc26f998bac9b08633255...5adebf6f6068ef1eb8e5a4dbb02a52d8c21b1b3c
lldb/
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/74788
This commit factors out the logic building each component of a qualified name
into its own function so that it may be reused by a future commit, while also
simplifying the logic of assembling these pieces
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This commit factors out the logic building each component of a qualified name
into its own function so that it may be reused by a future commit, while also
simplifying the logic of assemb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7003e255d3f1fbff3b2ef3052d478b65ec555963
89c88d156170e5c8287d8a8236cfaf3e1ec2d1cf --
https://github.com/JMazurkiewicz updated
https://github.com/llvm/llvm-project/pull/74655
>From b3de573887cdd86fd6ce168bdcc6d729d73b13b2 Mon Sep 17 00:00:00 2001
From: Jakub Mazurkiewicz
Date: Wed, 6 Dec 2023 14:03:51 +0100
Subject: [PATCH 01/11] [libc++] Fix `take_view::__sentinel`'s `operator=
1 - 100 of 115 matches
Mail list logo
