[Lldb-commits] [lldb] 14b5abb - [lldb][AArch64][Linux] Add field information for the fpsr register (#71651)

Author: David Spickett Date: 2023-11-09T08:18:44Z New Revision: 14b5abbfe2071d7ec5eded67f45988e2e484874e URL: https://github.com/llvm/llvm-project/commit/14b5abbfe2071d7ec5eded67f45988e2e484874e DIFF: https://github.com/llvm/llvm-project/commit/14b5abbfe2071d7ec5eded67f45988e2e484874e.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the fpsr register (PR #71651)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/71651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix assert in ScriptedProcess destructor (PR #71744)

DavidSpickett wrote: This did the job, https://lab.llvm.org/buildbot/#/builders/219/builds/6810, thanks. https://github.com/llvm/llvm-project/pull/71744 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add fields for FPCR register (PR #71694)

https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/71694 >From 634ee0ebebdbb5bd3e4d3a7f167a592a0da41a33 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 8 Nov 2023 10:50:07 + Subject: [PATCH] [lldb][AArch64][Linux] Add fields for FPCR register Follow

[Lldb-commits] [lldb] e3d750c - [lldb][AArch64][Linux] Add fields for FPCR register (#71694)

Author: David Spickett Date: 2023-11-09T09:32:24Z New Revision: e3d750cc40e4cea281924142859dd4b9a6465f99 URL: https://github.com/llvm/llvm-project/commit/e3d750cc40e4cea281924142859dd4b9a6465f99 DIFF: https://github.com/llvm/llvm-project/commit/e3d750cc40e4cea281924142859dd4b9a6465f99.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add fields for FPCR register (PR #71694)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/71694 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c51a896 - [lldb][AArch64][Linux] Fix HWCAP constant sizes when built on 32 bit

Author: David Spickett Date: 2023-11-09T10:55:43Z New Revision: c51a8968a410fb7cfc45acc9f86273ff1cb11736 URL: https://github.com/llvm/llvm-project/commit/c51a8968a410fb7cfc45acc9f86273ff1cb11736 DIFF: https://github.com/llvm/llvm-project/commit/c51a8968a410fb7cfc45acc9f86273ff1cb11736.diff LOG

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/71175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

DavidSpickett wrote: Discussion continues on the RFC, I will come back to these asserts with smaller changes tailored to each use. https://github.com/llvm/llvm-project/pull/71175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

luporl wrote: Thanks for the fix. https://github.com/llvm/llvm-project/pull/71465 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available" (PR #71800)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/71800 This patch relands https://github.com/llvm/llvm-project/pull/71004 which was reverted because the clang change it depends on was reverted. In addition to the original patch, this PR includes a change to `Sym

[Lldb-commits] [lldb] Reland "[lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available" (PR #71800)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch relands https://github.com/llvm/llvm-project/pull/71004 which was reverted because the clang change it depends on was reverted. In addition to the original patch, this PR includes a change to `

[Lldb-commits] [lldb] Reland "[lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available" (PR #71800)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/71800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 220abb0 - [lldb][Utility] Fix GCC suggest braces warning for checksum value

Author: David Spickett Date: 2023-11-09T12:38:01Z New Revision: 220abb02cb4684d2856ca1a463a531215ffeafd2 URL: https://github.com/llvm/llvm-project/commit/220abb02cb4684d2856ca1a463a531215ffeafd2 DIFF: https://github.com/llvm/llvm-project/commit/220abb02cb4684d2856ca1a463a531215ffeafd2.diff LOG

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/70779 >From 2ff56f181659a0079c66ce646d50780844ffb080 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 31 Oct 2023 11:15:45 +0100 Subject: [PATCH 1/3] [LLDB] Don't ignore artificial variables and members for corouti

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

@@ -3059,9 +3059,8 @@ void DWARFASTParserClang::ParseSingleMember( // This needs to be done after updating FieldInfo which keeps track of where // field start/end so we don't later try to fill the space of this // artificial member with (unnamed bitfield) padding. - // F

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process) : LanguageRuntime(process) {} bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) { - return name == g_this; + // FIXME: use a list when the list grows more. + return name == g_this

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

@@ -771,6 +771,10 @@ TypeSystemClang *TypeSystemClang::GetASTContext(clang::ASTContext *ast) { return clang_ast; } +bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) { + return Name.starts_with("_vptr$"); hokein wrote: Thanks, good c

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

https://github.com/hokein ready_for_review https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Haojian Wu (hokein) Changes Part of the fixes #69309. Address the FIXME, this will allow the lldb print all fields of the generated coroutine frame structure. --- Full diff: https://github.com/llvm/llvm-project/pull/70779.diff 4 Files A

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

hokein wrote: Thanks for the comment, I updated the patch, this is ready for another round of review. https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

@@ -771,6 +771,10 @@ TypeSystemClang *TypeSystemClang::GetASTContext(clang::ASTContext *ast) { return clang_ast; } +bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) { + return Name.starts_with("_vptr$"); Michael137 wrote: `TypeSyste

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

@@ -771,6 +771,10 @@ TypeSystemClang *TypeSystemClang::GetASTContext(clang::ASTContext *ast) { return clang_ast; } +bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) { + return Name.starts_with("_vptr$"); Michael137 wrote: Are you st

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the mte_ctrl register (PR #71808)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/71808 This is a Linux pseudo register provided by the NT_ARM_TAGGED_ADDR_CTRL register set. It reflects the value passed to prctl PR_SET_TAGGED_ADDR_CTRL. https://docs.kernel.org/arch/arm64/memory-tagging-extens

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the mte_ctrl register (PR #71808)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This is a Linux pseudo register provided by the NT_ARM_TAGGED_ADDR_CTRL register set. It reflects the value passed to prctl PR_SET_TAGGED_ADDR_CTRL. https://docs.kernel.org/arch/arm64/memory-tagging-e

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add register field information for SME's SVCR register (PR #71809)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/71809 This register is a pseudo register but mirrors the architectural register's contents. See: https://developer.arm.com/documentation/ddi0616/latest/ For the full details. Example output: ``` (lldb) register r

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add register field information for SME's SVCR register (PR #71809)

DavidSpickett wrote: First commit is https://github.com/llvm/llvm-project/pull/71808, review the second. https://github.com/llvm/llvm-project/pull/71809 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add register field information for SME's SVCR register (PR #71809)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This register is a pseudo register but mirrors the architectural register's contents. See: https://developer.arm.com/documentation/ddi0616/latest/ For the full details. Example output: ``` (lldb) regis

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

@@ -771,6 +771,10 @@ TypeSystemClang *TypeSystemClang::GetASTContext(clang::ASTContext *ast) { return clang_ast; } +bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) { + return Name.starts_with("_vptr$"); hokein wrote: > TypeSystemCl

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/70779 >From 2ff56f181659a0079c66ce646d50780844ffb080 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 31 Oct 2023 11:15:45 +0100 Subject: [PATCH 1/4] [LLDB] Don't ignore artificial variables and members for corouti

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat added a comment. In D132734#3887018 , @JDevlieghere wrote: > Thanks Will, let me apply this locally and see if that addresses the issue > for which I reverted the original patch. Hy Jonas, sorry for bumping an old thread, but did you manage to ch

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

@@ -0,0 +1,17 @@ +# UNSUPPORTED: system-darwin, system-windows Michael137 wrote: Why unsupported on Darwin? Pretty sure it should just work https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

@@ -0,0 +1,17 @@ +# UNSUPPORTED: system-darwin, system-windows Michael137 wrote: I think we can just remove these and if the test does end up failing we'll just add the requirements back after the fact. https://github.com/llvm/llvm-project/pull/70779 __

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

@@ -0,0 +1,17 @@ +# UNSUPPORTED: system-darwin, system-windows Michael137 wrote: Oh you're using gcc for this. Nvm https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

https://github.com/Michael137 approved this pull request. LGTM Are you still going to make the change to `CommandObjectFrame` such that `frame var` doesn't hide the artificial fields? https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits m

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/71828 lldb's AppleDWARFIndex is created with a few `llvm::AppleAcceleratorTable` variables, but they only hold pointers to the underlying data, which doesn't prevent the data owner (lldb's DataBufferHeap) fro

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes lldb's AppleDWARFIndex is created with a few `llvm::AppleAcceleratorTable` variables, but they only hold pointers to the underlying data, which doesn't prevent the data owner (lldb's DataBufferHe

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5da98de - [lldb] Read Checksum from DWARF line tables (#71458)

Author: Jonas Devlieghere Date: 2023-11-09T08:59:03-08:00 New Revision: 5da98dec7ab8c3adc3f70147ea666428431adf34 URL: https://github.com/llvm/llvm-project/commit/5da98dec7ab8c3adc3f70147ea666428431adf34 DIFF: https://github.com/llvm/llvm-project/commit/5da98dec7ab8c3adc3f70147ea666428431adf34.d

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -184,6 +184,8 @@ class LLDB_API SBTarget { SBProcess LoadCore(const char *core_file); SBProcess LoadCore(const char *core_file, lldb::SBError &error); + SBProcess LoadCore(SBFile &file); bulbazord wrote: +1, please don't add a new API that gives no fe

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -244,9 +245,45 @@ SBProcess SBTarget::LoadCore(const char *core_file, lldb::SBError &error) { TargetSP target_sp(GetSP()); if (target_sp) { FileSpec filespec(core_file); -FileSystem::Instance().Resolve(filespec); +auto file = FileSystem::Instance().Open( +

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -390,12 +389,12 @@ class Process : public std::enable_shared_from_this, ConstString &GetBroadcasterClass() const override { return GetStaticBroadcasterClass(); } - -/// A notification structure that can be used by clients to listen -/// for changes in a process's

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -61,13 +62,15 @@ void ProcessMachCore::Terminate() { lldb::ProcessSP ProcessMachCore::CreateInstance(lldb::TargetSP target_sp, ListenerSP listener_sp, -const FileSpec *crash_file

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -102,10 +102,10 @@ void ProcessKDP::Terminate() { lldb::ProcessSP ProcessKDP::CreateInstance(TargetSP target_sp, ListenerSP listener_sp, - const FileSpec *crash_file_path, +

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -49,17 +50,18 @@ void ProcessElfCore::Terminate() { lldb::ProcessSP ProcessElfCore::CreateInstance(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, - const FileSpec *crash_fi

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -67,30 +67,33 @@ class ProcessFreeBSDKernelKVM : public ProcessFreeBSDKernel { } // namespace ProcessFreeBSDKernel::ProcessFreeBSDKernel(lldb::TargetSP target_sp, - ListenerSP listener_sp) -: PostMortemProcess(target_sp, listen

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -196,9 +196,10 @@ void ProcessGDBRemote::Terminate() { lldb::ProcessSP ProcessGDBRemote::CreateInstance( lldb::TargetSP target_sp, ListenerSP listener_sp, -const FileSpec *crash_file_path, bool can_connect) { + lldb::F

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -24,7 +26,20 @@ class PostMortemProcess : public Process { using Process::Process; public: + PostMortemProcess(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, +lldb::FileSP file_sp) + : Process(target_sp, listener_sp), m_core_file(file_sp

[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

@@ -1469,6 +1468,14 @@ class Process : public std::enable_shared_from_this, virtual bool IsLiveDebugSession() const { return true; }; + + /// Provide a way to retrieve the core dump file that is loaded for debugging. + /// Only available if IsLiveDebugSession() returns

[Lldb-commits] [lldb] [LLDB] Ignore actual-needed artificial members in DWARFASTParserClang::ParseSingleMember (PR #70779)

hokein wrote: Thank you very much for the review! > Are you still going to make the change to CommandObjectFrame such that frame > var doesn't hide the artificial fields? Yes, that's my next step. https://github.com/llvm/llvm-project/pull/70779 ___

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -704,7 +705,37 @@ class Process : public std::enable_shared_from_this, /// is not supported by the plugin, error otherwise. virtual llvm::Expected SaveCore(llvm::StringRef outfile); + struct CoreFileMemoryRange { +llvm::AddressRange range; /// The address rang

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

https://github.com/jasonmolenda approved this pull request. A couple of small nits but looks good to me. I do have a little concern about pulling in `llvm/ADT/AddressRanges.h` in Process.h to get llvm::AddressRange when we have an lldb_private::AddressRange, which is used in a number of places

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/71772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/71843 When this option is enabled, display names of stack frames are generated using the `${function.name-with-args}` formatter instead of simply calling `SBFrame::GetDisplayFunctionName`. This makes lldb-dap

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes When this option is enabled, display names of stack frames are generated using the `${function.name-with-args}` formatter instead of simply calling `SBFrame::GetDisplayFunctionName`. This makes l

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -704,7 +705,37 @@ class Process : public std::enable_shared_from_this, /// is not supported by the plugin, error otherwise. virtual llvm::Expected SaveCore(llvm::StringRef outfile); + struct CoreFileMemoryRange { +llvm::AddressRange range; /// The address rang

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -704,7 +705,37 @@ class Process : public std::enable_shared_from_this, /// is not supported by the plugin, error otherwise. virtual llvm::Expected SaveCore(llvm::StringRef outfile); + struct CoreFileMemoryRange { +llvm::AddressRange range; /// The address rang

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr, size_t len, return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(), *packed_tags); } + +// Create a CoreFileMemoryRange from a MemoryRegionInfo +static Proc

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/71772 >From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 8 Nov 2023 21:14:49 -0800 Subject: [PATCH] Centralize the code that figures out which memory ranges to save

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

clayborg wrote: I addressed most of the feedback. Alex let me know if you still really want llvm::Error and llvm::Expected to be used as I can add that if you think it is required. I also ran clang format. https://github.com/llvm/llvm-project/pull/71772

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

clayborg wrote: @jasonmolenda I was wondering if we should modify `GetCoreFileSaveRangesDirtyOnly(...)` to try and add all dirty pages and see if any regions have the dirty page info, but if no memory region infos have the dirty pages information, then fall back to adding all memory regions wi

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

clayborg wrote: @bulbazord let me know if you require any changes after reading my inline comments. https://github.com/llvm/llvm-project/pull/71772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/71843 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

https://github.com/clayborg requested changes to this pull request. So this hardcodes the frame display to only be the function name, or function name with args. Do we want to allow users to specify a frame format in the lldb-vscode settings? We could have two settings: one to enable the featur

[Lldb-commits] [lldb] [lldb-dap] Add an option to show function args in stack frames (PR #71843)

@@ -1232,6 +1234,32 @@ const char *SBFrame::GetFunctionName() const { return name; } +void SBFrame::GetDisplayFunctionNameWithArgs(SBStream &output) { + Stream &strm = output.ref(); + + std::unique_lock lock; + ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + + Stack

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: taalhaataahir0102 wrote: Hi David! `ninja check-lldb` is failing for us. We've re-compiled the latest llvm project (without adding our implementation) but that one is also giving us the same error: ![image](https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the mte_ctrl register (PR #71808)

https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

dyung wrote: Hi @JDevlieghere, this change seems to be causing 59 test failures in the cross-project-test suite. Can you take a look? https://lab.llvm.org/buildbot/#/builders/217/builds/30979 https://lab.llvm.org/buildbot/#/builders/243/builds/15142 https://github.com/llvm/llvm-project/pull/71

[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

https://github.com/bulbazord commented: The idea of this makes sense to me, but I think you should let @felipepiovezan take a look first. https://github.com/llvm/llvm-project/pull/71828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

JDevlieghere wrote: > Hi @JDevlieghere, this change seems to be causing 59 test failures in the > cross-project-test suite. Can you take a look? > > https://lab.llvm.org/buildbot/#/builders/217/builds/30979 > https://lab.llvm.org/buildbot/#/builders/243/builds/15142 I'll revert the change, bu

[Lldb-commits] [lldb] Revert "[lldb] Read Checksum from DWARF line tables" (PR #71864)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71864 Reverts llvm/llvm-project#71458 as it might have caused cross-project-test failures. >From 5b740aafd3631fbe4bbe56cbe9e206da926a3c06 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 9 Nov 2023 1

[Lldb-commits] [lldb] 73519ba - Revert "[lldb] Read Checksum from DWARF line tables" (#71864)

Author: Jonas Devlieghere Date: 2023-11-09T12:43:53-08:00 New Revision: 73519ba27a29c7e95ec93ed8ce44ff7874851599 URL: https://github.com/llvm/llvm-project/commit/73519ba27a29c7e95ec93ed8ce44ff7874851599 DIFF: https://github.com/llvm/llvm-project/commit/73519ba27a29c7e95ec93ed8ce44ff7874851599.d

[Lldb-commits] [lldb] Revert "[lldb] Read Checksum from DWARF line tables" (PR #71864)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71864 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

JDevlieghere wrote: Reverted in #71864. https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

dyung wrote: > > Hi @JDevlieghere, this change seems to be causing 59 test failures in the > > cross-project-test suite. Can you take a look? > > https://lab.llvm.org/buildbot/#/builders/217/builds/30979 > > https://lab.llvm.org/buildbot/#/builders/243/builds/15142 > > I'll revert the change,

[Lldb-commits] [lldb] Revert "[lldb] Read Checksum from DWARF line tables" (PR #71864)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Reverts llvm/llvm-project#71458 as it might have caused cross-project-test failures. --- Full diff: https://github.com/llvm/llvm-project/pull/71864.diff 1 Files Affected: - (modified) lldb/sourc

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

dyung wrote: > Reverted in #71864. Thanks, they seem to be passing now: https://lab.llvm.org/buildbot/#/builders/243/builds/15146 https://lab.llvm.org/buildbot/#/builders/217/builds/30989 https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commit

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

JDevlieghere wrote: It was also passing before with the change, so the issue isn't fully deterministic: https://lab.llvm.org/buildbot/#/builders/217/builds/30986 https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

bulbazord wrote: > I addressed most of the feedback. Alex let me know if you still really want > llvm::Error and llvm::Expected to be used as I can add that if you think it > is required. I also ran clang format. I think your answers make sense to me. I don't think you need to add them here s

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

dyung wrote: > It was also passing before with the change, so the issue isn't fully > deterministic: https://lab.llvm.org/buildbot/#/builders/217/builds/30986 That was me forcing the build of the commit immediately preceding yours to verify it was passing: `reason A build was forced by '': Bu

[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

jasonmolenda wrote: > @jasonmolenda I was wondering if we should modify > `GetCoreFileSaveRangesDirtyOnly(...)` to try and add all dirty pages and see > if any regions have the dirty page info, but if no memory region infos have > the dirty pages information, then fall back to adding all memor

  1   2   >