Author: David Spickett
Date: 2023-11-08T09:23:02Z
New Revision: d3fb05ba10ca4b46b5bb1b9d90bfcbb019fea1ca
URL:
https://github.com/llvm/llvm-project/commit/d3fb05ba10ca4b46b5bb1b9d90bfcbb019fea1ca
DIFF:
https://github.com/llvm/llvm-project/commit/d3fb05ba10ca4b46b5bb1b9d90bfcbb019fea1ca.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/70935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -62,7 +62,10 @@ struct RegisterInfo {
/// rax ax, ah, and al.
uint32_t *invalidate_regs;
/// If not nullptr, a type defined by XML descriptions.
- const RegisterFlags *flags_type;
+ /// This is mutable so that it may be updated after the register info tables
+ /// h
DavidSpickett wrote:
LGTM, happy to see more bool + parameter -> optional conversions.
https://github.com/llvm/llvm-project/pull/71613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/71613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -62,7 +62,10 @@ struct RegisterInfo {
/// rax ax, ah, and al.
uint32_t *invalidate_regs;
/// If not nullptr, a type defined by XML descriptions.
- const RegisterFlags *flags_type;
+ /// This is mutable so that it may be updated after the register info tables
+ /// h
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/70300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/70300
>From 45a9d131ce6c9fb31355519cd810ceff32c05ee7 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 11 Oct 2023 14:54:07 +0100
Subject: [PATCH 1/9] [lldb][AArch64][Linux] Add field information for the C
Author: David Spickett
Date: 2023-11-08T10:17:38Z
New Revision: e28157e778423fd9d39c9065ef06e841fc320f09
URL:
https://github.com/llvm/llvm-project/commit/e28157e778423fd9d39c9065ef06e841fc320f09
DIFF:
https://github.com/llvm/llvm-project/commit/e28157e778423fd9d39c9065ef06e841fc320f09.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/70300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/71651
This one is easy because none of the fields depend on extensions. Only thing to
note is that I've ignored some AArch32 only fields.
```
(lldb) register read fpsr
fpsr = 0x
= (QC = 0, I
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This one is easy because none of the fields depend on extensions. Only thing to
note is that I've ignored some AArch32 only fields.
```
(lldb) register read fpsr
fpsr = 0x
= (QC =
DavidSpickett wrote:
It may be worth adding a fast path for "constant" information, but I would like
to look into that after the initial set of 5 registers is in.
https://github.com/llvm/llvm-project/pull/71651
___
lldb-commits mailing list
lldb-commi
https://github.com/markoshorro closed
https://github.com/llvm/llvm-project/pull/71072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/71086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/huntergr-arm updated
https://github.com/llvm/llvm-project/pull/71528
>From 754519ad9b37343c827504e7d6bfcfa590f69483 Mon Sep 17 00:00:00 2001
From: Graham Hunter
Date: Fri, 3 Nov 2023 14:22:57 +
Subject: [PATCH] [InstCombine] Fold converted urem to 0 if there's no
overlap
DavidSpickett wrote:
New test is failing on Windows on Arm:
https://lab.llvm.org/buildbot/#/builders/219/builds/6799/steps/6/logs/stdio
The build in general was red when this initially went in, so no notification
went out.
https://github.com/llvm/llvm-project/pull/71260
__
Author: David Spickett
Date: 2023-11-08T15:23:03Z
New Revision: ea82853499cc8780cfc86a6913d851f05d527188
URL:
https://github.com/llvm/llvm-project/commit/ea82853499cc8780cfc86a6913d851f05d527188
DIFF:
https://github.com/llvm/llvm-project/commit/ea82853499cc8780cfc86a6913d851f05d527188.diff
LOG
DavidSpickett wrote:
Skipped:
https://github.com/llvm/llvm-project/commit/ea82853499cc8780cfc86a6913d851f05d527188
I'm not 100% on what the difference between an so and a dylib is but it works
on Linux as well, so I assume that a Windows test would need to build a dll to
do the same thing.
h
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/71694
Follows the format laid out in the Arm manual, AArch32 only fields are ignored.
```
(lldb) register read fpcr
fpcr = 0x
= (AHP = 0, DN = 0, FZ = 0, RMMode = 0, FZ16 = 0, IDE = 0, IXE =
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Follows the format laid out in the Arm manual, AArch32 only fields are ignored.
```
(lldb) register read fpcr
fpcr = 0x
= (AHP = 0, DN = 0, FZ = 0, RMMode = 0, FZ16 = 0, IDE = 0, I
DavidSpickett wrote:
First commit is actually https://github.com/llvm/llvm-project/pull/71651, so
look at the second one only.
https://github.com/llvm/llvm-project/pull/71694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/70505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Looks straightforward to me.
https://github.com/llvm/llvm-project/pull/71651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
This also looks pretty straightforward after you implemented the initial
support. :)
https://github.com/llvm/llvm-project/pull/71694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
luporl wrote:
It seems this broke the lldb-aarch64-windows buildbot:
https://lab.llvm.org/buildbot/#/builders/219/builds/6801
https://github.com/llvm/llvm-project/pull/71465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
medismailben wrote:
> It seems this broke the lldb-aarch64-windows buildbot:
> https://lab.llvm.org/buildbot/#/builders/219/builds/6801
No, this didn't break that bot, `Expr/TestIRMemoryMapWindows.test` was already
failing in https://lab.llvm.org/buildbot/#/builders/219/builds/6786
https://gi
Author: Adrian Prantl
Date: 2023-11-08T09:54:41-08:00
New Revision: 767ce07c2d4c312188623441979d620b9708ee99
URL:
https://github.com/llvm/llvm-project/commit/767ce07c2d4c312188623441979d620b9708ee99
DIFF:
https://github.com/llvm/llvm-project/commit/767ce07c2d4c312188623441979d620b9708ee99.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/71559
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
@DavidSpickett Thanks for fixing the windows bot :)
https://github.com/llvm/llvm-project/pull/71260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/71456
>From 5693686d3570784fbcadb9921532faf354e5b74f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 6 Nov 2023 14:39:26 -0800
Subject: [PATCH] [lldb] Add Checksum class to lldbUtility
This commit add
@@ -0,0 +1,46 @@
+//===-- Checksum.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Jonas Devlieghere
Date: 2023-11-08T10:11:58-08:00
New Revision: 7ef7a92ead3dd4c3b5cd10b6cf5775a603654945
URL:
https://github.com/llvm/llvm-project/commit/7ef7a92ead3dd4c3b5cd10b6cf5775a603654945
DIFF:
https://github.com/llvm/llvm-project/commit/7ef7a92ead3dd4c3b5cd10b6cf5775a603654945.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
luporl wrote:
@medismailben Yes, it did break that bot.
https://lab.llvm.org/buildbot/#/builders/219/builds/6786 is the first build
that includes your commit and when `Expr/TestIRMemoryMapWindows.test` started
failing.
https://lab.llvm.org/buildbot/#/builders/219/builds/6785 is a build failure
medismailben wrote:
> @medismailben Yes, it did break that bot.
> https://lab.llvm.org/buildbot/#/builders/219/builds/6786 is the first build
> that includes your commit and when `Expr/TestIRMemoryMapWindows.test` started
> failing. https://lab.llvm.org/buildbot/#/builders/219/builds/6785 is a
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/71723
Currently VSCode logpoint uses `SBValue::GetValue` to get the value for
printing. This is not providing an intuitive result for std::string or char *
-- it shows the pointer value instead of the string cont
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5aa934e2af8727852dec0ec1cfa0cba05d858f70
e92d7125be6b6677d0553967bb3f8e821de3ea18 --
@@ -295,9 +295,11 @@ bool BreakpointBase::BreakpointHitCallback(
frame.GetValueForVariablePath(expr, lldb::eDynamicDontRunTarget);
if (value.GetError().Fail())
value = frame.EvaluateExpression(expr);
- const char *expr_val = value.GetValue();
-
@@ -295,9 +295,11 @@ bool BreakpointBase::BreakpointHitCallback(
frame.GetValueForVariablePath(expr, lldb::eDynamicDontRunTarget);
if (value.GetError().Fail())
value = frame.EvaluateExpression(expr);
- const char *expr_val = value.GetValue();
-
https://github.com/jasonmolenda approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/71694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
Looks good.
https://github.com/llvm/llvm-project/pull/71651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/71723
>From e92d7125be6b6677d0553967bb3f8e821de3ea18 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Tue, 7 Nov 2023 16:57:23 -0800
Subject: [PATCH 1/2] Improve DAP logpoint value summary
---
.../API/tools/lld
https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/71723
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
Currently VSCode logpoint uses `SBValue::GetValue` to get the value for
printing. This is not providing an intuitive result for std::string or char *
-- it shows the pointer value instead of the string content.
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
5aa934e2af8727852dec0ec1cfa0cba05d858f70..9664c6f13accbab2616e891ac031701566fd58b4
lldb/t
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/71723
>From e92d7125be6b6677d0553967bb3f8e821de3ea18 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Tue, 7 Nov 2023 16:57:23 -0800
Subject: [PATCH 1/3] Improve DAP logpoint value summary
---
.../API/tools/lld
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/71723
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,7 +48,9 @@ def test_logmessage_basic(self):
# 1. First at the loop line with logMessage
# 2. Second guard breakpoint at a line after loop
logMessage_prefix = "This is log message for { -- "
-logMessage = logMessage_prefix + "{i + 3}"
+
@@ -210,8 +210,7 @@ static std::optional
TryCreateAutoSummary(lldb::SBValue value) {
return TryCreateAutoSummaryForContainer(value);
}
-void SetValueForKey(lldb::SBValue &v, llvm::json::Object &object,
-llvm::StringRef key) {
+std::string ValeuToString(l
@@ -295,9 +296,7 @@ bool BreakpointBase::BreakpointHitCallback(
frame.GetValueForVariablePath(expr, lldb::eDynamicDontRunTarget);
if (value.GetError().Fail())
value = frame.EvaluateExpression(expr);
- const char *expr_val = value.GetValue();
-
https://github.com/bulbazord requested changes to this pull request.
Looks fine, but the method you added has a typo in its name.
https://github.com/llvm/llvm-project/pull/71723
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/71744
This patch should fix a test failure in `Expr/TestIRMemoryMapWindows.test`:
https://lab.llvm.org/buildbot/#/builders/219/builds/6786
The problem here is that since 7991412 landed, all the
`ScriptInterprete
medismailben wrote:
@luporl I found the issue. #71744 should fix it.
https://github.com/llvm/llvm-project/pull/71465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch should fix a test failure in `Expr/TestIRMemoryMapWindows.test`:
https://lab.llvm.org/buildbot/#/builders/219/builds/6786
The problem here is that since 7991412 landed, all the
`ScriptI
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/71723
>From e92d7125be6b6677d0553967bb3f8e821de3ea18 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Tue, 7 Nov 2023 16:57:23 -0800
Subject: [PATCH 1/4] Improve DAP logpoint value summary
---
.../API/tools/lld
Michael137 wrote:
> This causes Clang to assert:
>
> ```
> llvm/lib/IR/Metadata.cpp:689:
> void llvm::MDNode::resolve(): Assertion `isUniqued() && "Expected this
> to be uniqued"' failed.
> ```
>
> See https://bugs.chromium.org/p/chromium/issues/detail?id=1500262#c1 for a
> reprod
https://github.com/bulbazord approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/71723
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -48,7 +48,9 @@ def test_logmessage_basic(self):
# 1. First at the loop line with logMessage
# 2. Second guard breakpoint at a line after loop
logMessage_prefix = "This is log message for { -- "
-logMessage = logMessage_prefix + "{i + 3}"
+
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/71723
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -420,13 +428,17 @@ class FileSpec {
/// The lifetime of the StringRefs is tied to the lifetime of the FileSpec.
std::vector GetComponents() const;
+ /// Return the checksum for this FileSpec or all zeros if there is none.
+ const Checksum &GetChecksum() const { retu
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/71744
>From a26236eec419adc99c188f9fe3d0440f81aff0da Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 8 Nov 2023 16:24:57 -0800
Subject: [PATCH] [lldb] Fix assert in ScriptedProcess destructor
This pa
Author: jeffreytan81
Date: 2023-11-08T16:48:55-08:00
New Revision: f175b9647ccdfd67300264b2d3bd76e6f9a3fb93
URL:
https://github.com/llvm/llvm-project/commit/f175b9647ccdfd67300264b2d3bd76e6f9a3fb93
DIFF:
https://github.com/llvm/llvm-project/commit/f175b9647ccdfd67300264b2d3bd76e6f9a3fb93.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/71723
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/71457
>From 0a4b349d6299db6b2a0a6709c40d15b1a4a0f62a Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 8 Nov 2023 16:51:53 -0800
Subject: [PATCH] [lldb] Add Checksum to FileSpec
Store a Checksum in File
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/71744
>From a0617d18d1cbcf0ca21ca01b350a22930414991f Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 8 Nov 2023 17:01:07 -0800
Subject: [PATCH] [lldb] Fix assert in ScriptedProcess destructor
This pa
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/71744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
🚢
https://github.com/llvm/llvm-project/pull/71744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2023-11-08T17:18:40-08:00
New Revision: 0adbde65414af263175fcce6f9aaf51bc8849a9f
URL:
https://github.com/llvm/llvm-project/commit/0adbde65414af263175fcce6f9aaf51bc8849a9f
DIFF:
https://github.com/llvm/llvm-project/commit/0adbde65414af263175fcce6f9aaf51bc8849a9f.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/71744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2023-11-08T20:11:48-08:00
New Revision: 919f5ef4621edcfd9e9793e1363df53eef3e89d5
URL:
https://github.com/llvm/llvm-project/commit/919f5ef4621edcfd9e9793e1363df53eef3e89d5
DIFF:
https://github.com/llvm/llvm-project/commit/919f5ef4621edcfd9e9793e1363df53eef3e89d5.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/71769
Add a new API in SBTarget to Load Core from a SBFile.
This will enable a target to load core from a file descriptor.
So that in coredumper, we don't need to write core file to disk, instead we can
pass the i
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
Add a new API in SBTarget to Load Core from a SBFile.
This will enable a target to load core from a file descriptor.
So that in coredumper, we don't need to write core file to disk, instead we can
pass the input
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/71458
>From 5673248f1f19145cbbb0435177b6a5ed425fa1c0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 24 Oct 2023 16:14:27 -0700
Subject: [PATCH] [lldb] Read Checksum from DWARF line tables
Read the MD
@@ -184,6 +184,8 @@ class LLDB_API SBTarget {
SBProcess LoadCore(const char *core_file);
SBProcess LoadCore(const char *core_file, lldb::SBError &error);
+ SBProcess LoadCore(SBFile &file);
JDevlieghere wrote:
Did you add this for consistency? I don't th
@@ -24,7 +26,20 @@ class PostMortemProcess : public Process {
using Process::Process;
public:
+ PostMortemProcess(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp,
+lldb::FileSP file_sp)
+ : Process(target_sp, listener_sp), m_core_file(file_sp
@@ -354,12 +355,10 @@ class Process : public
std::enable_shared_from_this,
};
// This is all the event bits the public process broadcaster broadcasts.
// The process shadow listener signs up for all these bits...
- static constexpr int g_all_event_bits = eBroadcastBitSt
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/71772
Prior to this patch, each core file plugin (ObjectFileMachO.cpp and
ObjectFileMinindump.cpp) would calculate the address ranges to save in
different ways. This patch adds a new function to Process.h/.cpp:
```
@@ -2104,9 +2113,10 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
-"Interrupted in dump sym
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
Prior to this patch, each core file plugin (ObjectFileMachO.cpp and
ObjectFileMinindump.cpp) would calculate the address ranges to save in
different ways. This patch adds a new function to Process.h/.cpp:
`
https://github.com/JDevlieghere requested changes to this pull request.
I left some comments inline.
https://github.com/llvm/llvm-project/pull/71769
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -443,6 +455,9 @@ class FileSpec {
/// The unique'd filename path.
ConstString m_filename;
+ /// The optional MD5 checksum of the file.
+ Checksum m_checksum;
+
JDevlieghere wrote:
To close the loop on this for others, Greg measured the impact of the
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
21861991e760e7e845dc1be5b804c950543d699a..e7fb5814d7ef7ad28543978567db9f8305630f90
lldb/t
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21861991e760e7e845dc1be5b804c950543d699a
e7fb5814d7ef7ad28543978567db9f8305630f90 --
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21861991e760e7e845dc1be5b804c950543d699a
9ff1e92175f90613de6f07dfb4821b8fc0226939 --
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/71780
This patch relands https://github.com/llvm/llvm-project/pull/70639
It was reverted because under certain conditions we triggered an assertion
in `DIBuilder`. Specifically, in the original patch we called
`Emi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Buch (Michael137)
Changes
This patch relands https://github.com/llvm/llvm-project/pull/70639
It was reverted because under certain conditions we triggered an assertion
in `DIBuilder`. Specifically, in the original patch we called
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/2] Reland "[clang][DebugInfo] Emit global variable
definitions
89 matches
Mail list logo
