github-actions[bot] wrote: <!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning: <details> <summary> You can test this locally with the following command: </summary> ``````````bash git-clang-format --diff 21861991e760e7e845dc1be5b804c950543d699a e7fb5814d7ef7ad28543978567db9f8305630f90 -- lldb/include/lldb/API/SBTarget.h lldb/include/lldb/Target/PostMortemProcess.h lldb/include/lldb/Target/Process.h lldb/include/lldb/Target/ProcessTrace.h lldb/include/lldb/Target/Target.h lldb/include/lldb/lldb-private-interfaces.h lldb/source/API/SBTarget.cpp lldb/source/Commands/CommandObjectTarget.cpp lldb/source/Core/IOHandlerCursesGUI.cpp lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.h lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp lldb/source/Plugins/Process/elf-core/ProcessElfCore.h lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp lldb/source/Plugins/Process/mach-core/ProcessMachCore.h lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp lldb/source/Plugins/Process/minidump/ProcessMinidump.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process/scripted/ScriptedProcess.h lldb/source/Target/Process.cpp lldb/source/Target/ProcessTrace.cpp lldb/source/Target/Target.cpp lldb/unittests/Target/LocateModuleCallbackTest.cpp `````````` </details> <details> <summary> View the diff from clang-format here. </summary> ``````````diff diff --git a/lldb/include/lldb/Target/Process.h b/lldb/include/lldb/Target/Process.h index 62284b29886a..9950f3a4519a 100644 --- a/lldb/include/lldb/Target/Process.h +++ b/lldb/include/lldb/Target/Process.h @@ -1468,7 +1468,6 @@ public: virtual bool IsLiveDebugSession() const { return true; }; - /// Provide a way to retrieve the core dump file that is loaded for debugging. /// Only available if IsLiveDebugSession() returns true. /// diff --git a/lldb/include/lldb/Target/ProcessTrace.h b/lldb/include/lldb/Target/ProcessTrace.h index ee684a97a5be..de535243744a 100644 --- a/lldb/include/lldb/Target/ProcessTrace.h +++ b/lldb/include/lldb/Target/ProcessTrace.h @@ -27,7 +27,8 @@ public: static llvm::StringRef GetPluginDescriptionStatic(); - ProcessTrace(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, lldb::FileSP core_file_sp); + ProcessTrace(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, + lldb::FileSP core_file_sp); ~ProcessTrace() override; diff --git a/lldb/include/lldb/lldb-private-interfaces.h b/lldb/include/lldb/lldb-private-interfaces.h index 21fd34faee80..55f2c794c274 100644 --- a/lldb/include/lldb/lldb-private-interfaces.h +++ b/lldb/include/lldb/lldb-private-interfaces.h @@ -77,8 +77,8 @@ typedef Status (*StructuredDataFilterLaunchInfo)(ProcessLaunchInfo &launch_info, typedef SystemRuntime *(*SystemRuntimeCreateInstance)(Process *process); typedef lldb::PlatformSP (*PlatformCreateInstance)(bool force, const ArchSpec *arch); -typedef lldb::ProcessSP (*ProcessCreateInstance)( - lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, +typedef lldb::ProcessSP (*ProcessCreateInstance)(lldb::TargetSP target_sp, + lldb::ListenerSP listener_sp, lldb::FileSP crash_file_sp, bool can_connect); typedef lldb::RegisterTypeBuilderSP (*RegisterTypeBuilderCreateInstance)( diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index f86effdd2ecc..a44e208df0a9 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -2085,7 +2085,8 @@ protected: } if (INTERRUPT_REQUESTED(GetDebugger(), "Interrupted in dump all symtabs with {0} " - "of {1} dumped.", num_dumped, num_modules)) + "of {1} dumped.", + num_dumped, num_modules)) break; num_dumped++; diff --git a/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp b/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp index c0c6cd8a9b2e..8e256e0c782b 100644 --- a/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp +++ b/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.cpp @@ -84,8 +84,8 @@ lldb::ProcessSP ProcessFreeBSDKernel::CreateInstance(lldb::TargetSP target_sp, fvc_open(executable->GetFileSpec().GetPath().c_str(), file_spec->GetPath().c_str(), nullptr, nullptr, nullptr); if (fvc) - return std::make_shared<ProcessFreeBSDKernelFVC>(target_sp, listener_sp, crash_file_sp - fvc); + return std::make_shared<ProcessFreeBSDKernelFVC>(target_sp, listener_sp, + crash_file_sp fvc); #endif #if defined(__FreeBSD__) @@ -93,8 +93,8 @@ lldb::ProcessSP ProcessFreeBSDKernel::CreateInstance(lldb::TargetSP target_sp, kvm_open2(executable->GetFileSpec().GetPath().c_str(), file_spec->GetPath().c_str(), O_RDONLY, nullptr, nullptr); if (kvm) - return std::make_shared<ProcessFreeBSDKernelKVM>(target_sp, listener_sp, crash_file_sp - kvm); + return std::make_shared<ProcessFreeBSDKernelKVM>(target_sp, listener_sp, + crash_file_sp kvm); #endif } return nullptr; diff --git a/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.h b/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.h index 797af87927db..5f528676bec7 100644 --- a/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.h +++ b/lldb/source/Plugins/Process/FreeBSDKernel/ProcessFreeBSDKernel.h @@ -15,10 +15,10 @@ class ProcessFreeBSDKernel : public lldb_private::PostMortemProcess { public: ProcessFreeBSDKernel(lldb::TargetSP target_sp, lldb::ListenerSP listener); - static lldb::ProcessSP - CreateInstance(lldb::TargetSP target_sp, lldb::ListenerSP listener, - lldb::FileSP crash_file_sp, - bool can_connect); + static lldb::ProcessSP CreateInstance(lldb::TargetSP target_sp, + lldb::ListenerSP listener, + lldb::FileSP crash_file_sp, + bool can_connect); static void Initialize(); diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h index 8b1a21c26da7..5b20fae6a689 100644 --- a/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h +++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h @@ -31,8 +31,8 @@ class ThreadKDP; class ProcessKDP : public lldb_private::Process { public: // Constructors and Destructors - static lldb::ProcessSP - CreateInstance(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, + static lldb::ProcessSP CreateInstance(lldb::TargetSP target_sp, + lldb::ListenerSP listener_sp, lldb::FileSP crash_file_sp, bool can_connect); diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp index bfa027fe3b80..f48f3633f517 100644 --- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp +++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp @@ -263,8 +263,8 @@ Status ProcessElfCore::DoLoadCore() { exe_module_spec.GetFileSpec().SetFile(m_nt_file_entries[0].path, FileSpec::Style::native); if (exe_module_spec.GetFileSpec()) { - exe_module_sp = GetTarget().GetOrCreateModule(exe_module_spec, - true /* notify */); + exe_module_sp = + GetTarget().GetOrCreateModule(exe_module_spec, true /* notify */); if (exe_module_sp) GetTarget().SetExecutableModule(exe_module_sp, eLoadDependentsNo); } diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h index 5420f818e868..f005f0423f42 100644 --- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h +++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.h @@ -31,8 +31,8 @@ struct ThreadData; class ProcessElfCore : public lldb_private::PostMortemProcess { public: // Constructors and Destructors - static lldb::ProcessSP - CreateInstance(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp, + static lldb::ProcessSP CreateInstance(lldb::TargetSP target_sp, + lldb::ListenerSP listener_sp, lldb::FileSP crash_file_sp, bool can_connect); diff --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp index 6c43cd18cd47..d91cf53f4740 100644 --- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp @@ -194,8 +194,8 @@ void ProcessGDBRemote::Terminate() { PluginManager::UnregisterPlugin(ProcessGDBRemote::CreateInstance); } -lldb::ProcessSP ProcessGDBRemote::CreateInstance( - lldb::TargetSP target_sp, ListenerSP listener_sp, +lldb::ProcessSP ProcessGDBRemote::CreateInstance(lldb::TargetSP target_sp, + ListenerSP listener_sp, lldb::FileSP crash_file_sp, bool can_connect) { lldb::ProcessSP process_sp; diff --git a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.h b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.h index bab3ed86ad8e..15d8a30eb2f5 100644 --- a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.h +++ b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.h @@ -26,8 +26,8 @@ public: ~ProcessMachCore() override; - static lldb::ProcessSP - CreateInstance(lldb::TargetSP target_sp, lldb::ListenerSP listener, + static lldb::ProcessSP CreateInstance(lldb::TargetSP target_sp, + lldb::ListenerSP listener, lldb::FileSP core_file_sp, bool can_connect); diff --git a/lldb/source/Target/ProcessTrace.cpp b/lldb/source/Target/ProcessTrace.cpp index 4e65e191b914..4ca76f84612d 100644 --- a/lldb/source/Target/ProcessTrace.cpp +++ b/lldb/source/Target/ProcessTrace.cpp @@ -31,8 +31,7 @@ void ProcessTrace::Terminate() { ProcessSP ProcessTrace::CreateInstance(TargetSP target_sp, ListenerSP listener_sp, - FileSP core_file_sp, - bool can_connect) { + FileSP core_file_sp, bool can_connect) { if (can_connect) return nullptr; return std::make_shared<ProcessTrace>(target_sp, listener_sp, core_file_sp); @@ -42,7 +41,8 @@ bool ProcessTrace::CanDebug(TargetSP target_sp, bool plugin_specified_by_name) { return plugin_specified_by_name; } -ProcessTrace::ProcessTrace(TargetSP target_sp, ListenerSP listener_sp, FileSP core_file_sp) +ProcessTrace::ProcessTrace(TargetSP target_sp, ListenerSP listener_sp, + FileSP core_file_sp) : PostMortemProcess(target_sp, listener_sp, core_file_sp) {} ProcessTrace::~ProcessTrace() { `````````` </details> https://github.com/llvm/llvm-project/pull/71769 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits