[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

omjavaid added a comment. In D157846#4644241 , @DavidSpickett wrote: >> In this test can we figure out whether SVE was read from Streaming mode or >> normal SVE mode?? and if yes may be add a check for that. > > Not sure what you mean. > > If you mean:

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

omjavaid added a comment. This looks good overall thanks for doing the patch split makes the review way less overwhelming. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:342 + // header itself. + m_za_ptrace_payload.resize(((m_za_

Re: [Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

> I would never never write Python code that ugly. As usual with formatting the conclusions were as long as the same strange decisions are made consistently, it's worth doing. Discussion: https://discourse.llvm.org/t/python-code-style-and-reformatting-status-update/70641/13 Overall project docs:

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

DavidSpickett added a comment. > I was actually curious if LLDB user can distinguish whether we are reading > SVE registers from streaming mode or normal SVE mode. But yes only config > registers like vg can tell that registers are read in non-SVE(FPSIMD), normal > SVE, or streaming modes. Rig

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH] [AArch64][SME]Update intrinsic interface for ld1/st1

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:342 + // header itself. + m_za_ptrace_payload.resize(((m_za_header.vl) * (m_za_header.vl)) + + GetZAHeaderSize()); --

[Lldb-commits] [lldb] 11de4c7 - [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets

Author: David Spickett Date: 2023-09-13T10:07:36+01:00 New Revision: 11de4c724c8e875f75c2d1c733c38051bc818601 URL: https://github.com/llvm/llvm-project/commit/11de4c724c8e875f75c2d1c733c38051bc818601 DIFF: https://github.com/llvm/llvm-project/commit/11de4c724c8e875f75c2d1c733c38051bc818601.diff

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets

This revision was automatically updated to reflect the committed changes. Closed by commit rG11de4c724c8e: [lldb][AArch64] Add tests for SME's SVE register state to… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/ne

[Lldb-commits] [lldb] 461f859 - [lldb] Treat user aliases the same as built-ins when tab completing (#65974)

Author: David Spickett Date: 2023-09-13T10:12:12+01:00 New Revision: 461f859a722fb80103d437005bb14deb215f8260 URL: https://github.com/llvm/llvm-project/commit/461f859a722fb80103d437005bb14deb215f8260 DIFF: https://github.com/llvm/llvm-project/commit/461f859a722fb80103d437005bb14deb215f8260.diff

[Lldb-commits] [lldb] [lldb] Treat user aliases the same as built-ins when tab completing (PR #65974)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/65974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f8b2544 - [lldb] Link to LLVM code style in LLDB's contributing page

Author: David Spickett Date: 2023-09-13T10:48:48+01:00 New Revision: f8b2544c422404b0c8d1225d9240301f50de1cdb URL: https://github.com/llvm/llvm-project/commit/f8b2544c422404b0c8d1225d9240301f50de1cdb DIFF: https://github.com/llvm/llvm-project/commit/f8b2544c422404b0c8d1225d9240301f50de1cdb.diff

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); - svl

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm approved this pull request. LGTM with nit addressed! https://github.com/llvm/llvm-project/pull/65582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/65582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

omjavaid added a comment. Why do we have svg and za in different register sets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h:42 void UpdateARM64SVERegistersInfos(uint64_t vg); + void UpdateARM64SMERegistersInfos(uint64_t vg); }; svg Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. Made sense at the time with it being it's own regset in ptrace. Current state is: Scalable Matrix Array Storage Registers: za = {<...>} Scalable Matrix Extension Registers: svg = 0x0004 svcr = 0x0003 But I

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

martinboehme wrote: > This check has issue in my opinion, the semantic of `std::move(*p)` is not > same as `*std::move(p)` Agree that the suggested fix may not always be correct. I would suggest simply not emitting a suggested fix (i.e. only emitting a warning). https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

https://github.com/martinboehme requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

@@ -0,0 +1,119 @@ +// RUN: %check_clang_tidy %s performance-move-smart-pointer-contents %t -- \ +// RUN: -config="{CheckOptions: \ +// RUN: {performance-move-smart-pointer-contents.UniquePointerClasses: \ +// RUN: 'std::unique_ptr; my::OtherUniquePtr;',\ +/

[Lldb-commits] [lldb] [clang-tidy] Add performance-move-smart-pointer-contents check. (PR #66139)

PiotrZSL wrote: Other common example from me: ``` struct SomeHeavyClass {}; std::unique_ptr build(); void sendMsg() { auto msgContent = build(); Message msg; msg.content = std::move(*msgContent); send(msg); } ``` And next one: ``` struct Info { virtual const std::string& get

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/65582: >From ae2f1bee2d912895cecb002c2434ef11da7ba3a7 Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Wed, 6 Sep 2023 14:16:17 + Subject: [PATCH 1/3] [AArch64][SME]Update intrinsic interface for ld1

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

@@ -84,8 +76,8 @@ ARM_STREAMING_ATTR void test_svld1_hor_za64(uint32_t slice_base, svbool_t pg, co // ARM_STREAMING_ATTR void test_svld1_hor_za128(uint32_t slice_base, svbool_t pg, const void *ptr) { uint32_t slice = slice_base; - svld1_hor_za128(0, slice, pg, ptr); - svl

[Lldb-commits] [lldb] [AArch64][SME]Update intrinsic interface for ld1/st1 (PR #65582)

https://github.com/CarolineConcatto resolved https://github.com/llvm/llvm-project/pull/65582 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/66218: Users often want to change the look of their prompt and currently the only way to do that is by using ANSI escape codes in the prompt itself. This is not only tedious, it also results in extra whitespace b

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

https://github.com/JDevlieghere review_requested https://github.com/llvm/llvm-project/pull/66218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

llvmbot wrote: @llvm/pr-subscribers-lldb Changes Users often want to change the look of their prompt and currently the only way to do that is by using ANSI escape codes in the prompt itself. This is not only tedious, it also results in extra whitespace because our Editline wrap

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

JDevlieghere wrote: Regarding the column width bug: it's something we'd want to fix anyway. I have a naive implementation [here](https://github.com/JDevlieghere/llvm-project/commit/17e7844547e8b8509014bc953545c76f3fd6eb25). Probably more important than the ANSI escape characters is UTF-8 which

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 556670. DavidSpickett added a comment. Put ZA in the SME register set instead. Once other patches are applied you end up with: Scalable Matrix Extension Registers: svcr = 0x svg = 0x0004 za = {0x

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 556671. DavidSpickett added a comment. Adjust now that ZA is in the SME set. Putting SVG first for readability and ease of resizing ZA later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ http

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 556672. DavidSpickett added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegister

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556673. DavidSpickett added a comment. Update tests now that ZA is part of SME register set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556674. DavidSpickett added a comment. ZA is now part of the SME set so SVCR is stuck in before SVG. SVCR SVG ZA Updated the various indexes to reflect that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556675. DavidSpickett added a comment. Rebase, adjust to handling ZA as part of the SME register set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: l

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 556676. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst l

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 556677. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. > Why do we have svg and za in different register sets? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 ___ lldb-commits m

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett added a comment. Scalable Matrix Extension Registers: svcr = 0x svg = 0x0004 za = {0x00 <...>} Is the layout now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ http

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 556678. DavidSpickett added a comment. Reformat changes with black. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files: lldb/test/API/commands/register/re

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 556679. DavidSpickett added a comment. Format with black. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugins/Process/Linux/NativeRegis

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 556680. DavidSpickett added a comment. Format with black. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files: lldb/source/Plugins/Process/Utility/RegisterC

[Lldb-commits] [lldb] b6f66c9 - [lldb][AArch64] Reformat register set test with black

Author: David Spickett Date: 2023-09-13T15:52:24Z New Revision: b6f66c94bce7d9c0ef029d133b85925ba23198b4 URL: https://github.com/llvm/llvm-project/commit/b6f66c94bce7d9c0ef029d133b85925ba23198b4 DIFF: https://github.com/llvm/llvm-project/commit/b6f66c94bce7d9c0ef029d133b85925ba23198b4.diff LOG

[Lldb-commits] [lldb] remove common libc tuners (PR #66136)

https://github.com/sivachandra updated https://github.com/llvm/llvm-project/pull/66136: >From d1a9fda20a2be37385b44dcbf2f73b1890fa7d78 Mon Sep 17 00:00:00 2001 From: Siva Chandra Reddy Date: Tue, 12 Sep 2023 05:42:37 + Subject: [PATCH 1/3] [libc][NFC] Make entrypoint alias targets real libr

[Lldb-commits] [lldb] remove common libc tuners (PR #66136)

https://github.com/sivachandra closed https://github.com/llvm/llvm-project/pull/66136 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4d10b95 - [lldb] Fix formatting and whitespace in Debugger.{h, cpp} (NFC)

Author: Jonas Devlieghere Date: 2023-09-13T09:14:54-07:00 New Revision: 4d10b9507dcf0dfe073b8642c5ade1d906e654ee URL: https://github.com/llvm/llvm-project/commit/4d10b9507dcf0dfe073b8642c5ade1d906e654ee DIFF: https://github.com/llvm/llvm-project/commit/4d10b9507dcf0dfe073b8642c5ade1d906e654ee.d

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

https://github.com/clayborg commented: Any interest in just allowing "settings set prompt" to use the format strings approach that we support in thread-format, frame-format? I see we have a ton of settings that already ansi-prefix and ansi-suffix settings, but it would be easy to just do: ```

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

clayborg wrote: > This seems like a much wider ranging change than is required to fix this bug. > I'm all for rethinking the > ExecutionContextScope/ExecutionContext/ExecutionContextRef nexus, but I don't > think that's a trivial rethink, and I don't have the time to undertake that > right no

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

clayborg added a comment. In D157609#4644194 , @DavidSpickett wrote: >> Any chance we could simplify this situation and have dwo searches use >> exactly the same/shared logic as source file searches? > > I'm not sure what exactly this means, can you cla

[Lldb-commits] [lldb] [lldb][Commands] Show symbol change bit in SB API (PR #66144)

@@ -83,7 +83,7 @@ class Debugger : public std::enable_shared_from_this, eBroadcastBitProgress = (1 << 0), eBroadcastBitWarning = (1 << 1), eBroadcastBitError = (1 << 2), -eBroadcastSymbolChange = (1 << 3), +eBroadcastBitSymbolChange = (1 << 3),

Re: [Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

We actually have several requests for this internally, and I think that's a good idea. However, some of the format tokens can return arbitrary text, including newlines, for instance "thread.completed-expression", and all the "script." ones. Do we want to try to support prompts with new-lines

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham created https://github.com/llvm/llvm-project/pull/66271: This reverts commit c95a0c91c0de66eb1066f23c69332522656f188e. llvm#65683 split `-fincremental-extensions` and `IncrementalProcessing` such that `IncrementalProcessing` can be used to extend the lifetime of var

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_requested https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

llvmbot wrote: @llvm/pr-subscribers-lldb Changes This reverts commit c95a0c91c0de66eb1066f23c69332522656f188e. llvm#65683 split `-fincremental-extensions` and `IncrementalProcessing` such that `IncrementalProcessing` can be used to extend the lifetime of various datastructures

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham updated https://github.com/llvm/llvm-project/pull/66271: >From 2f65db88d9249ca38fb86438fd92ef2f734d39b3 Mon Sep 17 00:00:00 2001 From: Ben Barham Date: Wed, 13 Sep 2023 11:14:35 -0700 Subject: [PATCH] Revert "[lldb] Fix the way we set up the lldb modules infrastruct

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham review_request_removed https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

https://github.com/bnbarham unlabeled https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

bnbarham wrote: Sorry about the noise here. I accidentally pushed over the same branch name. https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

bnbarham wrote: > Isn't that a better way to support the expression parsing logic where we > execute statements on the global scope to evaluate their results? This is currently enabled during module loading, where we definitely don't want any change in behavior IMO. Perhaps we could enable it

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

vgvassilev wrote: @bnbarham, I think it would be useful to keep it. > If we think this is useful to keep I'll need to look into how > https://github.com/llvm/llvm-project/pull/65683 broke LLDB testing: Incremental processing should also enable the llvm expression parser workflows. The advant

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

bnbarham wrote: > If you can provide links to the failing tests I can take a look. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/60022/ https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] Revert "[lldb] Fix the way we set up the lldb modules infrastructure." (PR #66271)

vgvassilev wrote: Does that PR fix the tests you mentioned? https://github.com/llvm/llvm-project/pull/66271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/66218: >From 9e3ccc3b7209ef92abedb3f7aa9b1ddd6687f410 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Sep 2023 08:05:10 -0700 Subject: [PATCH] [lldb] Add a setting to customize the prompt color Use

[Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/66218: >From bb1941649714c424bbcaab6c14892657aab55c93 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Sep 2023 08:05:10 -0700 Subject: [PATCH] [lldb] Add a setting to customize the prompt color Use

  1   2   >