[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein created this revision. hokein added a reviewer: avl. Herald added subscribers: ormris, kadircet, arphaman, steven_wu, hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-tools-extra. Herald added subscribers: llvm-

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. Herald added a subscriber: JDevlieghere. Let me know what you think about it -- I considered keeping the `llvm::writeFileAtomically` and migrating its underlying implementation to `llvm::writeToOutput`, but it doesn't seem to worth, there are only 4 in-tree usages of thi

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett added a comment. > The sanitized bot on GreenDragon runs on Intel and I assume the "risky' > changes only apply to arm64 as that's the only architecture that needs to > scale beyond the default 256? Anyway I haven't seen the leaks issue you've > mentioned locally so I'm happy to r

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

avl added a reviewer: jkorous. avl added a subscriber: jkorous. avl added a comment. added @jkorous who originally added llvm::writeFileAtomically. > Let me know what you think about it -- I considered keeping the > llvm::writeFileAtomically and migrating its underlying implementation to > llvm

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. In D153740#4448408 , @avl wrote: > added @jkorous who originally added llvm::writeFileAtomically. > >> Let me know what you think about it -- I considered keeping the >> llvm::writeFileAtomically and migrating its underlying imple

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett updated this revision to Diff 534580. DavidSpickett added a comment. Make a resize in EmulateInstructionARM64::EmulateLDPSTP uncondintional. Though in this case the register for an ldp/stp could only be an x register which is 8 bytes, so there would have been enough allocated alread

[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectSource.cpp:1266 : CommandObjectMultiword(interpreter, "source", "Commands for examining "

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

DavidSpickett updated this revision to Diff 534596. DavidSpickett added a comment. Drop {} in one place now that the resize is not conditional. The logic there also seems faulty, but in other ways I will stay out of for now. I did attempt another sanitizers build and realised I should have been s

[Lldb-commits] [lldb] 582582f - [LLDB] Add DWARF definitions for the new Mojo language

Author: walter erquinigo Date: 2023-06-26T11:31:48-05:00 New Revision: 582582fb474b8cd4103e65c3e5a705b3aff61794 URL: https://github.com/llvm/llvm-project/commit/582582fb474b8cd4103e65c3e5a705b3aff61794 DIFF: https://github.com/llvm/llvm-project/commit/582582fb474b8cd4103e65c3e5a705b3aff61794.di

[Lldb-commits] [PATCH] D153073: [LLDB] Add DWARF definitions for the new Mojo language

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG582582fb474b: [LLDB] Add DWARF definitions for the new Mojo language (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [lldb] 718e0cd - [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

Author: Alex Langford Date: 2023-06-26T10:33:18-07:00 New Revision: 718e0cd6e7240a1233991eec472aa904800dce00 URL: https://github.com/llvm/llvm-project/commit/718e0cd6e7240a1233991eec472aa904800dce00 DIFF: https://github.com/llvm/llvm-project/commit/718e0cd6e7240a1233991eec472aa904800dce00.diff

[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG718e0cd6e724: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

jingham added a comment. In D153657#4445292 , @bulbazord wrote: > I think this patch is probably okay to do, but it does break a supported use > case that I'm aware of: One way you can do "object oriented programming" in C > is to do exactly what you're

[Lldb-commits] [lldb] 5f69e66 - [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

Author: Alex Langford Date: 2023-06-26T10:36:41-07:00 New Revision: 5f69e6682bf0806c13098f79cb5f1ee30f0f8c06 URL: https://github.com/llvm/llvm-project/commit/5f69e6682bf0806c13098f79cb5f1ee30f0f8c06 DIFF: https://github.com/llvm/llvm-project/commit/5f69e6682bf0806c13098f79cb5f1ee30f0f8c06.diff

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f69e6682bf0: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] d49caf4 - [lldb] Add `source cache dump` and `source cache clear` subcommand

Author: Jonas Devlieghere Date: 2023-06-26T10:40:08-07:00 New Revision: d49caf4afc1bc460600b316f9736e01ceeebded5 URL: https://github.com/llvm/llvm-project/commit/d49caf4afc1bc460600b316f9736e01ceeebded5 DIFF: https://github.com/llvm/llvm-project/commit/d49caf4afc1bc460600b316f9736e01ceeebded5.d

[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rGd49caf4afc1b: [lldb] Add `source cache dump` and `source cache clear` subcommand (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to c

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] 2014572 - [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

Author: Alex Langford Date: 2023-06-26T11:06:29-07:00 New Revision: 2014572d9a6839745a920ec19ebfa73814548061 URL: https://github.com/llvm/llvm-project/commit/2014572d9a6839745a920ec19ebfa73814548061 DIFF: https://github.com/llvm/llvm-project/commit/2014572d9a6839745a920ec19ebfa73814548061.diff

[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

This revision was automatically updated to reflect the committed changes. Closed by commit rG2014572d9a68: [lldb][NFCI] Remove unneeded ConstString constructions for… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153673/new/

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

bulbazord added a comment. In D153657#4449608 , @jingham wrote: > In D153657#4445292 , @bulbazord > wrote: > >> I think this patch is probably okay to do, but it does break a supported use >> case that I'm aware

[Lldb-commits] [lldb] 9442e81 - [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData

Author: Alex Langford Date: 2023-06-26T11:09:09-07:00 New Revision: 9442e81f02a7e83132432269c9ada7c03eab7a38 URL: https://github.com/llvm/llvm-project/commit/9442e81f02a7e83132432269c9ada7c03eab7a38 DIFF: https://github.com/llvm/llvm-project/commit/9442e81f02a7e83132432269c9ada7c03eab7a38.diff

[Lldb-commits] [PATCH] D153675: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rG9442e81f02a7: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

JDevlieghere updated this revision to Diff 534663. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153726/new/ https://reviews.llvm.org/D153726 Files: lldb/include/lldb/Core/SourceManager.h lldb/include/lld

[Lldb-commits] [lldb] fec7c31 - [LLDB] Fix 582582fb474b8cd4103e65c3e5a705b3aff61794

Author: walter erquinigo Date: 2023-06-26T13:16:57-05:00 New Revision: fec7c313ab97d67f1335a4b0a8d12e63d517d0a4 URL: https://github.com/llvm/llvm-project/commit/fec7c313ab97d67f1335a4b0a8d12e63d517d0a4 DIFF: https://github.com/llvm/llvm-project/commit/fec7c313ab97d67f1335a4b0a8d12e63d517d0a4.di

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

bulbazord added inline comments. Comment at: lldb/source/Host/common/FileSystem.cpp:230 SmallString<128> resolved(path.begin(), path.end()); StandardTildeExpressionResolver Resolver; + m_tilde_resolver->ResolveFullPath(llvm::StringRef(path.begin(), path.size()), --

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

JDevlieghere updated this revision to Diff 534667. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Remove unused `Resolver`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153726/new/ https://reviews.llvm.org/D153726 Files: lldb/include/lldb/Core/SourceMan

[Lldb-commits] [PATCH] D153802: [lldb] Delete RewriteObjCClassReferences (NFC)

kastiglione created this revision. kastiglione added reviewers: augusto2112, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `RewriteObjCClassReferences` pass was applicable only to th

[Lldb-commits] [PATCH] D153810: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, Michael137, augusto2112, kastiglione, fdeazeve. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commi

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jasonmolenda, jingham, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The shared cache has grown past the previou

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. You might want to mention why it isn't sustainable -- because we must allocate memory in the inferior process, and some inferior processes have quite small memory limits.

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord added a comment. In D153817#4450534 , @jasonmolenda wrote: > LGTM. You might want to mention why it isn't sustainable -- because we must > allocate memory in the inferior process, and some inferior processes have > quite small memory limits.

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord updated this revision to Diff 534753. bulbazord added a comment. Update FIXME with more info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153817/new/ https://reviews.llvm.org/D153817 Files: lldb/source/Plugins/LanguageRuntime/ObjC/Ap

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord updated this revision to Diff 534757. bulbazord added a comment. Updating number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153817/new/ https://reviews.llvm.org/D153817 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRunti

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The underlying structures no longer use ConstString so we can rem

[Lldb-commits] [lldb] 7ed3c2e - [lldb] Increase the maximum number of classes we can read from shared cache

Author: Alex Langford Date: 2023-06-26T14:59:55-07:00 New Revision: 7ed3c2edf017840e0c7c358aa48d2d67d4b55dcb URL: https://github.com/llvm/llvm-project/commit/7ed3c2edf017840e0c7c358aa48d2d67d4b55dcb DIFF: https://github.com/llvm/llvm-project/commit/7ed3c2edf017840e0c7c358aa48d2d67d4b55dcb.diff

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ed3c2edf017: [lldb] Increase the maximum number of classes we can read from shared cache (authored by bulbazord). Repository: rG LLVM Github Mono

[Lldb-commits] [lldb] f05e2fb - Don't allow SBValue::Cast to cast from a smaller type to a larger,

Author: Jim Ingham Date: 2023-06-26T16:02:01-07:00 New Revision: f05e2fb013f0e2504471a9899dba7d70cc58a63d URL: https://github.com/llvm/llvm-project/commit/f05e2fb013f0e2504471a9899dba7d70cc58a63d DIFF: https://github.com/llvm/llvm-project/commit/f05e2fb013f0e2504471a9899dba7d70cc58a63d.diff LO

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

This revision was automatically updated to reflect the committed changes. Closed by commit rGf05e2fb013f0: Don't allow SBValue::Cast to cast from a smaller type to a larger, (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D153657?vs=534036&id=534775#toc Repository: r

[Lldb-commits] [PATCH] D153822: FileSystem::EnumerateDirectory should keep iterating if one entry has an invalid Status

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. EnumerateDirectory gets the vfs::Status of each file entry, to

[Lldb-commits] [PATCH] D153822: FileSystem::EnumerateDirectory should keep iterating if one entry has an invalid Status

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo capitalization. Comment at: lldb/unittests/Host/FileSystemTest.cpp:54 return make_error_code(llvm::errc::no_such_file_or_directory); +// si

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Now that we have a proper way to deprecate things i

[Lldb-commits] [lldb] 2c1108f - FileSystem::EnumerateDirectory should skip entries w/o Status, not halt

Author: Jason Molenda Date: 2023-06-26T17:46:53-07:00 New Revision: 2c1108f44342019a67ce55bb98e2a05b57a70b9a URL: https://github.com/llvm/llvm-project/commit/2c1108f44342019a67ce55bb98e2a05b57a70b9a DIFF: https://github.com/llvm/llvm-project/commit/2c1108f44342019a67ce55bb98e2a05b57a70b9a.diff

[Lldb-commits] [PATCH] D153822: FileSystem::EnumerateDirectory should keep iterating if one entry has an invalid Status

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c1108f44342: FileSystem::EnumerateDirectory should skip entries w/o Status, not halt (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D153822?vs=534792&id=534800#toc Repos

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of just returning a raw `const char *`, I think llvm::Str

[Lldb-commits] [PATCH] D153734: [lldb][TargetGetModuleCallback] Call get module callback

splhack updated this revision to Diff 534803. splhack added a comment. Move SetTargetGetModuleCallback from Debugger to Platform. https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580/4?u=splhack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

splhack updated this revision to Diff 534804. splhack added a comment. Move SetTargetGetModuleCallback from SBDebugger to SBPlatform. https://discourse.llvm.org/t/rfc-python-callback-for-target-get-module/71580/4?u=splhack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

bulbazord created this revision. bulbazord added reviewers: clayborg, DavidSpickett, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm not convinced that it makes sense for the paths to

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153824/new/ https://reviews.llvm.org/D153824 ___

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, clayborg, jingham, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. We recently saw an uptick in internal reports complaining that LLDB is slow when source on NFS are inaccessibl

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. 🚂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153818/new/ https://reviews.llvm.org/D153818 __

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153825/new/ https://reviews.llvm.org/D153825 ___

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153827/new/ https://reviews.llvm.org/D153827 ___

[Lldb-commits] [PATCH] D153636: [LLDB] Fix the use of "platform process launch" with no extra arguments

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153636/new/ https://reviews.llvm.org/D153636