avl added a reviewer: jkorous.
avl added a subscriber: jkorous.
avl added a comment.
added @jkorous who originally added llvm::writeFileAtomically.
> Let me know what you think about it -- I considered keeping the
> llvm::writeFileAtomically and migrating its underlying implementation to
> llvm::writeToOutput, but it doesn't seem to worth, there are only 4 in-tree
> usages of this API, I think it is probably better just remove it.
I think it is OK to leave only one API (f.e. llvm::writeToOutput) and remove
another. It would probably be better to split this patch to lldb, thinlto,
clang and removal parts.
================
Comment at: lldb/tools/lldb-server/lldb-platform.cpp:107
Status status;
- if (auto Err =
- handleErrors(llvm::writeFileAtomically(
- temp_file_path, file_spec.GetPath(), socket_id),
- [&status, &file_spec](const AtomicFileWriteError &E) {
- std::string ErrorMsgBuffer;
- llvm::raw_string_ostream S(ErrorMsgBuffer);
- E.log(S);
-
- switch (E.Error) {
- case atomic_write_error::failed_to_create_uniq_file:
- status = Status("Failed to create temp file: %s",
- ErrorMsgBuffer.c_str());
- break;
- case atomic_write_error::output_stream_error:
- status = Status("Failed to write to port file.");
- break;
- case atomic_write_error::failed_to_rename_temp_file:
- status = Status("Failed to rename file %s to %s:
%s",
- ErrorMsgBuffer.c_str(),
- file_spec.GetPath().c_str(),
- ErrorMsgBuffer.c_str());
- break;
- }
- })) {
+ if (auto Err = handleErrors(file_spec.GetPath(),
+ [&socket_id](llvm::raw_ostream &OS) {
----------------
the call to llvm::writeToOutput is probably missed here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153740/new/
https://reviews.llvm.org/D153740
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
