[Lldb-commits] [PATCH] D146297: [lldb][gnustep][PDB] Parse ObjC base classes and recognize NSObject type

compnerd added inline comments. Comment at: lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:399 // Such symbols will be handled here. // Ignore unnamed-tag UDTs. Does it make sense to drop a note here that the 0-length UDT is used as a marker for

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

mib created this revision. mib added reviewers: bulbazord, jingham. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch updates the `lldbutil.fetch_next_event` he

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

bulbazord added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1206-1207 +def fetch_next_event(test, listener, broadcaster, match_class=False, timeout=10): """Fetch one event from the listener and return it if it matches the provided broadcast

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148662/new/ https://reviews.llvm.org/D148662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

mib updated this revision to Diff 516854. mib marked 2 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149175/new/ https://reviews.llvm.org/D149175 Files: lldb/packages/P

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

mib added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1219-1220 +stream = lldb.SBStream() +event.GetDescription(stream) test.fail("received event '%s' from unexpected broadcaster '%s'." % bulbazord wrote

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149175/new/ https://reviews.llvm.org/D149175 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D149179: [lldb/test] Consolidate interactive scripted process debugging test

mib created this revision. mib added reviewers: jingham, bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improve the interactive scripted process debugging test by adding tes

[Lldb-commits] [PATCH] D149180: [LLDB][REPL] Destroy the repl instances correctly

wallace created this revision. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change ensures that the REPL map inside Target is destroyed correctly when `Target::Destroy()` is invoked. Not doing s

[Lldb-commits] [lldb] 59a39c2 - [LLDB][REPL] Destroy the repl instances correctly

Author: walter erquinigo Date: 2023-04-25T15:09:08-05:00 New Revision: 59a39c2fc91ed5b750083bc51dc43b6510a501b6 URL: https://github.com/llvm/llvm-project/commit/59a39c2fc91ed5b750083bc51dc43b6510a501b6 DIFF: https://github.com/llvm/llvm-project/commit/59a39c2fc91ed5b750083bc51dc43b6510a501b6.di

[Lldb-commits] [PATCH] D149180: [LLDB][REPL] Destroy the repl instances correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59a39c2fc91e: [LLDB][REPL] Destroy the repl instances correctly (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lldb/source/Interpreter/OptionGroupWatchpoint.cpp:67 + "Number of bytes to use to watch a region."}, +{LLDB_OPT_SET_2, + false,

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

bulbazord added inline comments. Comment at: lldb/source/Interpreter/OptionGroupWatchpoint.cpp:67 + "Number of bytes to use to watch a region."}, +{LLDB_OPT_SET_2, + false, jasonmolenda wrote: > I don't care much, but the formatting of this entry is p

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. I think we should still be able to use this new flag with the previous ones (i.e. `watchpoint set -l c++ -w read -- &my_var`) Comment at: lldb/source/Interpreter/OptionG

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

bulbazord requested review of this revision. bulbazord added a comment. In D149111#4296670 , @mib wrote: > I think we should still be able to use this new flag with the previous ones > (i.e. `watchpoint set -l c++ -w read -- &my_var`) You can do that st

[Lldb-commits] [PATCH] D149179: [lldb/test] Consolidate interactive scripted process debugging test

bulbazord added a comment. Seems ok to me. You might want to update the dependencies of this diff so that the pre-merge checks don't fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149179/new/ https://reviews.llvm.org/D149179

[Lldb-commits] [PATCH] D149179: [lldb/test] Consolidate interactive scripted process debugging test

mib updated this revision to Diff 516929. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149179/new/ https://reviews.llvm.org/D149179 Files: lldb/test/API/functionalities/interactive_scripted_process/TestInteractiveScriptedProcess.py Index: lldb/test/API/functionalities/interactive_sc

[Lldb-commits] [lldb] 0d77e03 - [lldb/API] Introduce SBProcess::ForceScriptedState method

Author: Med Ismail Bennani Date: 2023-04-25T15:02:33-07:00 New Revision: 0d77e034749f57676fd79e4a5b560be4d5b52b48 URL: https://github.com/llvm/llvm-project/commit/0d77e034749f57676fd79e4a5b560be4d5b52b48 DIFF: https://github.com/llvm/llvm-project/commit/0d77e034749f57676fd79e4a5b560be4d5b52b48.

[Lldb-commits] [lldb] 6c961ae - [lldb] Move ScriptedProcess private state update to implementation

Author: Med Ismail Bennani Date: 2023-04-25T15:02:34-07:00 New Revision: 6c961ae1b5073699285fcdec242cdb4e84602c05 URL: https://github.com/llvm/llvm-project/commit/6c961ae1b5073699285fcdec242cdb4e84602c05 DIFF: https://github.com/llvm/llvm-project/commit/6c961ae1b5073699285fcdec242cdb4e84602c05.

[Lldb-commits] [lldb] 46e93c9 - [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

Author: Med Ismail Bennani Date: 2023-04-25T15:02:34-07:00 New Revision: 46e93c9df287bc06854c66e08658f757ff6cf6f1 URL: https://github.com/llvm/llvm-project/commit/46e93c9df287bc06854c66e08658f757ff6cf6f1 DIFF: https://github.com/llvm/llvm-project/commit/46e93c9df287bc06854c66e08658f757ff6cf6f1.

[Lldb-commits] [lldb] 6382fcb - [lldb/Utility] Add opt-in shadow mode to event listeners

Author: Med Ismail Bennani Date: 2023-04-25T15:02:34-07:00 New Revision: 6382fcb16def5ae4a47082466fd8dc93e8fdf988 URL: https://github.com/llvm/llvm-project/commit/6382fcb16def5ae4a47082466fd8dc93e8fdf988 DIFF: https://github.com/llvm/llvm-project/commit/6382fcb16def5ae4a47082466fd8dc93e8fdf988.

[Lldb-commits] [lldb] ad03aea - [lldb/Plugin] Add breakpoint setting support to ScriptedProcess

Author: Med Ismail Bennani Date: 2023-04-25T15:02:34-07:00 New Revision: ad03aeadfb72e9c872b297bbaedbf46ebac3572c URL: https://github.com/llvm/llvm-project/commit/ad03aeadfb72e9c872b297bbaedbf46ebac3572c DIFF: https://github.com/llvm/llvm-project/commit/ad03aeadfb72e9c872b297bbaedbf46ebac3572c.

[Lldb-commits] [lldb] 482a0ad - [lldb] Improve logging for process state change (NFC)

Author: Med Ismail Bennani Date: 2023-04-25T15:02:34-07:00 New Revision: 482a0ad5ba72d2c306afd2d529f14eadcd8a URL: https://github.com/llvm/llvm-project/commit/482a0ad5ba72d2c306afd2d529f14eadcd8a DIFF: https://github.com/llvm/llvm-project/commit/482a0ad5ba72d2c306afd2d529f14eadcd8a.

[Lldb-commits] [lldb] af1fea8 - [lldb/API] Add convenience constructor for SBError (NFC)

Author: Med Ismail Bennani Date: 2023-04-25T15:02:34-07:00 New Revision: af1fea818391f20d585414493adb3fcdc70b4756 URL: https://github.com/llvm/llvm-project/commit/af1fea818391f20d585414493adb3fcdc70b4756 DIFF: https://github.com/llvm/llvm-project/commit/af1fea818391f20d585414493adb3fcdc70b4756.

[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d77e034749f: [lldb/API] Introduce SBProcess::ForceScriptedState method (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145294/new/ https:/

[Lldb-commits] [lldb] 6cf6680 - [lldb] Add an example of interactive scripted process debugging

Author: Med Ismail Bennani Date: 2023-04-25T15:02:34-07:00 New Revision: 6cf668016efde05db8c9f179843ec457ad017ff7 URL: https://github.com/llvm/llvm-project/commit/6cf668016efde05db8c9f179843ec457ad017ff7 DIFF: https://github.com/llvm/llvm-project/commit/6cf668016efde05db8c9f179843ec457ad017ff7.

[Lldb-commits] [lldb] e31d0c2 - [lldb] Improve breakpoint management for interactive scripted process

Author: Med Ismail Bennani Date: 2023-04-25T15:03:15-07:00 New Revision: e31d0c20e411f22a943f1ed5f8b618c529436c59 URL: https://github.com/llvm/llvm-project/commit/e31d0c20e411f22a943f1ed5f8b618c529436c59 DIFF: https://github.com/llvm/llvm-project/commit/e31d0c20e411f22a943f1ed5f8b618c529436c59.

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c961ae1b507: [lldb] Move ScriptedProcess private state update to implementation (authored by mib). Changed prior to commit: https://reviews.llvm.org/D145295?vs=504877&id=516941#toc Repository: rG LL

[Lldb-commits] [lldb] 34bd157 - [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

Author: Med Ismail Bennani Date: 2023-04-25T15:03:45-07:00 New Revision: 34bd15798ede2bc003783ed61d08f8d6c74c38f9 URL: https://github.com/llvm/llvm-project/commit/34bd15798ede2bc003783ed61d08f8d6c74c38f9 DIFF: https://github.com/llvm/llvm-project/commit/34bd15798ede2bc003783ed61d08f8d6c74c38f9.

[Lldb-commits] [lldb] d3a6b93 - [lldb/test] Consolidate interactive scripted process debugging test

Author: Med Ismail Bennani Date: 2023-04-25T15:03:45-07:00 New Revision: d3a6b93135cd344737b2877b78afe9c862e40041 URL: https://github.com/llvm/llvm-project/commit/d3a6b93135cd344737b2877b78afe9c862e40041 DIFF: https://github.com/llvm/llvm-project/commit/d3a6b93135cd344737b2877b78afe9c862e40041.

[Lldb-commits] [PATCH] D148395: [lldb] Unify default/hijack listener between Process{Attach, Launch}Info (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG46e93c9df287: [lldb] Unify default/hijack listener between Process{Attach,Launch}Info (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D148397: [lldb/Utility] Add opt-in shadow mode to event listeners

This revision was automatically updated to reflect the committed changes. Closed by commit rG6382fcb16def: [lldb/Utility] Add opt-in shadow mode to event listeners (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148397/new/ https://

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG482a0ad5ba72: [lldb] Improve logging for process state change (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://rev

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

This revision was automatically updated to reflect the committed changes. Closed by commit rGad03aeadfb72: [lldb/Plugin] Add breakpoint setting support to ScriptedProcess (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145296/new/ h

[Lldb-commits] [PATCH] D148401: [lldb/API] Add convenience constructor for SBError (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf1fea818391: [lldb/API] Add convenience constructor for SBError (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148401/new/ https://

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf668016efd: [lldb] Add an example of interactive scripted process debugging (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145297/new/ h

[Lldb-commits] [PATCH] D148548: [lldb] Improve breakpoint management for interactive scripted process

This revision was automatically updated to reflect the committed changes. Closed by commit rGe31d0c20e411: [lldb] Improve breakpoint management for interactive scripted process (authored by mib). Changed prior to commit: https://reviews.llvm.org/D148548?vs=515902&id=516948#toc Repository: rG

[Lldb-commits] [PATCH] D149175: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class

This revision was automatically updated to reflect the committed changes. Closed by commit rG34bd15798ede: [lldb/test] Update lldbutil.fetch_next_event to match broadcaster class (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149175

[Lldb-commits] [PATCH] D149179: [lldb/test] Consolidate interactive scripted process debugging test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3a6b93135cd: [lldb/test] Consolidate interactive scripted process debugging test (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 30f4adf - [lldb/test] Enable threads for TestInteractiveScriptedProcess.py (NFC)

Author: Med Ismail Bennani Date: 2023-04-25T15:19:57-07:00 New Revision: 30f4adfd4d6ca73b1dae1d14f43ac363e005ccec URL: https://github.com/llvm/llvm-project/commit/30f4adfd4d6ca73b1dae1d14f43ac363e005ccec DIFF: https://github.com/llvm/llvm-project/commit/30f4adfd4d6ca73b1dae1d14f43ac363e005ccec.

[Lldb-commits] [lldb] d0d902d - [lldb/test] Disable Interactive Scripted Process test unless Darwin

Author: Med Ismail Bennani Date: 2023-04-25T16:00:58-07:00 New Revision: d0d902df0698f94957e13df159e9cd159a99344c URL: https://github.com/llvm/llvm-project/commit/d0d902df0698f94957e13df159e9cd159a99344c DIFF: https://github.com/llvm/llvm-project/commit/d0d902df0698f94957e13df159e9cd159a99344c.

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev created this revision. VladimirMakaev added reviewers: clayborg, ayermolo, Michael137. VladimirMakaev added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. Herald added a project: All. VladimirMakaev requested review of this revision. Herald

[Lldb-commits] [lldb] f8d6542 - [lldb/test] Fix test failure from missing decorator

Author: Med Ismail Bennani Date: 2023-04-25T16:08:55-07:00 New Revision: f8d6542e873be7821636fd5ae313e8249c235438 URL: https://github.com/llvm/llvm-project/commit/f8d6542e873be7821636fd5ae313e8249c235438 DIFF: https://github.com/llvm/llvm-project/commit/f8d6542e873be7821636fd5ae313e8249c235438.

[Lldb-commits] [PATCH] D149214: [lldb] Speed up DebugAbbrev parsing

bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While measuring some performance in LLDB I noticed that we were spendi

[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. In D149111#4296709 , @bulbazord wrote: > In D149111#4296670 , @mib wrote: > >> I think we should still be able to u

[Lldb-commits] [lldb] fc28560 - [lldb][NFCI] Remove unused swig macros

Author: Alex Langford Date: 2023-04-25T16:47:00-07:00 New Revision: fc28560fd675a93f06d73628b469fbe3c6850282 URL: https://github.com/llvm/llvm-project/commit/fc28560fd675a93f06d73628b469fbe3c6850282 DIFF: https://github.com/llvm/llvm-project/commit/fc28560fd675a93f06d73628b469fbe3c6850282.diff

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

dyung added a comment. Hi @mib, your change is causing a build failure on two build bots, can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/217/builds/20430 https://lab.llvm.org/buildbot/#/builders/243/builds/5438 Repository: rG LLVM Git

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib added a comment. In D145295#4297312 , @dyung wrote: > Hi @mib, your change is causing a build failure on two build bots, can you > take a look and revert if you need time to investigate? > > https://lab.llvm.org/buildbot/#/builders/217/builds/20430 >

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

mib created this revision. mib added a reviewer: bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. In 6c961ae

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Unfortunate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149218/new/ https://reviews.llvm.org/D149218 _

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib added a comment. In D145295#4297322 , @mib wrote: > In D145295#4297312 , @dyung wrote: > >> Hi @mib, your change is causing a build failure on two build bots, can you >> take a look and revert if you need tim

[Lldb-commits] [lldb] da07008 - [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

Author: Med Ismail Bennani Date: 2023-04-25T17:26:45-07:00 New Revision: da0700829f163ad5d8bbd61aa137e586a816e06e URL: https://github.com/llvm/llvm-project/commit/da0700829f163ad5d8bbd61aa137e586a816e06e DIFF: https://github.com/llvm/llvm-project/commit/da0700829f163ad5d8bbd61aa137e586a816e06e.

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0700829f16: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D149218: [lldb] Fix another GCC build failure in ScriptedPythonInterface.h

mib added a comment. Fixed the problem: https://lab.llvm.org/buildbot/#/builders/217/builds/20435 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149218/new/ https://reviews.llvm.org/D149218 ___ lldb-commi

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

dyung added a comment. In D145295#4297347 , @mib wrote: > In D145295#4297322 , @mib wrote: > >> In D145295#4297312 , @dyung wrote: >> >>> Hi @mib, your change is causing a

[Lldb-commits] [PATCH] D149224: Fix an off-by-one error with armv7 mach-o corefile register contexts (LC_THREADs)

jasonmolenda created this revision. jasonmolenda added reviewers: fixathon, JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: omjavaid, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Sla

[Lldb-commits] [PATCH] D149224: Fix an off-by-one error with armv7 mach-o corefile register contexts (LC_THREADs)

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. Great catch. Thank you for finding and fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149224/new/ https://reviews.llvm.org/D1492

[Lldb-commits] [lldb] 7b5bf3a - [lldb] Add entry to code owner

Author: Med Ismail Bennani Date: 2023-04-25T23:15:07-07:00 New Revision: 7b5bf3a473ca26e3572f9f88c6e1bc3c85a2138c URL: https://github.com/llvm/llvm-project/commit/7b5bf3a473ca26e3572f9f88c6e1bc3c85a2138c DIFF: https://github.com/llvm/llvm-project/commit/7b5bf3a473ca26e3572f9f88c6e1bc3c85a2138c.