mib added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1219-1220
 
+        stream = lldb.SBStream()
+        event.GetDescription(stream)
         test.fail("received event '%s' from unexpected broadcaster '%s'." %
----------------
bulbazord wrote:
> I'm not sure why you added this part? Is there something not great about 
> calling `SBEvent::GetDescription` directly?
This is actually a fix of the original implementation 
(`SBEvent::GetDescription` requires a `SBStream` argument but when added this 
helper function, we never took this code path, so we never hit that error).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149175/new/

https://reviews.llvm.org/D149175

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to