[Lldb-commits] [PATCH] D143398: [WIP][lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** This patch makes the expres

[Lldb-commits] [lldb] 0b8eff1 - [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

Author: Shivam Gupta Date: 2023-02-06T22:07:43+05:30 New Revision: 0b8eff1f8724c6d8e890227597060109cb55e1ca URL: https://github.com/llvm/llvm-project/commit/0b8eff1f8724c6d8e890227597060109cb55e1ca DIFF: https://github.com/llvm/llvm-project/commit/0b8eff1f8724c6d8e890227597060109cb55e1ca.diff

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0b8eff1f8724: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp (authored by xgupta). Repository:

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

xgupta added a comment. In D142309#4102284 , @labath wrote: > In D142309#4075745 , @JDevlieghere > wrote: > >> LGTM, but I wonder when we'll be able to get rid of RenderScript completely >> (CC @labath) > > I am

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

srhines added a comment. In D142309#4107170 , @xgupta wrote: > In D142309#4102284 , @labath wrote: > >> In D142309#4075745 , @JDevlieghere >> wrote: >> >>> LGTM, but I wo

[Lldb-commits] [PATCH] D143308: [lldb/Plugins] Fix method dispatch bug when using multiple scripted processes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143308/new/ https://reviews.llvm.org/D143308 ___ lldb-commits

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1148 +class CrashLogLoadingMode(str, enum.Enum): +legacy = 'legacy' +interactive = 'interactive' This can be interpreted as the textual crashlogs going away which isn't the

[Lldb-commits] [PATCH] D143398: [WIP][lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Michael137 updated this revision to Diff 495230. Michael137 added a comment. - Reword commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143398/new/ https://reviews.llvm.org/D143398 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTP

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

clayborg added a comment. Changes look fine to me. I would like someone that specializes in the expression parser to give the final ok though. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp:551 const LayoutI

[Lldb-commits] [PATCH] D143232: Return an error when the CFA resolves to no known register, instead of segfaulting

jasonmolenda added a comment. In D143232#4101396 , @bulbazord wrote: > LGTM. I wonder if there's a good way to exercise this with a test? Like maybe > we can create some bogus unwind information and see if LLDB falls over when > consuming it? I'm not s

[Lldb-commits] [PATCH] D143232: Return an error when the CFA resolves to no known register, instead of segfaulting

This revision was automatically updated to reflect the committed changes. Closed by commit rG701030c3ecba: In InitializeZerothFrame check for a CFA/AFA or error out (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143232/new/

[Lldb-commits] [lldb] 701030c - In InitializeZerothFrame check for a CFA/AFA or error out

Author: Jason Molenda Date: 2023-02-06T14:53:50-08:00 New Revision: 701030c3ecba0621ce5d325667fb75b73cf1532b URL: https://github.com/llvm/llvm-project/commit/701030c3ecba0621ce5d325667fb75b73cf1532b DIFF: https://github.com/llvm/llvm-project/commit/701030c3ecba0621ce5d325667fb75b73cf1532b.diff

[Lldb-commits] [PATCH] D143012: Add a bit of error checking to SBProcess::ReadMemory to check if a nullptr destination buffer was provided, return error

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo inline comments Comment at: lldb/source/API/SBProcess.cpp:807-811 + if (!dst) { +sb_error.SetErrorStringWithFormat( +"no buffer provided

[Lldb-commits] [PATCH] D143012: Add a bit of error checking to SBProcess::ReadMemory to check if a nullptr destination buffer was provided, return error

mib accepted this revision. mib added a comment. LGTM with @JDevlieghere comments. Comment at: lldb/source/API/SBProcess.cpp:807-811 + if (!dst) { +sb_error.SetErrorStringWithFormat( +"no buffer provided to read %zu bytes into", dst_len); +return 0; + } --

[Lldb-commits] [lldb] a3d4f73 - [lldb/Plugins] Fix method dispatch bug when using multiple scripted processes

Author: Med Ismail Bennani Date: 2023-02-06T16:02:51-08:00 New Revision: a3d4f739eea357c702754246442a2568f2bace81 URL: https://github.com/llvm/llvm-project/commit/a3d4f739eea357c702754246442a2568f2bace81 DIFF: https://github.com/llvm/llvm-project/commit/a3d4f739eea357c702754246442a2568f2bace81.

[Lldb-commits] [PATCH] D143308: [lldb/Plugins] Fix method dispatch bug when using multiple scripted processes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3d4f739eea3: [lldb/Plugins] Fix method dispatch bug when using multiple scripted processes (authored by mib). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

aprantl added a comment. SGTM. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3480 + clang::NamespaceDecl *namespace_decl = + static_cast(m_die_to_decl_ctx[die.GetDIE()]); + if (namespace_decl) The common pattern in LLVM (and th

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda updated this revision to Diff 495385. jasonmolenda edited the summary of this revision. jasonmolenda added a comment. David's feedback was spot on, overhaul patch to address. Change Process::GetWatchpointSlotCount to return an optional count, for when it is available, instead of dep

[Lldb-commits] [lldb] 5273168 - [lldb] Fix typo in LoongArch unittest

Author: Weining Lu Date: 2023-02-07T15:09:04+08:00 New Revision: 52731683c9a2f4f8138c317201ea68eaedca7225 URL: https://github.com/llvm/llvm-project/commit/52731683c9a2f4f8138c317201ea68eaedca7225 DIFF: https://github.com/llvm/llvm-project/commit/52731683c9a2f4f8138c317201ea68eaedca7225.diff LO

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda added a comment. I phabracated wrong and the end of the last msg was truncated. I meant to end it with this: If the number of watchpoints could not be fetched with an lldb-extension packet, Process:GetWatchpointSupportInfo would not report whether breakpoints are received before