[Lldb-commits] [PATCH] D140839: [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation

Michael137 added inline comments. Comment at: lldb/test/Shell/helper/build.py:29 default='host', -choices=['32', '64', 'host'], help='Specify the architecture to target.') Why was this needed? Other t

[Lldb-commits] [PATCH] D141828: [WIP][lldb] Add support for DW_AT_default_value in template params

Michael137 created this revision. Michael137 added a reviewer: dblaikie. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** This patch makes LLDB understand

[Lldb-commits] [lldb] c8e4eb1 - [LLDB] Fix help text for "platform settings"

Author: David Spickett Date: 2023-01-16T09:37:29Z New Revision: c8e4eb1043f4be6d9d823ce8f3238dca3479ffd4 URL: https://github.com/llvm/llvm-project/commit/c8e4eb1043f4be6d9d823ce8f3238dca3479ffd4 DIFF: https://github.com/llvm/llvm-project/commit/c8e4eb1043f4be6d9d823ce8f3238dca3479ffd4.diff LOG

[Lldb-commits] [PATCH] D136928: [LLDB] Fix help text for "platform settings"

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8e4eb1043f4: [LLDB] Fix help text for "platform settings" (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136928/new/ https://re

[Lldb-commits] [PATCH] D141828: [WIP][lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 489488. Michael137 added a comment. - Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.c

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. @clayborg Thanks for your feedback. I'm part the way through implementing your changes. Specifically about this point: > I seem to remember that it will disable this watchpoint as soon as a local > variable goes out of scope, though I might not be remember things co

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

clayborg added a comment. In D140630#4056641 , @cimacmillan wrote: > @clayborg Thanks for your feedback. I'm part the way through implementing > your changes. Specifically about this point: > >> I seem to remember that it will disable this watchpoint as

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto max_instruction_size = g_vsc.target.GetMaximumOpcodeByteSize(); + const auto bytes_offset = -instruction_offset * max_instruction_size; + auto start_addr = base_addr - bytes_of

[Lldb-commits] [PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa288d7f93770: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides (authored by jloser). Changed prior to commit: https://revie

[Lldb-commits] [PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); serge-sans-paille wrote: > random nit: This could be rewritten as > > ``` > llvm::Mutable