cimacmillan added a comment.
@clayborg Thanks for your feedback. I'm part the way through implementing your
changes. Specifically about this point:
> I seem to remember that it will disable this watchpoint as soon as a local
> variable goes out of scope, though I might not be remember things correctly
This is a behaviour I'd like to address, where for instance watchpoints are
triggered in different functions because the stack frame addresses align. I
have this example, I can add a test for:
int test_a() {
int x = 10; <- watchpoint set here
x = 20; <- watchpoint triggered here
}
int test_b() {
int b = 10; <- watchpoint triggered here also
b = 20;
}
int main() {
test_a();
test_b();
I've refactored the Watchpoint class to use "SBValue::Watch", and I can still
reproduce this behaviour. I also can't find where this watchpoint disable on
scope change might be implemented. Do you have any suggestions for this? Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140630/new/
https://reviews.llvm.org/D140630
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
