[Lldb-commits] [lldb] 0ef58c6 - [LLDB][RISCV] Add RVDC instruction support for EmulateInstructionRISCV

Author: Emmmer Date: 2023-01-13T20:52:34+08:00 New Revision: 0ef58c66c6e4652ff3582bf0972673708afb912e URL: https://github.com/llvm/llvm-project/commit/0ef58c66c6e4652ff3582bf0972673708afb912e DIFF: https://github.com/llvm/llvm-project/commit/0ef58c66c6e4652ff3582bf0972673708afb912e.diff LOG: [

[Lldb-commits] [PATCH] D140961: [LLDB][RISCV] Add RVDC instruction support for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Emmmer marked an inline comment as done. Closed by commit rG0ef58c66c6e4: [LLDB][RISCV] Add RVDC instruction support for EmulateInstructionRISCV (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: r

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

aaron.ballman added a comment. In D131858#4050112 , @rsmith wrote: > In D131858#3957630 , @arphaman > wrote: > >> This change has caused a failure in Clang's stage 2 CI on the green dragon >> Darwin CI: >> http

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4051336 , @aaron.ballman wrote: > In D131858#4050112 , @rsmith wrote: > >> In D131858#3957630 , @arphaman >> wrote: >> >>> This ch

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. @arphaman I see you're part of the original report too, if you could try to revert the workaround and test it, it would be nice too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

aaron.ballman added a comment. In D131858#4051352 , @erichkeane wrote: > In D131858#4051336 , @aaron.ballman > wrote: > >> In D131858#4050112 , @rsmith wrote: >> >>> In

[Lldb-commits] [PATCH] D141687: [LLDB] Remove return value from DumpRegisterValue

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No one ever checks it. Also convert to early return. Repository: rG LLVM Github Monorepo https://reviews.ll

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. The most recent versions of this patch contains squashed changes from these reviews: - D139278 "[AArch64] Use string comparison for ArchInfo equality." This fixes the test failures with shared libraries, which were caused by each sh

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added a comment. Worth noting that this had to be reworked because both D127812 and D137838 went in since this was reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. Note, I just did the revert of the workaround myself here: 498bf3424d011235d420e02e80e135fae646d537 I won't see the failure on https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/ until Tue

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

pratlucas accepted this revision. pratlucas added a comment. LGTM with a tiny nit. Feel free to fix it when landing the changes. Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:164-166 + CPUFeatures CPUFeature; // ? + StringRef DependentFeatures; //

[Lldb-commits] [lldb] bafa145 - [lldb][NFC] Remove dependency on DataLayout::getPrefTypeAlignment

Author: Guillaume Chatelet Date: 2023-01-13T15:04:06Z New Revision: bafa145c0eb63ac0c7b662bd646aa2c73cbc07b7 URL: https://github.com/llvm/llvm-project/commit/bafa145c0eb63ac0c7b662bd646aa2c73cbc07b7 DIFF: https://github.com/llvm/llvm-project/commit/bafa145c0eb63ac0c7b662bd646aa2c73cbc07b7.diff

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

labath added a comment. In addition to that, it breaks tests with ubsan. :) I raised a similar concern in one of the other patches. I'm of the opinion that it's not worth pretending like the scripted processes (platforms, etc.) are plugins. I don't think that it can be achieved without some sor

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

danielkiss added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder);

[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

tmatheson added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder); -

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Default interactive mode & report progress on image loading

JDevlieghere added a comment. Switching the default over seems fine. The symbol lookup stuff seems orthogonal to that and maybe should be its own patch? Comment at: lldb/examples/python/crashlog.py:452 -with open(path, 'r', encoding='utf-8') as f: +with open(

[Lldb-commits] [lldb] d667840 - Revert "[lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance"

Author: Med Ismail Bennani Date: 2023-01-13T09:13:03-08:00 New Revision: d667840465b0ea0dbd39dcbd56788e73698dc853 URL: https://github.com/llvm/llvm-project/commit/d667840465b0ea0dbd39dcbd56788e73698dc853 DIFF: https://github.com/llvm/llvm-project/commit/d667840465b0ea0dbd39dcbd56788e73698dc853.

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the way modules get loaded in lldb when using interactive crashlog. It

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib updated this revision to Diff 489042. mib marked 2 inline comments as done. mib retitled this revision from "[lldb/crashlog] Default interactive mode & report progress on image loading" to "[lldb/crashlog] Make interactive mode the new default". mib edited the summary of this revision. mib ad

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and @erichkeane for the efforts saving @mizvekov work over the summer. I believe he has sporadic access to internet and soon he will be back to normal. Great example of team work here!! Repo

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4052026 , @v.g.vassilev wrote: > Thanks a lot @rsmith for providing a fix and thanks a lot @aaron.ballman and > @erichkeane for the efforts saving @mizvekov work over the summer. I believe > he has sporadic access

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

JDevlieghere added a comment. Another nice addition here would be checking if stdout is a tty (`sys.stdout.isatty()`) and continuing to use the textual format if it isn't. A quick experiment seems to show this does the right thing from inside LLDB: $ echo -e "script\nimport sys\nsys.stdout.is

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1302 +print("Aborting symbolication.") +print() +option_parser.print_help() JDevlieghere wrote: > Spurious print? It doesn't look like we're printing a double newline

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord added a comment. I'm somewhat unfamiliar with this code so I'll ask some clarifying questions. I think I understand the idea in general though. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:34-37 +for section

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord added a comment. Additionally, it looks like you're doing maybe 2-3 things in this patch (Progress reporting, adding a guard rail, changing the format of `loaded_images` in the scripted process example). You could probably break this up into multiple patches. Repository: rG LLVM G

[Lldb-commits] [lldb] ed01de6 - [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-01-13T14:07:29-06:00 New Revision: ed01de67433174d3157e9d239d59dd465d52c6a5 URL: https://github.com/llvm/llvm-project/commit/ed01de67433174d3157e9d239d59dd465d52c6a5 DIFF: https://github.com/llvm/llvm-project/commit/ed01de67433174d3157e9d239d59dd465d52c6a5.dif

[Lldb-commits] [PATCH] D138496: [OpenMP][OMPContext] Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed01de674331: [OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend (authored by domada). Herald added projects: clang, LLDB. Heral

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:34-37 +for section in image.section_infos: +if section.start_addr and section.name

[Lldb-commits] [lldb] 6809af1 - Revert "[OpenMP][OMPIRBuilder] Move SIMD alignment calculation to LLVM Frontend"

Author: Dominik Adamski Date: 2023-01-13T14:38:17-06:00 New Revision: 6809af1a232bc5ac71358e4b874759ddaae056a1 URL: https://github.com/llvm/llvm-project/commit/6809af1a232bc5ac71358e4b874759ddaae056a1 DIFF: https://github.com/llvm/llvm-project/commit/6809af1a232bc5ac71358e4b874759ddaae056a1.dif

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib updated this revision to Diff 489102. mib marked an inline comment as done. mib added a reviewer: jasonmolenda. mib added a comment. Address @bulbazord feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 Files: lldb/examples/python/

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

clayborg added a comment. In D68655#4045873 , @jasonmolenda wrote: > I know this is all moot because the dSYM-specific patch landed, but I am > curious about this part, > > In D68655#4045561 , @clayborg wrote: > >

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

clayborg added a comment. In D68655#4048009 , @jasonmolenda wrote: > In D68655#4047126 , @labath wrote: > >> In D68655#4045895 , @jasonmolenda >> wrote: >> >>> Both have to

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 updated this revision to Diff 489137. augusto2112 added a comment. Make Type constructor private Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141318/new/ https://reviews.llvm.org/D141318 Files: lldb/include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. @clayborg I went with your suggestion and made Type's constructor private, and any new Type created is automatically added to the TypeList. I think later on we should make TypeList keep a vector of unique pointers instead of shared ones. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord added a comment. Seems okay to me. @JDevlieghere How does this look to you? Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:34-37 +for section in image.section_infos: +if section.start

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:34-37 +for section in image.section_infos: +if section.start_addr and section.name

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

clayborg added a comment. New changes looks great, thanks for tackling this. Just a few comments that need to be updated and this will be good to go as long as the test suite passes just fine! In D141318#4052934 , @augusto2112 wrote: > @clayborg I wen

[Lldb-commits] [PATCH] D136928: [LLDB] Fix help text for "platform settings"

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sorry for the delay! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136928/new/ https://reviews.llvm.org/D136928 ___

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:453 +Status error; +if (!Symbols::DownloadObjectAndSymbolFile(module_spec, error, true) || +error.Fail() || The last argument here is `force_l

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

mib updated this revision to Diff 489151. mib marked an inline comment as not done. mib added a comment. Address @JDevlieghere comment: - Check is stdout is a tty to run in interactive mode - Remove extra return line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141658/new/ https://rev

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. You can remove one of the `-b` in the test to check the TTY stuff (it should be false when piping into FileCheck). Comment at: lldb/examples/python/crashlo

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib updated this revision to Diff 489152. mib added a comment. Only force symbol lookup for crashlog scripted process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 Files: lldb/examples/python/scripted_process/crashlog_scripted_process.py

[Lldb-commits] [lldb] b1f4f06 - [LLDB][LoongArch] Delete the s9 register alias definition

Author: Hui Li Date: 2023-01-14T09:22:14+08:00 New Revision: b1f4f06dede54627c546d0e7f21e7e72295f280b URL: https://github.com/llvm/llvm-project/commit/b1f4f06dede54627c546d0e7f21e7e72295f280b DIFF: https://github.com/llvm/llvm-project/commit/b1f4f06dede54627c546d0e7f21e7e72295f280b.diff LOG: [

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f4f06dede5: [LLDB][LoongArch] Delete the s9 register alias definition (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] b7ae576 - [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

Author: Hui Li Date: 2023-01-14T09:22:18+08:00 New Revision: b7ae5762a110ee7c28b218b4ed4e3e24b2b3c64d URL: https://github.com/llvm/llvm-project/commit/b7ae5762a110ee7c28b218b4ed4e3e24b2b3c64d DIFF: https://github.com/llvm/llvm-project/commit/b7ae5762a110ee7c28b218b4ed4e3e24b2b3c64d.diff LOG: [

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7ae5762a110: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT