JDevlieghere added inline comments.

================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:453
+    Status error;
+    if (!Symbols::DownloadObjectAndSymbolFile(module_spec, error, true) ||
+        error.Fail() ||
----------------
The last argument here is `force_lookup` (you should probably add that as an 
inline comment). This means that for any scripted process (not just interactive 
crashlogs) we're going to do a dSYMForUUID call (like we do for loading a 
kernel). I suppose that's what you want for interactive crashlogs, but not for 
a generic scripted process implementation. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141702/new/

https://reviews.llvm.org/D141702

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to