[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:33 + +processes = { +420: { bulbazord wrote: > JDevlieghere wrote: > > Why is this method implemented and n

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 added a comment. In D139833#3990635 , @SixWeining wrote: > 1. Does the directory `lldb/source/Plugins/Instruction/LoongArch/` target > both `LoongArch64` and `LoongArch32`? Yes, both LoongArch64 and LoongArch32 are supported in EmulateInstr

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:205 +bool EmulateInstructionLoongArch::EmulateBEQZ(uint32_t inst) { + uint64_t next_pc, imm_sign_extend; + bool success = false; SixWeining

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 updated this revision to Diff 482790. lh03061238 edited the summary of this revision. lh03061238 added a comment. (1) distinguish between LoongArch64 and LoongArch32 operations in EmulateInstructionLoongArch (2) check the return values of some functions CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille updated this revision to Diff 482825. serge-sans-paille added a comment. Make `Prefixes` an array of StringRef too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139881/new/ https://reviews.llvm.org/D139881 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille marked 4 inline comments as done. serge-sans-paille added a comment. New version passes `ninja check` with clang, clang-tools-extra and lld. Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39 ento::CallDescription::CallDescription(CallDescriptio

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch makes the members of `Templat

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2067 +if (name && !name[0]) + name = nullptr; I wish we had

[Lldb-commits] [PATCH] D140032: [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV

Emmmer updated this revision to Diff 482900. Emmmer added a comment. Herald added a subscriber: lldb-commits. Updating D140032 : [LLDB][RISCV] Add RVD instruction support for EmulateInstructionRISCV Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere added a comment. Last week I debugged this further. Here's what I believe is going on. Consider the following simplified example with two CUs and a type `Foo`. 0x01: DW_TAG_compile_unit 0x02: DW_TAG_class_type DW_AT_containing_type (0x11) DW_AT_name

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. In D139955#3992766 , @JDevlieghere wrote: > I don't really understand the motivation. Can you elaborate on why "enabling > 64 bit support" requires this change? I definitely prefer the `formatv` > approach, but wouldn't the PR

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

steven_wu added a comment. The workaround in https://reviews.llvm.org/D139956 can get llvm-project bootstrap correctly, doesn't fix the underlying issue. The new failures is in building `SupportTests` where it issues a weird warning followed by missing symbol. It might be related to this commit

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a subscriber: inglorion. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Make the lldb test target depend on LTO

[Lldb-commits] [PATCH] D140056: [lldb] Report clang module builds remarks

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update the Clang diagnostic consumer (in ClangModulesDeclVe

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere updated this revision to Diff 483018. JDevlieghere added a comment. Revert to old naming CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 Files: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h llvm/lib/DWARFLinker/DWARFL

[Lldb-commits] [PATCH] D140066: Add a final fallback technique to the old Darwin dynamic loader plugin to find the dyld_all_image_infos structure

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When lldb is running on a userland corefile (the only case wher

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

jasonmolenda created this revision. jasonmolenda added reviewers: aprantl, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In https://re

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2067 +if (name && !name[0]) + name = nullptr; aprantl wrote: > I wish we had a lazy version of StringRef that computes the length only on

[Lldb-commits] [PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

rastogishubham updated this revision to Diff 483042. rastogishubham added a comment. Herald added subscribers: Michael137, JDevlieghere. I was not able to land this patch earlier because of some bot failures and then I got busy with some other stuff, this is just an update of the patch with merg

[Lldb-commits] [PATCH] D140067: Fix an ASAN bug I introduced in debugserver, accessing off the end of an array intentionally

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp:2026-2037 +if (reg == gpr_pc) + value->value.uint64 = clear_pac_bits( + reinterpret_cast(m_state.context.gpr.__opaque_pc)); +else

[Lldb-commits] [lldb] 7dde942 - Remove the dependency between lib/DebugInfoDWARF and MC.

Author: Shubham Sandeep Rastogi Date: 2022-12-14T18:16:46-08:00 New Revision: 7dde94251e1c9e4634f5d51d41f2d4a191258fb3 URL: https://github.com/llvm/llvm-project/commit/7dde94251e1c9e4634f5d51d41f2d4a191258fb3 DIFF: https://github.com/llvm/llvm-project/commit/7dde94251e1c9e4634f5d51d41f2d4a19125

[Lldb-commits] [lldb] 4283cfd - Revert "Remove the dependency between lib/DebugInfoDWARF and MC."

Author: Shubham Sandeep Rastogi Date: 2022-12-14T18:32:18-08:00 New Revision: 4283cfdc1116725d951660a01104cf4cd98e8453 URL: https://github.com/llvm/llvm-project/commit/4283cfdc1116725d951660a01104cf4cd98e8453 DIFF: https://github.com/llvm/llvm-project/commit/4283cfdc1116725d951660a01104cf4cd98e

[Lldb-commits] [lldb] 230df79 - [lldb] Use llvm::transformOptional (NFC)

Author: Kazu Hirata Date: 2022-12-14T18:36:49-08:00 New Revision: 230df792e17519071a9ef4dc0fb10132540dfbb8 URL: https://github.com/llvm/llvm-project/commit/230df792e17519071a9ef4dc0fb10132540dfbb8 DIFF: https://github.com/llvm/llvm-project/commit/230df792e17519071a9ef4dc0fb10132540dfbb8.diff L

[Lldb-commits] [lldb] 2a0829d - [lldb][Test] TestRerunAndExpr.py: explicitly delete a.out before rebuilding it

Author: Michael Buch Date: 2022-12-15T04:05:39Z New Revision: 2a0829d83fc6d1701940ad9f429b6ae47009f369 URL: https://github.com/llvm/llvm-project/commit/2a0829d83fc6d1701940ad9f429b6ae47009f369 DIFF: https://github.com/llvm/llvm-project/commit/2a0829d83fc6d1701940ad9f429b6ae47009f369.diff LOG: