[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

DavidSpickett accepted this revision. DavidSpickett added a comment. This LGTM. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:58 + uint32_t reg_num) override; + lldb::addr_t ReadPC(bool *succe

[Lldb-commits] [lldb] 3a9e07b - [LLDB][LoongArch] Make software single stepping work

Author: Weining Lu Date: 2022-12-08T19:06:07+08:00 New Revision: 3a9e07b1e7f4718a0e117f3a732f1679c4bf2e30 URL: https://github.com/llvm/llvm-project/commit/3a9e07b1e7f4718a0e117f3a732f1679c4bf2e30 DIFF: https://github.com/llvm/llvm-project/commit/3a9e07b1e7f4718a0e117f3a732f1679c4bf2e30.diff LO

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a9e07b1e7f4: [LLDB][LoongArch] Make software single stepping work (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139158/new/ https

[Lldb-commits] [lldb] 2bfef8d - Revert "[LLDB][LoongArch] Make software single stepping work"

Author: Weining Lu Date: 2022-12-08T19:56:58+08:00 New Revision: 2bfef8d5370fbe9d500441b2e1e3fe4a4d68deec URL: https://github.com/llvm/llvm-project/commit/2bfef8d5370fbe9d500441b2e1e3fe4a4d68deec DIFF: https://github.com/llvm/llvm-project/commit/2bfef8d5370fbe9d500441b2e1e3fe4a4d68deec.diff LO

[Lldb-commits] [lldb] f0f3395 - [LLDB][LoongArch] Make software single stepping work

Author: Hui Li Date: 2022-12-08T19:59:39+08:00 New Revision: f0f33957d03444eefc8264cbfe7f5cfe7bee6f3d URL: https://github.com/llvm/llvm-project/commit/f0f33957d03444eefc8264cbfe7f5cfe7bee6f3d DIFF: https://github.com/llvm/llvm-project/commit/f0f33957d03444eefc8264cbfe7f5cfe7bee6f3d.diff LOG: [

[Lldb-commits] [PATCH] D139643: [lldb][Test] TestRerunAndExpr.py: explicitly delete a.out before rebuilding it

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** Older versions of `make` would occasionally fail to realize that a

[Lldb-commits] [PATCH] D139643: [lldb][Test] TestRerunAndExpr.py: explicitly delete a.out before rebuilding it

Michael137 updated this revision to Diff 481324. Michael137 added a comment. Herald added a subscriber: JDevlieghere. - Reword comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139643/new/ https://reviews.llvm.org/D139643 Files: lldb/test/AP

[Lldb-commits] [lldb] ad3870d - [lldb][Test] TestRerunAndExpr.py: explicitly delete a.out before rebuilding it

Author: Michael Buch Date: 2022-12-08T17:17:05Z New Revision: ad3870d6552305d2d6bd6aa2faca6f0644052d9a URL: https://github.com/llvm/llvm-project/commit/ad3870d6552305d2d6bd6aa2faca6f0644052d9a DIFF: https://github.com/llvm/llvm-project/commit/ad3870d6552305d2d6bd6aa2faca6f0644052d9a.diff LOG:

[Lldb-commits] [PATCH] D139643: [lldb][Test] TestRerunAndExpr.py: explicitly delete a.out before rebuilding it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad3870d65523: [lldb][Test] TestRerunAndExpr.py: explicitly delete a.out before rebuilding it (authored by Michael137). Repository: rG LLVM Github

[Lldb-commits] [lldb] c0ac25f - [lldb] Fix simple template names interaction with debug info declarations

Author: Arthur Eubanks Date: 2022-12-08T09:40:43-08:00 New Revision: c0ac25f1acc4dae97f420cd6bdf1c00c632563f1 URL: https://github.com/llvm/llvm-project/commit/c0ac25f1acc4dae97f420cd6bdf1c00c632563f1 DIFF: https://github.com/llvm/llvm-project/commit/c0ac25f1acc4dae97f420cd6bdf1c00c632563f1.diff

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0ac25f1acc4: [lldb] Fix simple template names interaction with debug info declarations (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This factors out the check from various callers. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[Lldb-commits] [PATCH] D139674: Fix ValueObject::GetAddressOf for subclasses using ValueObjectConstResultImpl backends

jingham created this revision. jingham added reviewers: Michael137, JDevlieghere, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The original code always set the m_live_address of children of th

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

dblaikie added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251 + if (has_template_params && + ParseTemplateParameterInfos(die, template_param_infos)) { +template_function_decl = m_ast.CreateFunctionD

[Lldb-commits] [PATCH] D139649: [lldb] Make ParseTemplateParameterInfos return false if there are no template params

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1251 + if (has_template_params && + ParseTemplateParameterInfos(die, template_param_infos)) { +template_function_decl = m_ast.CreateFunctionD

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

jingham added a comment. You need documentation for what the name & scripted metadata do here somewhere. In SBPlatform.i so that it goes into the SB API docs is one good place. Also maybe in the Platform.h where it gets passed to Create or something. Other than that, LGTM... ==

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

clayborg added a comment. @aprantl can you check this latest patch and accept again if you like what you see? All tests passed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137900/new/ https://reviews.llvm.org/D137900 ___

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This makes sense. I think you should at least log if you can't read the memory dyld told you was where the image info should be. Seems like this is the sort of thing that shouldn't happen,

[Lldb-commits] [lldb] 23f145d - [NFC] Fix leak in command options configuration.

Author: Jordan Rupprecht Date: 2022-12-08T16:37:43-08:00 New Revision: 23f145daa50c3f51a7fb8c8d68c55e5f4a8027c2 URL: https://github.com/llvm/llvm-project/commit/23f145daa50c3f51a7fb8c8d68c55e5f4a8027c2 DIFF: https://github.com/llvm/llvm-project/commit/23f145daa50c3f51a7fb8c8d68c55e5f4a8027c2.di

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Type.h:101 + /// Users will need to call one of the SetMatchContext() functions prior to + /// doing name lookups. + TypeQuery() = delete; this comment is out o

[Lldb-commits] [lldb] 28b869d - [NFC] Fix leak handling breakpoint names.

Author: Jordan Rupprecht Date: 2022-12-08T17:14:38-08:00 New Revision: 28b869d8724207bd7fd8b80f57f6c02abe4bc607 URL: https://github.com/llvm/llvm-project/commit/28b869d8724207bd7fd8b80f57f6c02abe4bc607 DIFF: https://github.com/llvm/llvm-project/commit/28b869d8724207bd7fd8b80f57f6c02abe4bc607.di

[Lldb-commits] [PATCH] D139684: Switch the "command script add" interactive editor to use the exe_ctx interface

jingham created this revision. jingham added reviewers: mib, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We're suggesting people use the form of the command that takes an exe_ctx - it i

[Lldb-commits] [lldb] f9d8090 - Improve error handling for invalid breakpoint `-t` and `-x` options.

Author: Jordan Rupprecht Date: 2022-12-08T17:53:54-08:00 New Revision: f9d8090a90a1f1f9ddf6aebb82e7fc4c1dbcf030 URL: https://github.com/llvm/llvm-project/commit/f9d8090a90a1f1f9ddf6aebb82e7fc4c1dbcf030 DIFF: https://github.com/llvm/llvm-project/commit/f9d8090a90a1f1f9ddf6aebb82e7fc4c1dbcf030.di