jingham added a comment. You need documentation for what the name & scripted metadata do here somewhere. In SBPlatform.i so that it goes into the SB API docs is one good place. Also maybe in the Platform.h where it gets passed to Create or something.
Other than that, LGTM... ================ Comment at: lldb/source/API/SBPlatform.cpp:305 + + if (!dict.IsValid() || !dict.m_impl_up) + return; ---------------- Do you need to check `script_name != nullptr` here as well as checking the dict? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139249/new/ https://reviews.llvm.org/D139249 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
