[Lldb-commits] [PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

rymiel added inline comments. Comment at: clang/include/clang/Frontend/DiagnosticRenderer.h:130 /// \param Message The diagnostic message to emit. + /// \param Reason Supplementary information for the message. /// \param Ranges The underlined ranges for this code snippet.

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

avogelsgesang added a subscriber: jasonmolenda. avogelsgesang added a comment. As discussed via email, the reason for the test failures on green dragon is, that green dragon seems to be using some compiler which passes the test if not (is_clang and self.expectedCompilerVersion(["<", "16"])):

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang added a comment. The issue with this change was that if devirtualization is failing, then in the line lldb::ValueObjectSP promise = CreateValueObjectFromAddress( "promise", frame_ptr_addr + 2 * ptr_size, exe_ctx, promise_type); the `promise_type` is `void`. Creating an o

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added inline comments. Comment at: lldb/source/Target/Target.cpp:207 +// E.g., this could happen on rebuild & relaunch +// of the debugee. +m_scratch_type_system_map.Clear(); aprantl wrote: > Not opposed to this, but this is leaking an impl

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 updated this revision to Diff 478929. Michael137 added a comment. - Move short definitions inline - Fix doxygen comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/ https://reviews.llvm.org/D138558 Files: lldb/source/Plug

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:41 +private: + lldb::ValueObjectSP m_range_sp = nullptr; ///< Pointer to the dereferenced +

[Lldb-commits] [lldb] 77b2205 - [lldb][DataFormatter] Add std::ranges::ref_view formatter

Author: Michael Buch Date: 2022-11-30T14:39:39Z New Revision: 77b220524541a9c29a6b50caa9f65addffeb37ba URL: https://github.com/llvm/llvm-project/commit/77b220524541a9c29a6b50caa9f65addffeb37ba DIFF: https://github.com/llvm/llvm-project/commit/77b220524541a9c29a6b50caa9f65addffeb37ba.diff LOG:

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG77b220524541: [lldb][DataFormatter] Add std::ranges::ref_view formatter (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138558/new/

[Lldb-commits] [PATCH] D138271: Fix license header in TraceHTR.h

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Looks obviously correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138271/new/ https://reviews.llvm.org/D138271 ___

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added inline comments. Comment at: lldb/source/Target/Target.cpp:207 +// E.g., this could happen on rebuild & relaunch +// of the debugee. +m_scratch_type_system_map.Clear(); Michael137 wrote: > aprantl wrote: > > Not opposed to this, but t

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added inline comments. Comment at: lldb/source/Target/Target.cpp:208 +// of the debugee. +m_scratch_type_system_map.Clear(); m_process_sp.reset(); Michael137 wrote: > kastiglione wrote: > > Do we have some place in the life-cycle where we

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

aprantl added a comment. In D132735#3959530 , @avogelsgesang wrote: > As discussed via email, the reason for the test failures on green dragon is, > that green dragon seems to be using some compiler which passes the test > > if not (is_clang and self.

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

aprantl added inline comments. Comment at: lldb/source/Target/Target.cpp:208 +// of the debugee. +m_scratch_type_system_map.Clear(); m_process_sp.reset(); Michael137 wrote: > Michael137 wrote: > > kastiglione wrote: > > > Do we have some place in the

[Lldb-commits] [PATCH] D138558: [lldb][DataFormatter] Add std::ranges::ref_view formatter

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxRangesRefView.cpp:36 + lldb::ValueObjectSP GetChildAtIndex(size_t idx) override { +// Since we only have a single child, return it +assert(idx == 0); To be very nitpi

[Lldb-commits] [PATCH] D138960: [lldb] Enable use of dummy target from dwim-print

kastiglione updated this revision to Diff 479035. kastiglione added a comment. Add docstring to new test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138960/new/ https://reviews.llvm.org/D138960 Files: lldb/source/Commands/CommandObjec

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] b5467ec - [lldb] Use LLDB_ENABLE_SWIG as the canonical CMake variable

Author: Jonas Devlieghere Date: 2022-11-30T12:46:13-08:00 New Revision: b5467ecc0f3b22082023e99412d4148ac41530be URL: https://github.com/llvm/llvm-project/commit/b5467ecc0f3b22082023e99412d4148ac41530be DIFF: https://github.com/llvm/llvm-project/commit/b5467ecc0f3b22082023e99412d4148ac41530be.d

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 updated this revision to Diff 479052. Michael137 added a comment. - Clear TypeSystem in notification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724 Files: lldb/include/lldb/Core/ModuleList.h

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

Michael137 added inline comments. Comment at: lldb/source/Target/Target.cpp:208 +// of the debugee. +m_scratch_type_system_map.Clear(); m_process_sp.reset(); aprantl wrote: > Michael137 wrote: > > Michael137 wrote: > > > kastiglione wrote: > > > > Do

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

rupprecht added a comment. I plan to land this now so we can remove this from our internal test exclusion list, but I'd be happy to address any post-commit feedback from other reviewers as a followup change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 479056. aeubanks added a comment. go back to calling m_index->GetTypes(DWARFDeclContext) instead of m_index->GetTypes(StringRef) these have different codepaths, I mistakenly thought they were equivalent Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks added a comment. I borrowed a mac and verified that this patch fixes the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 ___ lldb-commits mailing

[Lldb-commits] [lldb] 3c51ea3 - [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

Author: Jordan Rupprecht Date: 2022-11-30T13:20:13-08:00 New Revision: 3c51ea3619e488db19cd26840ed46d58cfc7062f URL: https://github.com/llvm/llvm-project/commit/3c51ea3619e488db19cd26840ed46d58cfc7062f DIFF: https://github.com/llvm/llvm-project/commit/3c51ea3619e488db19cd26840ed46d58cfc7062f.di

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c51ea3619e4: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZAT… (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] 61aed52 - [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

Author: Arthur Eubanks Date: 2022-11-30T13:20:23-08:00 New Revision: 61aed52c9ec0bca9979922ed2762785ec1f39755 URL: https://github.com/llvm/llvm-project/commit/61aed52c9ec0bca9979922ed2762785ec1f39755 DIFF: https://github.com/llvm/llvm-project/commit/61aed52c9ec0bca9979922ed2762785ec1f39755.diff

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61aed52c9ec0: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE (authored by aeubanks). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks updated this revision to Diff 479061. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/ https://reviews.llvm.org/D138834 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h lldb/source

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

kastiglione added inline comments. Comment at: lldb/source/Core/ModuleList.cpp:1080 + bool ret = true; + ForEach([&](const ModuleSP &module_sp) { +ret &= callback(module_sp); I wonder why ForEach doesn't deal out a `Module &`? I would think a ModuleList sh

[Lldb-commits] [lldb] 7a63907 - Add a log message to the IR interpreter.

Author: Adrian Prantl Date: 2022-11-30T14:08:14-08:00 New Revision: 7a63907021344b3aed322cd86bfa09678653e5dc URL: https://github.com/llvm/llvm-project/commit/7a63907021344b3aed322cd86bfa09678653e5dc DIFF: https://github.com/llvm/llvm-project/commit/7a63907021344b3aed322cd86bfa09678653e5dc.diff

[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. When you are

[Lldb-commits] [PATCH] D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This doesn't seem to be necessary anymore so remove it to be more consistent with rest of the LLVM projects that don't use

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:10 +#include "lldb/Host/macosx/HostInfoMacOSX.h" +#include "Utility/UuidCompatibility.h" #inclu

[Lldb-commits] [PATCH] D139061: [lldb] Fix the `dwarf` log descriptions

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139061 Files: lldb/source/Plugins/SymbolFile/DWARF/LogCh

[Lldb-commits] [PATCH] D139054: Delay calling ObjC class list read utility functions very early in process startup

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2519-2520 + case SharedCacheWarningReason::eExpressionUnableToRun: +Debugger::ReportWarning("Objective-C class names could not be read " +

[Lldb-commits] [PATCH] D139061: [lldb] Fix the `dwarf` log descriptions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/SymbolFile/DWARF/LogChannelDWARF.cpp:15 {{"comp"}, - {"log insertions of object files into DWARF debug maps"}, +

[Lldb-commits] [PATCH] D139058: [lldb/unittests/CMakeLists.txt] Remove extra compiler flag `-include gtest_common.h`, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139058/new/ https://reviews.llvm.org/D139058 ___

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

aprantl added a comment. I think I'm fine with this variant modulo outstanding comments! Comment at: lldb/source/Core/ModuleList.cpp:1080 + bool ret = true; + ForEach([&](const ModuleSP &module_sp) { +ret &= callback(module_sp); kastiglione wrote: > I won

[Lldb-commits] [PATCH] D138878: [lldb] Remove timer from Module::GetNumCompileUnits

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138878/new/ https://reviews.llvm.org/D138878 ___

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139066 Files: lldb/include/lldb/lldb-enumerations.h ll

[Lldb-commits] [PATCH] D139066: [lldb] Make sure the value of `eSymbolContextVariable` is not conflicting with `RESOLVED_FRAME_CODE_ADDR`

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I *think* this is what the code intended, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139066/new/ https://reviews.llvm.org/D139066 ___

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. In D138618#3948707 , @labath wrote: > I am puzzled by the OSO changes in the DIERef class. How do they tie in with > the increase in the offset size? It seems like it should at best be a > separate patch... I have been helping

[Lldb-commits] [lldb] fc743f0 - Report which modules have forcefully completed types in statistics.

Author: Greg Clayton Date: 2022-11-30T21:22:27-08:00 New Revision: fc743f034a34d3fa0a6e4de3b34216e5ac5e4c93 URL: https://github.com/llvm/llvm-project/commit/fc743f034a34d3fa0a6e4de3b34216e5ac5e4c93 DIFF: https://github.com/llvm/llvm-project/commit/fc743f034a34d3fa0a6e4de3b34216e5ac5e4c93.diff

[Lldb-commits] [PATCH] D138638: Report which modules have forcefully completed types in statistics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc743f034a34: Report which modules have forcefully completed types in statistics. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13863

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

clayborg added inline comments. Comment at: lldb/include/lldb/Core/Module.h:435 + /// match: "b::a", "c::b::a", "d::b::a", "e::f::b::a". + lldb::TypeSP FindFirstType(ConstString type_name, bool exact_match); aprantl wrote: > Why is this not taking a TypeQue

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. In D138259#3947410 , @mstorsjo wrote: > This seems to have caused build errors with GCC: > > ../tools/lldb/source/Symbol/CompilerType.cpp: In member function ‘bool > lldb_private::CompilerType::IsForcefullyCompleted() const’: