clayborg added a comment. In D138618#3948707 <https://reviews.llvm.org/D138618#3948707>, @labath wrote:
> I am puzzled by the OSO changes in the DIERef class. How do they tie in with > the increase in the offset size? It seems like it should at best be a > separate patch... I have been helping Alexander get this patch ready for open source. We needed to do these changes or this patch doesn't work and would break mac debugging. The reason is some people were manually creating lldb::user_id_t IDs and then manually decoding them. If we change the DIE offset size, then the people that were manually creating user_id_t would now be encoding bits into the wrong bits if they were every put into a DIERef we would extract the wrong information. Part of what this patch is doing is allowing a DIERef to get a user_id_t from the object and also create itself from a user_id_t. This allows a single consistent interface. No one should be manually encoding user_id_t values now, and it should always be done through DIERef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
