DavidSpickett added inline comments.
Comment at: clang/include/clang/AST/ExprCXX.h:733
+ static CXXBoolLiteralExpr *Create(const ASTContext &C, bool Val, QualType Ty,
+SourceLocation Loc) {
shafik wrote:
> I think this makes
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa9ffb4734535: Fix LLDB build on old Linux kernels (pre-4.1)
(authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133778/new/
https://r
Author: David Spickett
Date: 2022-10-05T08:00:05Z
New Revision: a9ffb473453519bae158e5d9c72431aa0f6aac2b
URL:
https://github.com/llvm/llvm-project/commit/a9ffb473453519bae158e5d9c72431aa0f6aac2b
DIFF:
https://github.com/llvm/llvm-project/commit/a9ffb473453519bae158e5d9c72431aa0f6aac2b.diff
LOG
DavidSpickett added a comment.
I've landed this so it has some time to go through bots before a backport to 15.
Apologies that your name isn't in the commit, I did add an author line locally
but Arc decided to remove it before landing.
If you do more fixes (and please do) get commit access your
DavidSpickett updated this revision to Diff 465341.
DavidSpickett added a comment.
Rebase, Create moved to parent change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135169/new/
https://reviews.llvm.org/D135169
Files:
lldb/include/lldb/Symbol/
DavidSpickett updated this revision to Diff 465342.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135170/new/
https://reviews.llvm.org/D135170
Files:
clang/lib/AST/StmtPrinter.cpp
lldb/test/API/lang/cpp/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0dcbb9b026a: [LLDB][RISCV][NFC] Rewrite instruction in
algebraic datatype (authored by Emmmer).
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Author: Emmmer
Date: 2022-10-05T19:45:28+08:00
New Revision: d0dcbb9b026af47378ad0603a45663fad9d8e9c2
URL:
https://github.com/llvm/llvm-project/commit/d0dcbb9b026af47378ad0603a45663fad9d8e9c2
DIFF:
https://github.com/llvm/llvm-project/commit/d0dcbb9b026af47378ad0603a45663fad9d8e9c2.diff
LOG: [
aaron.ballman added a comment.
Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in
from someone on the LLVM side of things; lldb would be nice as well).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134878/new/
https://reviews.llvm.org/D134878
_
dblaikie added inline comments.
Herald added a subscriber: JDevlieghere.
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:230-231
-DEBUG_INFO_FLAG ?= -g
+# DO NOT SUBMIT
+DEBUG_INFO_FLAG ?= -g -gsimple-template-names
Oh, nifty place to test
mib created this revision.
mib added a reviewer: kastiglione.
mib added a project: LLDB.
Herald added subscribers: JDevlieghere, kristof.beyls.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch adds support for 32bit stack frame
mib updated this revision to Diff 465522.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135310/new/
https://reviews.llvm.org/D135310
Files:
lldb/examples/python/crashlog.py
Index: lldb/examples/python/crashlog.py
===
---
kastiglione added a comment.
looks good
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135310/new/
https://reviews.llvm.org/D135310
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
jgorbe added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134771/new/
https://reviews.llvm.org/D134771
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1550
+ if (die.IsValid()) {
+auto get_template_params_string = [this](DWARFDIE die) {
+ if (llvm::StringRef(die.GetName()).contains("<"))
-
zequanwu updated this revision to Diff 465565.
zequanwu marked an inline comment as done.
zequanwu added a comment.
Updated to handle the nested anonymous union and struct situation.
It's done by:
1. Create the record layout with `Field` which could be a field member or an
anonymous struct or an
Michael137 added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2480
+ // templates parameters, try again with the template parameters stripped
since
+ // with simplified template names the DT_name may only contain the base name.
+ if (t
JDevlieghere added a comment.
I'm not sure I understand how the test is exercising the application specific
backtrace. I don't see any of the frames or the crash reason in there. What am
I missing?
Comment at: lldb/examples/python/crashlog.py:581-597
+def parse_asi_ba
aeubanks updated this revision to Diff 465586.
aeubanks marked 5 inline comments as done.
aeubanks added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134378/new/
https://reviews.llvm.org/D134378
Files:
lldb/packages/
aeubanks added inline comments.
Comment at:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1558-1560
+if (template_param_infos.hasParameterPack()) {
+ args = template_param_infos.packed_args->args;
+}
dblaikie w
shafik accepted this revision.
shafik added a comment.
LGTM
Comment at: lldb/test/API/lang/cpp/const_static_integral_member/main.cpp:39
const static auto char_min = std::numeric_limits::min();
const static auto uchar_min = std::numeric_limits::min();
We
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135310/new/
https://reviews.llvm.org/D135310
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
22 matches
Mail list logo
