Michael137 added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1550
+ if (die.IsValid()) {
+ auto get_template_params_string = [this](DWARFDIE die) {
+ if (llvm::StringRef(die.GetName()).contains("<"))
----------------
Any thoughts on making this a `private` method of `DWARFASTParserClang` instead
of a lambda?
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1585
+ DWARFDIE parent_decl_ctx_die = die.GetParentDeclContextDIE();
+ // TODO: change this to get the correct decl context parent....
+ while (parent_decl_ctx_die) {
----------------
dblaikie wrote:
> What's incorrect about it at the moment?
>
> Oh, I see this code has just moved around.
Why move this into `ParseStructureLikeDIE`? Just to remove the need for a
mutable `std::string&` param? I guess access to `die`? Might be easier to
review (and maintain) as a helper function still
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134378/new/
https://reviews.llvm.org/D134378
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
