[Lldb-commits] [PATCH] D131693: [lldb][Breakpoint] Prevent crash when resolving regex breakpoint on functions with asm declaration

Michael137 updated this revision to Diff 452098. Michael137 added a comment. - Skip Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131693/new/ https://reviews.llvm.org/D131693 Files: lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

ilya-biryukov added a comment. In D112374#3716982 , @mizvekov wrote: > We even match GCC now: https://gcc.godbolt.org/z/WT93WdE7e > > Ie we are printing the function type as-written correctly now. We don't match GCC in other cases. GCC seems to always pr

[Lldb-commits] [lldb] 9ba71d0 - [lldb] [gdb-remote] Remove unimplemented ProcessIDIsValid() (NFC)

Author: Michał Górny Date: 2022-08-12T11:17:15+02:00 New Revision: 9ba71d03b0f0ec82b7f74ec52818236237680348 URL: https://github.com/llvm/llvm-project/commit/9ba71d03b0f0ec82b7f74ec52818236237680348 DIFF: https://github.com/llvm/llvm-project/commit/9ba71d03b0f0ec82b7f74ec52818236237680348.diff

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3718417 , @ilya-biryukov wrote: > We don't match GCC in other cases. GCC seems to always print the type name > without qualifiers, clang used to always print with qualifiers, but will now > print what was typed in t

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny created this revision. mgorny added reviewers: labath, jingham, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Try to always send vCont packets and include the PID in them if running multiprocess. This is

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

DavidSpickett created this revision. Herald added a subscriber: wenlei. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Not needed now that we require python 3. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added a comment. So one of the problems with constructing a more accurate AST is that we don't have enough information in DWARF to construct a unspecialised FunctionProtoType, i.e., `FunctionProtoType 0x1282fe870 'bool (T)'` as opposed to the current `FunctionProtoType 0x1282fe870 '_

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Not needed now that we require python 3. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1317

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett added a comment. Thanks for the review folks. I'll just wait for Jonas to confirm (probably not used downstream but no rush to land this). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131664/new/ https://reviews.llvm.org/D131664 __

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. thanks I had the same thought Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131772/new/ https://reviews.llvm.org/D131772

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131761/new/ https://reviews.llvm.org/D131761

[Lldb-commits] [PATCH] D131783: [LLDB][JIT] Set processor for ARM architecture

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett, granata.enrico. kpdev42 added a project: LLDB. Herald added subscribers: omjavaid, JDevlieghere, kristof.beyls. Herald added a project: All. kpdev42 requested review of this revision. Herald added a s

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131761/new/ https://reviews.llvm.org/D131761 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131772/new/ https://reviews.llvm.org/D131772 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D131741: [lldb] Skip target variable tests on Darwin because of chained fixups

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131741/new/ https://reviews.llvm.org/D131741 ___ lldb-commits mailing list

[Lldb-commits] [lldb] abe9599 - [lldb] Skip target variable tests on Darwin because of chained fixups

Author: Jonas Devlieghere Date: 2022-08-12T10:23:15-07:00 New Revision: abe9599f04f07baae46f4123d4c43d330f34df52 URL: https://github.com/llvm/llvm-project/commit/abe9599f04f07baae46f4123d4c43d330f34df52 DIFF: https://github.com/llvm/llvm-project/commit/abe9599f04f07baae46f4123d4c43d330f34df52.d

[Lldb-commits] [PATCH] D131741: [lldb] Skip target variable tests on Darwin because of chained fixups

This revision was automatically updated to reflect the committed changes. Closed by commit rGabe9599f04f0: [lldb] Skip target variable tests on Darwin because of chained fixups (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere. Herald added a subscriber: kristof.beyls. Herald added a project: All. fixathon edited the summary of this revision. fixathon published this revision for review. fixathon added a comment. Herald added a project: LLDB.

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoint.GetQueueName())) +self.assertEqual(queue1_thread.GetStopReason(), 3, +

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452267. cassanova added a comment. Use the enum name for the stop reason when asserting that the queues hit their breakpoints instead of just the raw number. Also, get the main thread from `run_to_name_breakpoint` instead of getting it from `get_threads_s

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

mib added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:204-206 +process_info = lldbutil.run_to_name_breakpoint(self, "stopper", only_one_thread=False) +main_thread = process_info[2] +queue_breakpoint = process_info[3] ---

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

clayborg added a comment. > However, even if that is corrected the test appears to be failing. > GetCompatibleArchs() in PlatformDarwin.cpp receives ArchSpec::kCore_invalid Can you set a breakpoint and see why an invalid core is being passed into this function? This shouldn't be happening IMHO

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452275. cassanova added a comment. All variables needed from `run_to_name_breakpoint` are obtained in one line rather than getting them by index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ htt

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:476-478 + if (event.has_tsc) { +tsc = event.tsc; +break; jj10306 wrote: > so is this inner loop what's a

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:204-206 +process_info = lldbutil.run_to_name_breakpoint(self, "stopper", only_one_thread=False) +main_thread = process_info[2] +queue_breakpoint = process_info[3] -

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

teemperor added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(), queue1.GetName())) +self.assertTrue(queu

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

mib accepted this revision. mib added a comment. LGTM with @teemperor feedback ! Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(),

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:131 + "The breakpoint was set for queue %s, but the breakpoint's queue name is %s" % (queue_breakpoint.GetQueueName(), queue1.GetName())) +self.assertTrue(queu

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452302. cassanova added a comment. Changed an `assertTrue` to `assertEqual`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 Files: lldb/test/API/macosx/queues/Te

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:440 +Expected> lldb_private::trace_intel_pt::SplitTraceInContinuousExecutions( +TraceIntelPT &trac

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. As mentioned in D113155 the difference in CPU type between `qHostInfo` and `qProcessInfo` is intentional. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

wallace updated this revision to Diff 452313. wallace marked an inline comment as done. wallace added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131630/new/ https://reviews.llvm.org/D131630 Files: lldb/include/lldb/Target/Tr

[Lldb-commits] [lldb] e17cae0 - [trace][intel pt] Fix per-psb packet decoding

Author: Walter Erquinigo Date: 2022-08-12T15:13:48-07:00 New Revision: e17cae076c4727b99017927c3e8746db5bec6db7 URL: https://github.com/llvm/llvm-project/commit/e17cae076c4727b99017927c3e8746db5bec6db7 DIFF: https://github.com/llvm/llvm-project/commit/e17cae076c4727b99017927c3e8746db5bec6db7.di

[Lldb-commits] [PATCH] D131630: [trace][intel pt] Fix per-psb packet decoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe17cae076c47: [trace][intel pt] Fix per-psb packet decoding (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with aed965d5

emrekultursay created this revision. Herald added a project: All. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The test is identical to API/lang/c/stepping/ except: 1. It uses C++ and thus needs demangling support 2. It us

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione updated this revision to Diff 452364. kastiglione added a comment. Use backend's type name to differentiate between unordered_{map,set} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 Files:

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione updated this revision to Diff 452365. kastiglione added a comment. Ignore the internal field name and use type names for conditions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 Files: lld

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione updated this revision to Diff 452366. kastiglione added a comment. Handle GetTypeName() returning strings both with and without std:: namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

kastiglione updated this revision to Diff 452367. kastiglione added a comment. fix comment grammar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 Files: lldb/source/Plugins/Language/CPlusPlus/LibCxxUno