wallace marked 4 inline comments as done.
wallace added inline comments.

================
Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:476-478
+      if (event.has_tsc) {
+        tsc = event.tsc;
+        break;
----------------
jj10306 wrote:
> so is this inner loop what's actually doing the work of getting to the next 
> PSB? is the assumption that if an event has a tsc then it's a PSB?
> Can you explain what the two different while loops are doing?
discussed offline. Every invocation to pt_qry_event will get a new PSB. the 
event loop is just for getting the first TSC.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131630/new/

https://reviews.llvm.org/D131630

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to