JDevlieghere updated this revision to Diff 413058.
JDevlieghere added a comment.
- Reduce flickering by not printing the last status message when the the
progress is complete
- Add `...` as suggested by Adrian offline
- Make ANSI (vt100) escape codes a requirement in order to show progress to
si
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:413-416
+if (!has_path && !has_uuid)
+ return error_with_message("Dictionary should have key 'path' or 'uuid'");
+if (!dict->HasKey("load_addr"))
+ return er
labath added a comment.
I like the feature, but why does it need to have a thread of it's own? Could
this be done from inside the regular event handler thread? The event handler
thread also prints to stdout, and it seems like a bad idea to have two threads
trying to do the same...
CHANGES SIN
mib added inline comments.
Comment at:
lldb/test/API/functionalities/scripted_process/stack_core_scripted_process.py:45
+
+lib_load_addr = 0x0001001e
+self.loaded_images.append({"path": self.lib_path,
JDevlieghere wrote:
> What exactly is
mib updated this revision to Diff 413079.
mib added a comment.
Address @JDevlieghere comments:
- Fix error message
- Use corefile module load address for scripted process module
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120969/new/
https://reviews.llvm.org/D120969
Files:
lldb/ex
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120969/new/
https://reviews.llvm.org/D120969
___
lldb-commits mailing list
wallace added a comment.
Thanks @davidca and @labath for chiming in.
@jj10306, please rename IntelPTManager to IntelPTCollector for clarity.
Comment at: lldb/docs/lldb-gdb-remote.txt:469
+//
+//tsc_rate: {
+// kind: "perf",
davidca wrote:
> why is all
JDevlieghere updated this revision to Diff 413108.
JDevlieghere added a comment.
- Move progress event handling in the regular event handler thread
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120972/new/
https://reviews.llvm.org/D120972
Files:
lldb/include/lldb/Core/Debugger.h
ll
JDevlieghere updated this revision to Diff 413110.
JDevlieghere added a comment.
- Unstage `lldb/include/lldb/Interpreter/CommandInterpreter.h`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120972/new/
https://reviews.llvm.org/D120972
Files:
lldb/include/lldb/Core/Debugger.h
lldb/
Author: Shafik Yaghmour
Date: 2022-03-04T12:50:25-08:00
New Revision: 9bd72b5c258549b8743557a79c7929de38f05a6d
URL:
https://github.com/llvm/llvm-project/commit/9bd72b5c258549b8743557a79c7929de38f05a6d
DIFF:
https://github.com/llvm/llvm-project/commit/9bd72b5c258549b8743557a79c7929de38f05a6d.dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9bd72b5c2585: [LLDB] Remove cases of using namespace std
(authored by shafik).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D12
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120961/new/
https://reviews.llvm.org/D120961
___
clayborg updated this revision to Diff 413115.
clayborg added a comment.
Added unit tests for CacheSignature that covers:
- making sure encoding fails when we have an invalid CacheSignature
- make sure decoding of older cache files that had a previously valid signature
fails when there is no UUI
Author: Zequan Wu
Date: 2022-03-04T13:06:15-08:00
New Revision: b31a1b4746c7c806bcc550e877577ec66ea407d9
URL:
https://github.com/llvm/llvm-project/commit/b31a1b4746c7c806bcc550e877577ec66ea407d9
DIFF:
https://github.com/llvm/llvm-project/commit/b31a1b4746c7c806bcc550e877577ec66ea407d9.diff
LOG
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb31a1b4746c7: [LLDB] Flush stream at the end of
PrintCommandOutput (authored by zequanwu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120961/new/
https:/
yinghuitan added inline comments.
Comment at: lldb/include/lldb/Core/DataFileCache.h:130-138
+ bool operator==(const CacheSignature &rhs) const {
if (m_uuid != rhs.m_uuid)
- return true;
+ return false;
if (m_mod_time != rhs.m_mod_time)
- return true;
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2a29c3f72e8d: [lldb/test] Re-enable TestEvents.py on Darwin
and fix crashes (authored by mib).
Herald added a project: All.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
Author: Med Ismail Bennani
Date: 2022-03-04T13:35:07-08:00
New Revision: 2a29c3f72e8d93385be83bd24a993c3bb57ac181
URL:
https://github.com/llvm/llvm-project/commit/2a29c3f72e8d93385be83bd24a993c3bb57ac181
DIFF:
https://github.com/llvm/llvm-project/commit/2a29c3f72e8d93385be83bd24a993c3bb57ac181.
Author: Med Ismail Bennani
Date: 2022-03-04T13:35:19-08:00
New Revision: 6eddd987c9c9d2ab76ed53eea452b34145992ed9
URL:
https://github.com/llvm/llvm-project/commit/6eddd987c9c9d2ab76ed53eea452b34145992ed9
DIFF:
https://github.com/llvm/llvm-project/commit/6eddd987c9c9d2ab76ed53eea452b34145992ed9.
Author: Med Ismail Bennani
Date: 2022-03-04T13:35:28-08:00
New Revision: 680ca7f21a7716698227966a9e70e7efb75cff7e
URL:
https://github.com/llvm/llvm-project/commit/680ca7f21a7716698227966a9e70e7efb75cff7e
DIFF:
https://github.com/llvm/llvm-project/commit/680ca7f21a7716698227966a9e70e7efb75cff7e.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG680ca7f21a77: [lldb/Plugins] Add ability to load modules to
Scripted Processes (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120969/new/
Author: Med Ismail Bennani
Date: 2022-03-04T13:36:36-08:00
New Revision: b934ed7dd6351404d375af2f996af8a49ea36c7b
URL:
https://github.com/llvm/llvm-project/commit/b934ed7dd6351404d375af2f996af8a49ea36c7b
DIFF:
https://github.com/llvm/llvm-project/commit/b934ed7dd6351404d375af2f996af8a49ea36c7b.
Author: Saleem Abdulrasool
Date: 2022-03-04T21:54:20Z
New Revision: b5491dd30792c1ad31bfc8e2f9d1809a79205234
URL:
https://github.com/llvm/llvm-project/commit/b5491dd30792c1ad31bfc8e2f9d1809a79205234
DIFF:
https://github.com/llvm/llvm-project/commit/b5491dd30792c1ad31bfc8e2f9d1809a79205234.diff
Author: Med Ismail Bennani
Date: 2022-03-04T14:56:20-08:00
New Revision: 86e6030ee8f8758f6e0807fc39a1aa0d8a03b68f
URL:
https://github.com/llvm/llvm-project/commit/86e6030ee8f8758f6e0807fc39a1aa0d8a03b68f
DIFF:
https://github.com/llvm/llvm-project/commit/86e6030ee8f8758f6e0807fc39a1aa0d8a03b68f.
aprantl added a comment.
This is pretty (and) awesome.
Comment at: lldb/source/Core/Debugger.cpp:1670
+if (event_type & Debugger::eBroadcastBitProgress)
+ HandleProgressEvent(event_sp);
}
side note: this function could benefi
aprantl added inline comments.
Comment at: lldb/source/Core/Debugger.cpp:1757
+ File &output = GetOutputFile();
+ if (!output.GetIsTerminalWithColors() || !GetShowProgress())
+return;
And withColors also implies that it's an interactive TTY?
CHANGES SINCE
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/source/Core/Debugger.cpp:1757
+ File &output = GetOutputFile();
+ if (!output.GetIsTerminalWithColors() || !GetShowProgress())
+return;
aprantl wrote:
> And
JDevlieghere updated this revision to Diff 413159.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
- Make sure the output is both interactive and supports colors
- Add more comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120972/new/
https://reviews.ll
JDevlieghere added inline comments.
Comment at: lldb/source/Core/Debugger.cpp:1757
+ File &output = GetOutputFile();
+ if (!output.GetIsTerminalWithColors() || !GetShowProgress())
+return;
JDevlieghere wrote:
> aprantl wrote:
> > And withColors also implies
Author: Med Ismail Bennani
Date: 2022-03-04T16:22:53-08:00
New Revision: 999e75476ec22ca50cc4c309d34424fa265e244a
URL:
https://github.com/llvm/llvm-project/commit/999e75476ec22ca50cc4c309d34424fa265e244a
DIFF:
https://github.com/llvm/llvm-project/commit/999e75476ec22ca50cc4c309d34424fa265e244a.
jingham created this revision.
jingham added reviewers: clayborg, labath, JDevlieghere.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
One of the diagnostic outputs for the expression parser is the jit
jingham added a comment.
I tried emitting an error when you go to write the file, but the way this is
layered this just comes out as a string somewhere in the middle of the
expression output, and ended up being noisy and confusing. I think it's better
to validate the value on input.
Reposito
mib created this revision.
mib added a reviewer: JDevlieghere.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch makes the crashlog interactive mode show the scripted process
status with the crashed sc
jingham updated this revision to Diff 413185.
jingham added a comment.
I added the if there's only one debugger hack, so this will work fine in the
driver.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121036/new/
https://reviews.llvm.org/D121036
Files:
lldb/include/lldb/Interpreter
34 matches
Mail list logo
