aprantl added a comment.
This is pretty (and) awesome.
================
Comment at: lldb/source/Core/Debugger.cpp:1670
+ if (event_type & Debugger::eBroadcastBitProgress)
+ HandleProgressEvent(event_sp);
}
----------------
side note: this function could benefit from some early exits.
================
Comment at: lldb/source/Core/Debugger.cpp:1762
+ if (data->GetCompleted()) {
+ output.Printf("\33[2K\r");
+ return;
----------------
I guess Colors also implies it supports \r? Sure.
Can you comment what this escape sequence does?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120972/new/
https://reviews.llvm.org/D120972
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
