[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

emrekultursay updated this revision to Diff 412621. emrekultursay added a comment. Reverted the changes to the header file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 Files: lldb/source/Core/DataFi

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

emrekultursay marked an inline comment as done. emrekultursay added a comment. Thanks. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ lldb-commits ma

[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:19 using namespace lldb; +using namespace dwarf; JDevlieghere wrote: > shafik wrote: > > JDevlieghere wrote: > > > Wouldn't it be more consistent to use `lldb_pr

[Lldb-commits] [lldb] 6b3b3ef - [lldb] Correct case in description of breakpoint --on-catch/throw

Author: David Spickett Date: 2022-03-03T10:06:11Z New Revision: 6b3b3ef344504334f43afe76c805d2e6e7b587e9 URL: https://github.com/llvm/llvm-project/commit/6b3b3ef344504334f43afe76c805d2e6e7b587e9 DIFF: https://github.com/llvm/llvm-project/commit/6b3b3ef344504334f43afe76c805d2e6e7b587e9.diff LOG

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

labath updated this revision to Diff 412643. labath marked 3 inline comments as done. labath added a comment. Address mgorny's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120320/new/ https://reviews.llvm.org/D120320 Files: lldb/packa

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM (but I cannot test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120320/new/ https://reviews.llvm.org/D120320 ___

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This ensures that the user is aware that many commands will not work correctly. We print the warning only once (per module) to

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

JDevlieghere accepted this revision. JDevlieghere added a comment. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120718/new/ https://reviews.llvm.org/D120718 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120718: Fix DataExtractor symbol conflict

This revision was automatically updated to reflect the committed changes. Closed by commit rG71e278805a72: [lldb] Fix DataExtractor symbol conflict (authored by emrekultursay, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D120718?vs=412621&id=412740#toc Reposito

[Lldb-commits] [lldb] 71e2788 - [lldb] Fix DataExtractor symbol conflict

Author: Emre Kultursay Date: 2022-03-03T08:48:16-08:00 New Revision: 71e278805a7232826f27be081d036ca3f1c85d65 URL: https://github.com/llvm/llvm-project/commit/71e278805a7232826f27be081d036ca3f1c85d65 DIFF: https://github.com/llvm/llvm-project/commit/71e278805a7232826f27be081d036ca3f1c85d65.diff

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. FWIW I'm planning some changes to the error reporting "soonish". The gist is using error/warning events which Xcode (or VSCode) can subscribe to. I'll send out an RFC with m

Re: [Lldb-commits] [lldb] 6b3b3ef - [lldb] Correct case in description of breakpoint --on-catch/throw

This was on purpose - I do it whenever the short option isn't the first letter of the long option as an aid to memorization. Some people catch this and it helps, others correct the spelling in checkins without noticing what they are for. I thought it was helpful, but maybe it only annoys peopl

[Lldb-commits] [lldb] 742fb13 - Revert "[lldb] Correct case in description of breakpoint --on-catch/throw"

Author: David Spickett Date: 2022-03-03T17:20:31Z New Revision: 742fb134753b62f827677be92c48699d02f7f458 URL: https://github.com/llvm/llvm-project/commit/742fb134753b62f827677be92c48699d02f7f458 DIFF: https://github.com/llvm/llvm-project/commit/742fb134753b62f827677be92c48699d02f7f458.diff LOG

Re: [Lldb-commits] [lldb] 6b3b3ef - [lldb] Correct case in description of breakpoint --on-catch/throw

My apologies. I see now, like a menu where it highlights the shortcut character. Reverted. First time I've noticed this, the hint seems more useful than the minor confusion at the case. On Thu, 3 Mar 2022 at 17:14, Jim Ingham wrote: > > This was on purpose - I do it whenever the short option isn

[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

shafik updated this revision to Diff 412751. shafik marked 6 inline comments as done. shafik added a comment. Moved to `using namespace lldb_private::dwarf` everywhere since the consensus is that being verbose is preferred. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120836/new/ http

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham created this revision. jingham added reviewers: labath, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I was trying to figure out a problem with how a client was seeing the breakp

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham added a comment. For instance, one of the other EventData types might want the events too, but only when the verbose flag for their relevant log channel is on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120917/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D120919: Reverse the order of modules-loaded/unloaded & breakpoint-changed events

jingham created this revision. jingham added reviewers: clayborg, JDevlieghere, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, when a new module is loaded/unloaded and it causes new b

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

kastiglione added inline comments. Comment at: lldb/source/Utility/Broadcaster.cpp:211-215 + Log *log = GetLog(LLDBLog::Events); + if (!log && event_sp->GetData()) +log = event_sp->GetData()->GetLogChannel(); + + if (log) { should this log to both channels

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

kastiglione added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1063-1065 + break_id_t bkpt_id = GetBreakpoint()->GetID(); + s->Format("bkpt: {0} type: {1}", bkpt_id, + BreakpointEventTypeAsCString(event_type)); For the location event

[Lldb-commits] [PATCH] D120919: Reverse the order of modules-loaded/unloaded & breakpoint-changed events

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lldb-vscode will be just fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120919/new/ https://reviews.llvm.org/D120919 _

[Lldb-commits] [lldb] ae869d4 - [LLDB] Remove cases of using namespace llvm:: from header file

Author: Shafik Yaghmour Date: 2022-03-03T10:39:06-08:00 New Revision: ae869d448499327a2e6435fafb0ac6ed0f205e66 URL: https://github.com/llvm/llvm-project/commit/ae869d448499327a2e6435fafb0ac6ed0f205e66 DIFF: https://github.com/llvm/llvm-project/commit/ae869d448499327a2e6435fafb0ac6ed0f205e66.dif

[Lldb-commits] [PATCH] D120836: [LLDB] Remove cases of using namespace llvm:: from header file

This revision was automatically updated to reflect the committed changes. Closed by commit rGae869d448499: [LLDB] Remove cases of using namespace llvm:: from header file (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath updated this revision to Diff 412774. labath added a comment. This code can be invoked concurrently (during indexing). Use atomic test-and-set to ensure correctness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.l

[Lldb-commits] [PATCH] D120923: [lldb] Remove FileSystem::Initialize from VFS mapping

JDevlieghere created this revision. JDevlieghere added reviewers: bnbarham, mib, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch removes the ability to instantiate the LLDB FileSystem class based on a VFS overlay. This also removes the "hack" where

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere added a comment. Might a `llvm::once_flag` + `llvm::call_once` be simpler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.llvm.org/D120892 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1063-1065 + break_id_t bkpt_id = GetBreakpoint()->GetID(); + s->Format("bkpt: {0} type: {1}", bkpt_id, + BreakpointEventTypeAsCString(event_type)); kastiglione wrote: > For th

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath added a comment. In D120892#3357424 , @JDevlieghere wrote: > FWIW I'm planning some changes to the error reporting "soonish". The gist is > using error/warning events which Xcode (or VSCode) can subscribe to. I'll > send out an RFC with more det

[Lldb-commits] [lldb] 59eb705 - [lldb] Remove FileSystem::Initialize from VFS mapping

Author: Jonas Devlieghere Date: 2022-03-03T11:02:11-08:00 New Revision: 59eb70527741594fe3c92d0a1b6704ed45111437 URL: https://github.com/llvm/llvm-project/commit/59eb70527741594fe3c92d0a1b6704ed45111437 DIFF: https://github.com/llvm/llvm-project/commit/59eb70527741594fe3c92d0a1b6704ed45111437.d

[Lldb-commits] [PATCH] D120923: [lldb] Remove FileSystem::Initialize from VFS mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rG59eb70527741: [lldb] Remove FileSystem::Initialize from VFS mapping (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

kastiglione accepted this revision. kastiglione added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/Broadcaster.cpp:211-215 + Log *log = GetLog(LLDBLog::Events); + if (!log && event_sp->GetData()) +log = event_sp->GetData(

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:84 static ConstString GetEventIdentifier(); + static const char * + BreakpointEventTypeAsCString(lldb::BreakpointEventType type); Why not a llvm::StringRef? Repos

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

labath added a comment. In D120892#3357780 , @JDevlieghere wrote: > Might a `llvm::once_flag` + `llvm::call_once` be simpler? Simpler... maybe.. depends how you look at it. But, synchronization-wise, it is overkill. once_flag ensures that none of the

[Lldb-commits] [PATCH] D120892: [lldb] Warn when we fail to find dwo/dwp files

JDevlieghere accepted this revision. JDevlieghere added a comment. Cool, thanks for the explanation. Ship it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120892/new/ https://reviews.llvm.org/D120892 __

[Lldb-commits] [lldb] 34eb15b - [lldb] Remove reproducer verifier and corresponding command

Author: Jonas Devlieghere Date: 2022-03-03T11:21:00-08:00 New Revision: 34eb15b5c30601085acb0921f5410aafc0389232 URL: https://github.com/llvm/llvm-project/commit/34eb15b5c30601085acb0921f5410aafc0389232 DIFF: https://github.com/llvm/llvm-project/commit/34eb15b5c30601085acb0921f5410aafc0389232.d

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

jingham added inline comments. Comment at: lldb/include/lldb/Breakpoint/Breakpoint.h:84 static ConstString GetEventIdentifier(); + static const char * + BreakpointEventTypeAsCString(lldb::BreakpointEventType type); JDevlieghere wrote: > Why not a llvm::S

[Lldb-commits] [lldb] 3f43818 - Fix up the "lldb log break" channel output.

Author: Jim Ingham Date: 2022-03-03T12:10:39-08:00 New Revision: 3f438185a68af4ca99d018d94f4732fd53433674 URL: https://github.com/llvm/llvm-project/commit/3f438185a68af4ca99d018d94f4732fd53433674 DIFF: https://github.com/llvm/llvm-project/commit/3f438185a68af4ca99d018d94f4732fd53433674.diff LO

[Lldb-commits] [PATCH] D120917: Make the breakpoint log channel more useful

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f438185a68a: Fix up the "lldb log break" channel output. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120917/new/ https://reviews.l

[Lldb-commits] [PATCH] D120919: Reverse the order of modules-loaded/unloaded & breakpoint-changed events

This revision was automatically updated to reflect the committed changes. Closed by commit rGc697a1f06b62: Fix the order of modules-loaded event and the resultant breakpoint-changed… (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] c697a1f - Fix the order of modules-loaded event and the resultant breakpoint-changed event.

Author: Jim Ingham Date: 2022-03-03T12:10:54-08:00 New Revision: c697a1f06b6240d62eec8890ac1314728906d707 URL: https://github.com/llvm/llvm-project/commit/c697a1f06b6240d62eec8890ac1314728906d707 DIFF: https://github.com/llvm/llvm-project/commit/c697a1f06b6240d62eec8890ac1314728906d707.diff LO

[Lldb-commits] [lldb] 8b3b66e - [lldb] Remove FileSystem::Initialize from FileCollector

Author: Jonas Devlieghere Date: 2022-03-03T13:22:38-08:00 New Revision: 8b3b66ea63d6469e5a3842627d538805173bda05 URL: https://github.com/llvm/llvm-project/commit/8b3b66ea63d6469e5a3842627d538805173bda05 DIFF: https://github.com/llvm/llvm-project/commit/8b3b66ea63d6469e5a3842627d538805173bda05.d

[Lldb-commits] [lldb] 4212a57 - [lldb] Remove reproducer_handler from the driver

Author: Jonas Devlieghere Date: 2022-03-03T13:22:39-08:00 New Revision: 4212a57a54d99c339c11448efda4991ea150b027 URL: https://github.com/llvm/llvm-project/commit/4212a57a54d99c339c11448efda4991ea150b027 DIFF: https://github.com/llvm/llvm-project/commit/4212a57a54d99c339c11448efda4991ea150b027.d

[Lldb-commits] [lldb] bf414cf - [lldb] Fix the build after 8b3b66ea63d6

Author: Jonas Devlieghere Date: 2022-03-03T13:57:33-08:00 New Revision: bf414cfbf70570eaba282ae0561324794269d2d1 URL: https://github.com/llvm/llvm-project/commit/bf414cfbf70570eaba282ae0561324794269d2d1 DIFF: https://github.com/llvm/llvm-project/commit/bf414cfbf70570eaba282ae0561324794269d2d1.d

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

This revision was automatically updated to reflect the committed changes. Closed by commit rG63e512100ac6: Fix race condition when launching and attaching. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120755/new/ https://rev

[Lldb-commits] [lldb] 63e5121 - Fix race condition when launching and attaching.

Author: Greg Clayton Date: 2022-03-03T16:20:27-08:00 New Revision: 63e512100ac62efd5f009c6b490194e973a9d1ce URL: https://github.com/llvm/llvm-project/commit/63e512100ac62efd5f009c6b490194e973a9d1ce DIFF: https://github.com/llvm/llvm-project/commit/63e512100ac62efd5f009c6b490194e973a9d1ce.diff

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace, yinghuitan. Herald added a subscriber: arphaman. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D120961: [LLDB] Flush stream at the end of PrintCommandOutput

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Windows, lldb doesn't print any error message until exit. This fixes it. Repositor

[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

shafik created this revision. shafik added reviewers: labath, aprantl, JDevlieghere. Herald added a project: All. shafik requested review of this revision. We had `using namespace std;` sprinkled around several source files and tests. This also follows the LLVM coding standard

[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

shafik added a comment. As a side note, I noticed that we don't prefix typedefs from `cstdint` with `std::` e.g. `size_t`. These typedefs are not guaranteed to be in the global namespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120966/new/ https://reviews.llvm.org/D120966 _

[Lldb-commits] [PATCH] D120966: Remove cases of using namespace std

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120966/new/ https://reviews.llvm.org/D120966 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

mib created this revision. mib added reviewers: JDevlieghere, jasonmolenda. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new way to load modules programatically with Scripted Processe

[Lldb-commits] [PATCH] D120969: [lldb/Plugins] Add ability to load modules to Scripted Processes

mib updated this revision to Diff 412923. mib added a comment. Re-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120969/new/ https://reviews.llvm.org/D120969 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/include/lldb/Interpreter/ScriptedProcessInterfac

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, mib, aprantl, kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds support for showing progress events when using lldb on the command line. It spawns a separate

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 412926. JDevlieghere added a comment. Remove unrelated formatting changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/API/SBCommandInterpreterRunOptions.h lldb/include

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

mib added a comment. Awesome! I could see this getting improved in the future by stacking each progress event in the output with their completion amount and popping the ones that are completed. Comment at: lldb/source/Core/Debugger.cpp:1727 + + // Only report progress is nob

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1727 + + // Only report progress is nobody else is listening for it. + if (GetBroadcaster().EventTypeHasListeners(Debugger::eBroadcastBitProgress)) mib wrote: > typo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

yinghuitan accepted this revision. yinghuitan added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Core/DataFileCache.h:127 + /// unique idenifier like the UUID being valid. + bool IsValid() const { return m_uuid.hasValue(); }

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

yinghuitan added inline comments. Comment at: lldb/include/lldb/Core/DataFileCache.h:127 + /// unique idenifier like the UUID being valid. + bool IsValid() const { return m_uuid.hasValue(); } yinghuitan wrote: > Do we plan to ship with this design (no caching

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 412937. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Fix typo - Reduce stack size CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/API/SBCom

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1822 +[this] { return ProgressHandlerThread(); }, +8 * 1024 * 1024); // Use larger 8MB stack for this thread +if (progress_handler_thread) { mib wrote: > Why

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

davidca added inline comments. Herald added a project: All. Comment at: lldb/docs/lldb-gdb-remote.txt:469 +// +//tsc_rate: { +// kind: "perf", why is all this called tsc rate? there is also offset in this conversion. What about something like tsc_conver