[Lldb-commits] [PATCH] D119131: [lldb] List platform plugin *instances* in "platform list"

labath added a comment. Thanks for the review. BTW, I don't know if you're following discourse, Greg, but there is a continuation of the mailing list thread there https://discourse.llvm.org/t/multiple-platforms-with-the-same-name/59594, and I'd like to hear your thoughts on it. Repository:

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

labath added a comment. Given the renewed interest in the size of the ConstString pool, I'd like to avoid adding strings there without a good reason. And I don't see any reason why a name-based platform lookup should be on any hot path. A Target object holds a platform pointer, the current plat

[Lldb-commits] [PATCH] D119400: Fix a double debug info size counting in top level stats for "statistics dump".

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems fine. I might consider changing the type of the `__dof_cache` section (whatever that is) instead of making an exception for `eSectionTypeDebug`. It don't see anything depending on it, an

[Lldb-commits] [lldb] 2937b28 - Reland "[lldb] Remove non address bits when looking up memory regions"

Author: David Spickett Date: 2022-02-10T10:42:49Z New Revision: 2937b282188bafb6bdb65ee87c70e9109aa910b7 URL: https://github.com/llvm/llvm-project/commit/2937b282188bafb6bdb65ee87c70e9109aa910b7 DIFF: https://github.com/llvm/llvm-project/commit/2937b282188bafb6bdb65ee87c70e9109aa910b7.diff LOG

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2937b282188b: Reland "[lldb] Remove non address bits when looking up memory regions" (authored by DavidSpickett). Changed prior to commit: https:/

[Lldb-commits] [PATCH] D119386: [lldb/Plugins] Clean-up ScriptedProcess python script (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/examples/python/scripted_process/scripted_process.py:264 /// not be examined. +eStateCrashed, //

[Lldb-commits] [lldb] 3db7cc1 - Fix a double debug info size counting in top level stats for "statistics dump".

Author: Greg Clayton Date: 2022-02-10T10:55:18-08:00 New Revision: 3db7cc1ba41f192d9eeb33cdaf06f4e95abf6bdc URL: https://github.com/llvm/llvm-project/commit/3db7cc1ba41f192d9eeb33cdaf06f4e95abf6bdc DIFF: https://github.com/llvm/llvm-project/commit/3db7cc1ba41f192d9eeb33cdaf06f4e95abf6bdc.diff

[Lldb-commits] [PATCH] D119400: Fix a double debug info size counting in top level stats for "statistics dump".

This revision was automatically updated to reflect the committed changes. Closed by commit rG3db7cc1ba41f: Fix a double debug info size counting in top level stats for "statistics dump". (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D119400: Fix a double debug info size counting in top level stats for "statistics dump".

clayborg added a comment. In D119400#3310366 , @labath wrote: > Seems fine. I might consider changing the type of the `__dof_cache` section > (whatever that is) instead of making an exception for `eSectionTypeDebug`. It > don't see anything depending on

[Lldb-commits] [lldb] 547a667 - Add -fmodules-local-submodule-visibility to MANDATORY_MODULE_BUILD_CFLAGS

Author: Adrian Prantl Date: 2022-02-10T11:11:50-08:00 New Revision: 547a667ceeb60dca5447e5bc09165a52b22925eb URL: https://github.com/llvm/llvm-project/commit/547a667ceeb60dca5447e5bc09165a52b22925eb DIFF: https://github.com/llvm/llvm-project/commit/547a667ceeb60dca5447e5bc09165a52b22925eb.diff

[Lldb-commits] [PATCH] D119400: Fix a double debug info size counting in top level stats for "statistics dump".

wallace added a comment. good catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119400/new/ https://reviews.llvm.org/D119400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

clayborg accepted this revision. clayborg added a comment. In D119146#3310353 , @labath wrote: > Given the renewed interest in the size of the ConstString pool, I'd like to > avoid adding strings there without a good reason. And I don't see any reason >

[Lldb-commits] [lldb] 4ef02cb - Revert "Add -fmodules-local-submodule-visibility to MANDATORY_MODULE_BUILD_CFLAGS"

Author: Adrian Prantl Date: 2022-02-10T15:37:11-08:00 New Revision: 4ef02cba2ef3fdb49c33d014dd8f4034ef9cb4cb URL: https://github.com/llvm/llvm-project/commit/4ef02cba2ef3fdb49c33d014dd8f4034ef9cb4cb DIFF: https://github.com/llvm/llvm-project/commit/4ef02cba2ef3fdb49c33d014dd8f4034ef9cb4cb.diff

[Lldb-commits] [PATCH] D119389: [lldb/crashlog] Add CrashLogScriptedProcess and resurrect_crashlog method

mib updated this revision to Diff 407712. mib added a comment. Update `crash_log_scripted_process.py` to stop using `get_most_relevant_thread_index` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119389/new/ https://reviews.llvm.org/D119389 Files: lldb/bindings/python/CMakeLists.txt

[Lldb-commits] [PATCH] D119499: [lldb/API] Add a way to check if the CommandInterpreter is interactive

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds the ability for the user to check if the command interpreter's IOHandler is interactive. Signed-off-by:

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. The crashlog command has an interactive mode that only provide a very limited experience. This is why this patch removes all the

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. In some cases, it can happen that crashlogs doesn't have any signal in the exception, which caused the parser to crash. This fi

[Lldb-commits] [PATCH] D119499: [lldb/API] Add a way to check if the CommandInterpreter is interactive

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119499/new/ https://reviews.llvm.org/D119499 ___

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:466 +if 'signal' in json_exception: +exception_signal += "({})".format(json_exception['signal']) + Should this be surrounded by spaces? Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Replace interactive mode by CrashLogScriptedProcess

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1142-1146 +if options.interactive and ci and ci.IsInteractive(): +load_crashlog_in_scripted_process(debugger, crash_log_file) +else: crash_log

[Lldb-commits] [PATCH] D119504: [lldb/crashlog] Fix exception signal parsing

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:471 exception_extra = "" -return "{} ({}){}".format(exception_type, exception_signal, exception_extra) @JDevlieghere Here it's only pre