JDevlieghere added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:1142-1146
+ if options.interactive and ci and ci.IsInteractive():
+ load_crashlog_in_scripted_process(debugger, crash_log_file)
+ else:
crash_log = CrashLogParser().parse(debugger, crash_log_file,
options.verbose)
SymbolicateCrashLog(crash_log, options)
----------------
If `options.interactive` is set explicitly we should honor it. In the future
we'll want to use `ci.IsInteractive()` to decide what to do if nothing is
specified. At the same time we should create another option
(`--non-interactive`?) and also honor it, so that this logic would look
something like:
```
if options.interactive:
// Interactive
else if options.noninteractive:
// Classic
else if ci and ci.IsInteractive():
// Interactive
else
// Classic
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119501/new/
https://reviews.llvm.org/D119501
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
