[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

yuanzi updated this revision to Diff 398193. yuanzi added a comment. free->xmlFree, remove conversions from std::string to llvm::StringRef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116707/new/ https://reviews.llvm.org/D116707 Files: lldb/in

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:560-563 } else if (num_matches == 0) { -result.GetErrorStream().Printf(

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

yuanzi marked 3 inline comments as done. yuanzi added inline comments. Comment at: lldb/source/Host/common/XML.cpp:157-159 + std::string attr_str = GetAttributeValue(name, ""); + llvm::StringRef attr(attr_str); + return llvm::to_integer(attr, value, base); lab

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116707/new/ https://reviews.llvm.org/D116707 ___ lldb-commit

[Lldb-commits] [PATCH] D116539: [lldb/platform-gdb] Clear cached protocol state upon disconnection

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:84 bool PlatformAndroidRemoteGDBServer::LaunchGDBServer(lldb::pid_t &pi

[Lldb-commits] [lldb] 7244e9c - [LLDB] libcxx summary formatters for std::string_view

Author: Ben Jackson Date: 2022-01-07T11:41:16-08:00 New Revision: 7244e9c2f5f3ea02cc0d7103fa35782f050aacf0 URL: https://github.com/llvm/llvm-project/commit/7244e9c2f5f3ea02cc0d7103fa35782f050aacf0 DIFF: https://github.com/llvm/llvm-project/commit/7244e9c2f5f3ea02cc0d7103fa35782f050aacf0.diff L

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

This revision was automatically updated to reflect the committed changes. Closed by commit rG7244e9c2f5f3: [LLDB] libcxx summary formatters for std::string_view (authored by puremourning, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 4f6d3a3 - [LLDB] Fix setting of success in Socket::Close()

Author: Shafik Yaghmour Date: 2022-01-07T12:42:58-08:00 New Revision: 4f6d3a376c9faba93bbdf105966cea7585b0b8e9 URL: https://github.com/llvm/llvm-project/commit/4f6d3a376c9faba93bbdf105966cea7585b0b8e9 DIFF: https://github.com/llvm/llvm-project/commit/4f6d3a376c9faba93bbdf105966cea7585b0b8e9.dif

[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f6d3a376c9f: [LLDB] Fix setting of success in Socket::Close() (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D116461: [lldb] Remove ProcessStructReader from NSStringSummaryProvider (NFC)

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This doesn't look any less readable than the code it replaces and is definitely faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116461/n

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

aprantl added inline comments. Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:76 + +self.runCmd("run", RUN_SUCCEEDED) + Doesn't `lldbutil.run_break_set_by_symbol()` do the "file" and "run" already and this run command runs it

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

aprantl added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1695 + section_sp = section_sp->GetParent(); +section_name = section_sp->GetName(); + } Why did `section_sp->GetName();` return the Segment n

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

aprantl added a comment. > it can vary on some platforms it is signed char but on others it is bool. For those interested, Objective-C `BOOL` is a signed char on macOS and 32-bit iOS and `bool` on 64-bit iOS and derived platforms (watchOS & tvOS). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] ab76189 - [lldb] Use lit_config.note to print module cache message

Author: Jonas Devlieghere Date: 2022-01-07T13:35:18-08:00 New Revision: ab7618914dec6384f24b30ad2d45b82a51647a33 URL: https://github.com/llvm/llvm-project/commit/ab7618914dec6384f24b30ad2d45b82a51647a33 DIFF: https://github.com/llvm/llvm-project/commit/ab7618914dec6384f24b30ad2d45b82a51647a33.d

[Lldb-commits] [lldb] d13da5f - [lldb] Remove lldbconfig module

Author: Jonas Devlieghere Date: 2022-01-07T15:58:43-08:00 New Revision: d13da5f0da1ca39d2130f4ae602184350c3ec968 URL: https://github.com/llvm/llvm-project/commit/d13da5f0da1ca39d2130f4ae602184350c3ec968 DIFF: https://github.com/llvm/llvm-project/commit/d13da5f0da1ca39d2130f4ae602184350c3ec968.d

[Lldb-commits] [lldb] 69c8e64 - [formatters] Improve documentation

Author: Walter Erquinigo Date: 2022-01-07T16:27:03-08:00 New Revision: 69c8e64ba6be090d25657ca0fc2bc53797907837 URL: https://github.com/llvm/llvm-project/commit/69c8e64ba6be090d25657ca0fc2bc53797907837 DIFF: https://github.com/llvm/llvm-project/commit/69c8e64ba6be090d25657ca0fc2bc53797907837.di

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c8e64ba6be: [formatters] Improve documentation (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115974/new/

[Lldb-commits] [PATCH] D116845: [LLDB][NativePDB] Add support for inlined functions

zequanwu created this revision. zequanwu added reviewers: labath, rnk, akhuang. Herald added a subscriber: arphaman. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This adds inline func

[Lldb-commits] [PATCH] D116847: [lldb] Remove most of the reproducer instrumentation

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. With regret, I accept this patch. Too bad couldn't make it work! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116847/new/ https://reviews.llvm.org/D116847

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 updated this revision to Diff 398286. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116467/new/ https://reviews.llvm.org/D116467 Files: lld/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake ll

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 updated this revision to Diff 398287. Ericson2314 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116467/new/ https://reviews.llvm.org/D116467 Files: lld/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake ll

[Lldb-commits] [PATCH] D116853: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

paperchalice created this revision. paperchalice added a reviewer: mgorny. paperchalice added a project: LLDB. Herald added a subscriber: JDevlieghere. paperchalice requested review of this revision. Herald added a subscriber: lldb-commits. Try to fix https://github.com/llvm/llvm-project/issues/10