[Lldb-commits] [lldb] 96a7359 - [lldb] Add support for demangling D symbols

Author: Luís Ferreira Date: 2021-11-11T11:11:21+01:00 New Revision: 96a7359908397d8db3ac6f8e10fb9f6dc5756a44 URL: https://github.com/llvm/llvm-project/commit/96a7359908397d8db3ac6f8e10fb9f6dc5756a44 DIFF: https://github.com/llvm/llvm-project/commit/96a7359908397d8db3ac6f8e10fb9f6dc5756a44.diff

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

This revision was automatically updated to reflect the committed changes. Closed by commit rG96a735990839: [lldb] Add support for demangling D symbols (authored by ljmf00, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

teemperor added a comment. I changed the commit name from "Add support for D programming language" to "[lldb] Add support for demangling D symbols" when landing (which is more accurate). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ h

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

teemperor added a comment. Are the DWARFASTParserClang changes meant as a step towards making it parse D? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113634/new/ https://reviews.llvm.org/D113634 ___ ll

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. > Are you asking for dedicated physical resources for running nightly builds? I don't think any of the current bots have a Java installation so I think it's either that or we get someone with a bot to setup the required Java installation. FWIW, if no one wants to hos

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 386466. DavidSpickett added a comment. - Set x registers to a different pattern in the signal handler - Don't save frames before and after, just check for the right pattern when unwinding out of the handler to sigill() - Set register kind when we first

[Lldb-commits] [lldb] 9db2541 - [lldb][AArch64] Add UnwindPlan for Linux sigreturn

Author: David Spickett Date: 2021-11-11T11:32:06Z New Revision: 9db2541d4c30100d7ccc6cc9db717df102b302d9 URL: https://github.com/llvm/llvm-project/commit/9db2541d4c30100d7ccc6cc9db717df102b302d9 DIFF: https://github.com/llvm/llvm-project/commit/9db2541d4c30100d7ccc6cc9db717df102b302d9.diff LOG

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

This revision was automatically updated to reflect the committed changes. Closed by commit rG9db2541d4c30: [lldb][AArch64] Add UnwindPlan for Linux sigreturn (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ http

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. Thanks for the help, really helped get a high quality fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069 ___ lldb-commits maili

[Lldb-commits] [lldb] 2a0e773 - [lldb][NFC] Remove no longer valid comment for TypeSystem::SetSymbolFile

Author: Raphael Isemann Date: 2021-11-11T12:39:54+01:00 New Revision: 2a0e77362e3ac1f4de1290640ad1122f9d4e208b URL: https://github.com/llvm/llvm-project/commit/2a0e77362e3ac1f4de1290640ad1122f9d4e208b DIFF: https://github.com/llvm/llvm-project/commit/2a0e77362e3ac1f4de1290640ad1122f9d4e208b.dif

[Lldb-commits] [lldb] b72727a - [lldb][NFC] Remove commented out code in SymbolFileDWARF

Author: Raphael Isemann Date: 2021-11-11T12:45:38+01:00 New Revision: b72727a75a64df355c18b38465324cdf81893d3c URL: https://github.com/llvm/llvm-project/commit/b72727a75a64df355c18b38465324cdf81893d3c DIFF: https://github.com/llvm/llvm-project/commit/b72727a75a64df355c18b38465324cdf81893d3c.dif

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

labath added a comment. In D111409#3124075 , @teemperor wrote: >> Are you asking for dedicated physical resources for running nightly builds? > > I don't think any of the current bots have a Java installation so I think > it's either that or we get someo

[Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

teemperor added a comment. In D111409#3124194 , @labath wrote: > In D111409#3124075 , @teemperor > wrote: > >>> Are you asking for dedicated physical resources for running nightly builds? >> >> I don't think any

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

labath added a comment. In D113521#3122654 , @jingham wrote: > In D113521#3120703 , @labath wrote: > >> I have two high-level questions about this: >> >> - what should be the relative priority of executable Module

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 added a comment. In D113634#3124042 , @teemperor wrote: > Are the DWARFASTParserClang changes meant as a step towards making it parse D? Yes, not only D but any language that currently falls here (https://github.com/llvm/llvm-project/blob/main/ll

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

teemperor added a comment. In D113634#3124401 , @ljmf00 wrote: > In D113634#3124042 , @teemperor > wrote: > >> Are the DWARFASTParserClang changes meant as a step towards making it parse >> D? > > Yes, not only

[Lldb-commits] [PATCH] D113605: [lldb] Fix documentation for EncodingDataType

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lldb/include/lldb/Symbol/Type.h:69 enum EncodingDataType { +/// Invalid encoding eEncodingInvalid, nit: LLVM comm

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The value type can be a typedef of a reference (e.g. `typedef int& myint`). In this case `GetQualType(type)` will return `clang::Typedef`, which cannot be ca

Re: [Lldb-commits] [PATCH] D111409: proposed support for Java interface to Scripting Bridge

Am sorry I can't commit build resources, but am certainly willing to commit time to solving test problems. In a very general sense, I think our project (Ghidra) will effectively be a test platform for issues with the Java bindings to SWIG. With regard to the set-up for testing, I have noticed

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

teemperor added a reviewer: LLDB. teemperor added a comment. I really like the solution, but I think by fixing the `CanInterpret` you also made the test case no longer reach the actual changed interpreting logic? So, `CanInterpret` says "we can't interpret this" (which is correct), but then the

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

labath added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:330-331 + /// NB: This implementation is mutually recursive with + /// GetSupportedArchitectureAtIndex. Subclasses should implement at least one + /// of them. + virtual std::vector GetSupportedArch

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to controlling plan

quinnp added a comment. @jingham could you take a look at the new changes when you have time? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113019/new/ https://reviews.llvm.org/D113019 ___ lldb-c

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

labath updated this revision to Diff 386516. labath added a comment. - remove "at least" - change CreateArchList argument order to match the triple format. This would be particularly important if new arguments are added later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

shafik added a comment. I was trying to fix this a while back in D108717 but got distracted and did not get back to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113673/new/ https://reviews.llvm.org/D113673

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks a lot for fixing this, could you point to D103532 as the cause for the regression in the commit message? This LGTM in general, but I think ther

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

labath updated this revision to Diff 386543. labath added a comment. Fix a rather embarrasing off-by-one in the base implementation of GetSupportedArchitectureAtIndex, which I guess also means I did not run tests before uploading this (I have now). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D113687: [lldb][NFC] Inclusive language: replace master/slave names for ptys

quinnp created this revision. quinnp requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [NFC] This patch replaces master and slave with primary and secondary respectively when referening to pseudoterminals/file descriptors. Repository: rG

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:413 +static const char GetInterpreterInfoScript[] = R"( +import os Does `sys.executable` not work for some reason? C

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:413 +static const char GetInterpreterInfoScript[] = R"( +import os stella.stamenova wrote: > Does `sys.executable` not work for some reas

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432 + elif os.name == 'posix': + exename = "python" + str(sys.version_info[0]) + info['executable'] = os.path.join(sys.prefix, 'bin', exename)

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432 + elif os.name == 'posix': + exename = "python" + str(sys.version_info[0]) + info['executable'] = os.path.join(sys.prefix, 'bin', exename) --

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to controlling plan

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LOKTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113019/new/ https://reviews.llvm.org/D113019

[Lldb-commits] [PATCH] D113687: [lldb][NFC] Inclusive language: replace master/slave names for ptys

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113687/new/ https://reviews.llvm.org/D113687

[Lldb-commits] [PATCH] D113634: [lldb] Add support for DW_TAG_immutable_type

ljmf00 added a comment. In D113634#3124428 , @teemperor wrote: > In D113634#3124401 , @ljmf00 wrote: > >> In D113634#3124042 , @teemperor >> wrote: >> >>> Are the DWARFAS

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386599. lawrence_danna added a comment. Herald added a subscriber: mgorny. maybe this approach is better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files:

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. OK this should work in all configs I think, as long as sys.executable ultimately points at something under sys.prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

clayborg added a comment. I'm good with this to get things started. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113521/new/ https://reviews.llvm.org/D113521 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D113019: [lldb][NFC] Inclusive Language: rename master plan to controlling plan

This revision was automatically updated to reflect the committed changes. Closed by commit rG04cbfa950e02: [lldb][NFC] Inclusive Language: rename master plan to controlling plan (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1130

[Lldb-commits] [lldb] 04cbfa9 - [lldb][NFC] Inclusive Language: rename master plan to controlling plan

Author: Quinn Pham Date: 2021-11-11T15:04:44-06:00 New Revision: 04cbfa950e0221ac334f802407a9b766df33eee5 URL: https://github.com/llvm/llvm-project/commit/04cbfa950e0221ac334f802407a9b766df33eee5 DIFF: https://github.com/llvm/llvm-project/commit/04cbfa950e0221ac334f802407a9b766df33eee5.diff LO

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham added a comment. In D113521#3124239 , @labath wrote: > In D113521#3122654 , @jingham wrote: > >> In D113521#3120703 , @labath wrote: >> >>> I have two high-level q

[Lldb-commits] [PATCH] D113720: [lldb][NFC] Inclusive language: rename m_master in ASTImporterDelegate

quinnp created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. quinnp requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. [NFC] As part of using inclusive language within t

[Lldb-commits] [lldb] ac33e65 - [lldb][NFC] Delete commented out code in AddressRange

Author: Alex Langford Date: 2021-11-11T15:42:27-08:00 New Revision: ac33e65d2169260364e3e92fed2ba81c58d5ce33 URL: https://github.com/llvm/llvm-project/commit/ac33e65d2169260364e3e92fed2ba81c58d5ce33 DIFF: https://github.com/llvm/llvm-project/commit/ac33e65d2169260364e3e92fed2ba81c58d5ce33.diff

[Lldb-commits] [PATCH] D113722: [lldb] fix test expectation broken by clang fix at D110216

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113722 Files: lldb/test/Shell/SymbolFile/NativePD

[Lldb-commits] [PATCH] D113722: [lldb] fix test expectation broken by clang fix at D110216

mizvekov added a comment. Herald added a subscriber: JDevlieghere. Fixes buildbot failure seen at http://lab.llvm.org:8011/#/builders/68/builds/21662/steps/6/logs/stdio Caused by a fix in D110216 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [lldb] 5508595 - [lldb] fix test expectation broken by clang fix at D110216

Author: Matheus Izvekov Date: 2021-11-12T01:47:29+01:00 New Revision: 55085952175ed3b029097a0594acc4e34a5df218 URL: https://github.com/llvm/llvm-project/commit/55085952175ed3b029097a0594acc4e34a5df218 DIFF: https://github.com/llvm/llvm-project/commit/55085952175ed3b029097a0594acc4e34a5df218.dif

[Lldb-commits] [PATCH] D113722: [lldb] fix test expectation broken by clang fix at D110216

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG55085952175e: [lldb] fix test expectation broken by clang fix at D110216 (authored by mizvekov). Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

zequanwu created this revision. zequanwu added reviewers: rnk, labath, teemperor, shafik. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. I don't know how to add tests for this. I tested

[Lldb-commits] [PATCH] D113608: [lldb] Simplify specifying of platform supported architectures

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Target/Platform.cpp:1217-1218 +std::vector +Platform::CreateArchList(llvm::Triple::OSType os, + llvm::ArrayRe

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

labath added a comment. IIUC, these are two separate fixes: a) fix clang ast creation for methods b) fix symbol context lookup It would be better to split them into two patches, as each will require a different kind of a test. The ast thing could be tested by running "image dump ast" on an appro