labath added a comment.

IIUC, these are two separate fixes:
a) fix clang ast creation for methods
b) fix symbol context lookup
It would be better to split them into two patches, as each will require a 
different kind of a test. The ast thing could be tested by running "image dump 
ast" on an appropriate piece of debug info. I'm hoping that the second one 
could be tested through "image lookup -a", but I don't know if it'll be as 
simple as running just that command. I guess you might need to play around with 
it a bit to find a way to invoke it without first instantiating the compile 
unit. It's possible you will need more than one compile unit in the test 
executable.

I don't think either of the fixes is really tied to minidumps, so I hope it 
will be possible to reproduce the issues by just compiling some c++ (without 
even running the program).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113724/new/

https://reviews.llvm.org/D113724

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to