[Lldb-commits] [PATCH] D110033: [lldb] [gdb-remote] Always send PID when detaching w/ multiprocess

2021-09-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Always send PID in the detach packet when multiprocess extensions are enabled. This is required by qemu's GDB server, as plain 'D' packet results in an error and the emulat

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

2021-09-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 373451. mgorny added a comment. Update for using local (LLDB) regnos. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110023/new/ https://reviews.llvm.org/D110023 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugi

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

2021-09-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:482 +// copy invalidate_regs from the parent register +llvm::append_range(to_add[reg_num], m_invalidate_regs_map[value_reg]); + @labath, any suggestion h

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing [WIP]

2021-09-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 373452. mgorny added a comment. Rebase. Clang-format. Eliminate remote regnums entirely. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 Files: lldb/include/lldb/Target/ABI.h lldb/source/Plugins/ABI/AAr

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

2021-09-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny abandoned this revision. mgorny added a comment. Replaced by D110027 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108768/new/ https://reviews.llvm.org/D108768 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

2021-09-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D109937#3007071 , @ted wrote: > I've got a test written. It doesn't crash like the debugger in the wild does, > but it does give a tid of 0 for each thread I ask about. So I can assert if > the threads don't have the correct t

[Lldb-commits] [PATCH] D110010: [lldb] Extract adding symbols for UUID/File/Frame (NFC)

2021-09-19 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. seems straight-forward enough Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4203 + + bool AddSymbolsForFrame(Target *target, CommandReturnObject &result, +

[Lldb-commits] [PATCH] D110020: [lldb] [gdb-remote] Remove unused arg from GDBRemoteRegisterContext::ReadRegisterBytes()

2021-09-19 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. yay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110020/new/ https://reviews.llvm.org/D110020 ___ lldb-commits mailing list lldb-commits@