labath added a comment.

In D109937#3007071 <https://reviews.llvm.org/D109937#3007071>, @ted wrote:

> I've got a test written. It doesn't crash like the debugger in the wild does, 
> but it does give a tid of 0 for each thread I ask about. So I can assert if 
> the threads don't have the correct tid.

I guess you forgot to upload it (?)

> Which leads me to 1 more question - what should I do when we have a malformed 
> response, and there are no threads listed? I'm leaning towards just falling 
> through to the if at line 2931, and returning a pid and tid of 1. That's what 
> we do if there's and empty response.

Sounds reasonable to me. We'd be basically treating it as if the stub did not 
support the packet at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109937/new/

https://reviews.llvm.org/D109937

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to