[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. The release branch was recently made, so we can land this right now. Just give me a ping when I should merge this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106035/new/ https://reviews.llvm.org/D106035 ___

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107446/new/ https://reviews.llvm.org/D107446 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107446/new/ https://reviews.llvm.org/D107446 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D106984: [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Host/File.h:47-61 +eOpenOptionReadOnly = (1u << 0), // Open file for reading (only) +eOpenOptionWriteOnly = (1u << 1), // Open file for writing (only) +eOpenOptionReadWrite = +eOpenOptionReadOn

[Lldb-commits] [PATCH] D107444: [lldb] Remove a few unused .exports files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Yup, we only use the main export file. Thanks for cleaning this up. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107444/new/ https://reviews.llvm.org/D107444 _

[Lldb-commits] [lldb] 7529f0e - D106035: Remove conditional compilation for WCHAR support in libedit

Author: Neal Sidhwaney Date: 2021-08-05T00:29:54-07:00 New Revision: 7529f0e3e1427fea93a6a66a2aed5394710e5fb5 URL: https://github.com/llvm/llvm-project/commit/7529f0e3e1427fea93a6a66a2aed5394710e5fb5 DIFF: https://github.com/llvm/llvm-project/commit/7529f0e3e1427fea93a6a66a2aed5394710e5fb5.diff

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7529f0e3e142: D106035: Remove conditional compilation for WCHAR support in libedit (authored by Neal Sidhwaney ).

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. In D106035#2927660 , @teemperor wrote: > The release branch was recently made, so we can land this right now. Just > give me a ping when I should merge this :) Thanks - I recently got commit access so I figured I'd try it out wi

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. In D106035#2927714 , @nealsid wrote: > In D106035#2927660 , @teemperor > wrote: > >> The release branch was recently made, so we can land this right now. Just >> give me a ping when I

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. I fear I might also have to congratulate you on your first revert (sorry, couldn't resist that joke). TestUnicode is failing for me with this patch on Arch Linux: Command Output (stdout): -- lldb version 14.0.0 (g...@github.com:Teemperor/llvm-project revision f

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. :) Shoot. I definitely want to revert ASAP rather than keep the tree in a bad state. Just curious, since there are timeout messages in the log, would you be able to try rerunning just that one? I see this, too: 0: b"error: '\xe1\x88\xb4' is not a valid command. So I'm

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. I ran it a few times and I'm sure it's an actual '"the output didn't show up" timeout and not a random failure. I also checked and my node doesn't have an `.editrc` file or something like that on the node. It's failing on a different Arch Linux bot so I think it's not

[Lldb-commits] [lldb] 55fd6f2 - Revert "D106035: Remove conditional compilation for WCHAR support in libedit"

Author: Neal Sidhwaney Date: 2021-08-05T02:55:10-07:00 New Revision: 55fd6f292fac7294fcd302e79065eb4fd7a89dfc URL: https://github.com/llvm/llvm-project/commit/55fd6f292fac7294fcd302e79065eb4fd7a89dfc DIFF: https://github.com/llvm/llvm-project/commit/55fd6f292fac7294fcd302e79065eb4fd7a89dfc.diff

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

nealsid added a comment. Yikes - issue count starting to slowly increase :) I've reverted the patch, and sorry again about that. I have to travel for a couple days but when I get my dev machine back up later this week I will investigate these issues in detail. I focussed my testing more on Un

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

shafik accepted this revision. shafik added a comment. LGTM Comment at: lldb/source/Expression/IRExecutionUnit.cpp:842 + Target *m_target; + bool &m_symbol_was_missing_weak; + lldb::addr_t m_best_internal_load_address = LLDB_INVALID_ADDRESS; Normally I would

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

shafik accepted this revision. shafik added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107295/new/ https://reviews.llvm.org/D107295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @clayborg What do you think? Should we add another tree level with more details or do something else? By the way, it would be nice to have D107182 commited because it is needed by the search form. Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] c020be1 - [lldb] Use a struct to pass function search options to Module::FindFunction

Author: Jonas Devlieghere Date: 2021-08-05T10:18:14-07:00 New Revision: c020be17ce0a43c32554585e1075627769f364f3 URL: https://github.com/llvm/llvm-project/commit/c020be17ce0a43c32554585e1075627769f364f3 DIFF: https://github.com/llvm/llvm-project/commit/c020be17ce0a43c32554585e1075627769f364f3.d

[Lldb-commits] [lldb] a46bcc6 - [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

Author: Jonas Devlieghere Date: 2021-08-05T10:18:14-07:00 New Revision: a46bcc60e52fe080ee87af1788e8cdc00f9c035f URL: https://github.com/llvm/llvm-project/commit/a46bcc60e52fe080ee87af1788e8cdc00f9c035f DIFF: https://github.com/llvm/llvm-project/commit/a46bcc60e52fe080ee87af1788e8cdc00f9c035f.d

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc020be17ce0a: [lldb] Use a struct to pass function search options to Module::FindFunction (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGa46bcc60e52f: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC) (authored by JDevlieghere). Herald

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces the `ScriptedThread` class with its python interface. When use

[Lldb-commits] [lldb] 1156532 - [lldb] Remove a few unused .exports files

Author: Nico Weber Date: 2021-08-05T22:17:00+02:00 New Revision: 11565320fd55117f04b9cc812e28a30962283c3e URL: https://github.com/llvm/llvm-project/commit/11565320fd55117f04b9cc812e28a30962283c3e DIFF: https://github.com/llvm/llvm-project/commit/11565320fd55117f04b9cc812e28a30962283c3e.diff LO

[Lldb-commits] [PATCH] D107444: [lldb] Remove a few unused .exports files

This revision was automatically updated to reflect the committed changes. Closed by commit rG11565320fd55: [lldb] Remove a few unused .exports files (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107444/new/ https://reviews.llvm

[Lldb-commits] [lldb] e71fdc1 - [lldb] Stop referencing "host_lib" in cmake files

Author: Nico Weber Date: 2021-08-05T22:18:37+02:00 New Revision: e71fdc1acf054271031200f87a6bfc276d8a1ebd URL: https://github.com/llvm/llvm-project/commit/e71fdc1acf054271031200f87a6bfc276d8a1ebd DIFF: https://github.com/llvm/llvm-project/commit/e71fdc1acf054271031200f87a6bfc276d8a1ebd.diff LO

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

This revision was automatically updated to reflect the committed changes. Closed by commit rGe71fdc1acf05: [lldb] Stop referencing "host_lib" in cmake files (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107446/new/ https://revi

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:4331-4333 +if (StateIsRunningState(process->GetState())) { + return false; +} Remove {} for single statement if statements per LLVM guidelines Comm

[Lldb-commits] [lldb] 2b89f40 - [LLDB][GUI] Refactor form drawing using subsurfaces

Author: Omar Emara Date: 2021-08-05T16:51:14-07:00 New Revision: 2b89f40a411cb9717232df61371b24d73ae84cb8 URL: https://github.com/llvm/llvm-project/commit/2b89f40a411cb9717232df61371b24d73ae84cb8 DIFF: https://github.com/llvm/llvm-project/commit/2b89f40a411cb9717232df61371b24d73ae84cb8.diff LO

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b89f40a411c: [LLDB][GUI] Refactor form drawing using subsurfaces (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

clayborg added a comment. In D107386#2928910 , @OmarEmaraDev wrote: > By the way, it would be nice to have D107182 > commited because it is needed by the > search form. Just committed it! Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

jasonmolenda added a comment. Am I the only one seeing a compiler error with this patch? if (is_pad(m_window)) is_pad isn't defined anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107182/new/ https://reviews.llvm.org/D107182 __

[Lldb-commits] [lldb] 4d3d182 - Revert "[LLDB][GUI] Refactor form drawing using subsurfaces"

Author: Jason Molenda Date: 2021-08-05T19:27:55-07:00 New Revision: 4d3d182c1dcb99ddcce7d077060d87111cb8dbfa URL: https://github.com/llvm/llvm-project/commit/4d3d182c1dcb99ddcce7d077060d87111cb8dbfa DIFF: https://github.com/llvm/llvm-project/commit/4d3d182c1dcb99ddcce7d077060d87111cb8dbfa.diff

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

jasonmolenda added a comment. I reverted this commit in 4d3d182c1dcb99ddcce7d077060d87111cb8dbfa to fix the build for now; I'm not sure where is_pad() is intended to come from. Repository: rG LLVM Github Monorepo CHANGES