shafik accepted this revision. shafik added a comment. LGTM
================ Comment at: lldb/source/Expression/IRExecutionUnit.cpp:842 + Target *m_target; + bool &m_symbol_was_missing_weak; + lldb::addr_t m_best_internal_load_address = LLDB_INVALID_ADDRESS; ---------------- Normally I wouldn't be crazy about a reference member but since this is a localized class I think this is an ok compromise. I guess the real question would be why `IRExecutionUnit::FindInSymbols` is returning a value that way and perhaps it should be returning a struct w/ `addr_t` and `bool` but that would be a different change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107206/new/ https://reviews.llvm.org/D107206 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
