[Lldb-commits] [PATCH] D107255: [lldb] Get rid of HAVE_SIGACTION

thakis created this revision. thakis added a reviewer: JDevlieghere. thakis added a project: LLDB. Herald added a subscriber: mgorny. thakis requested review of this revision. The .cpp file uses SIGNAL_POLLING_UNSUPPORTED to guard the call to sigaction, so use it in the .h file too. (LLVM also cal

[Lldb-commits] [PATCH] D107161: [lldb] Fix lookup of .debug_loclists with split-dwarf

kimanh updated this revision to Diff 363407. kimanh marked 7 inline comments as done. kimanh added a comment. Address reviews: - remove unused tmp label - remove invalid offsets - add ReportError when no loclist contribution was found - adapt ReportError logging to include offset and loclist base

[Lldb-commits] [PATCH] D107213: Disassemble AArch64 pc-relative address calculations & symbolicate

DavidSpickett added a comment. The test is with MachO but I assume this would apply to ELF, COFF etc, since it's a general disassembly feature? Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1315 + if (target->GetArchitecture().GetMachine() == ll

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

tammela added inline comments. Comment at: lldb/docs/use/scripting-reference.rst:572 +Create a new lldb command +- So I'm guessing some sections are still missing some updates because the Lua functionality is not there yet right? If so

[Lldb-commits] [PATCH] D107255: [lldb] Get rid of HAVE_SIGACTION

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107255/new/ https://reviews.llvm.org/D107255 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107015: Add "current" token for the -t option to "break set/modify"

jingham added a comment. You can have options with optional values, but I don't favor using those. They have slightly odd behavior in the parser since you have to disambiguate them when they have a value, and them when they happen to be next to an argument. They aren't as easy to document, an

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, jingham. JDevlieghere requested review of this revision. Rather than passing two bools (next to each other), use a struct instead. https://reviews.llvm.org/D107295 Files: lldb/include/lldb/Core/Module.h lldb/includ

[Lldb-commits] [PATCH] D107297: [RFC/WIP] Only look at the symbol table when resolving JIT symbols

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, jingham, clayborg. JDevlieghere requested review of this revision. When resolving missing symbols for the JIT, only look at the symbol table and skip the debug info. I can't think of a situation where we want to resolve

[Lldb-commits] [PATCH] D107297: [RFC/WIP] Only look at the symbol table when resolving JIT symbols

JDevlieghere abandoned this revision. JDevlieghere added a comment. Jim reminded me of static functions, which won't have a symbol, so this is actually pretty common. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107297/new/ https://reviews.llvm.org/D107297 ___

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

bulbazord added a comment. I like the idea! Could be a little cleaner imo, but shouldn't be a blocker if others don't think so. Comment at: lldb/include/lldb/Core/Module.h:62 +/// because it must be forward-declared in ModuleList.h. +struct ModuleFunctionOptions { + /// Inclu

[Lldb-commits] [lldb] 82dc463 - [lldb] Get rid of HAVE_SIGACTION

Author: Nico Weber Date: 2021-08-02T20:11:35+02:00 New Revision: 82dc463bb356200fd46b90d6d5a439c3c9b31c92 URL: https://github.com/llvm/llvm-project/commit/82dc463bb356200fd46b90d6d5a439c3c9b31c92 DIFF: https://github.com/llvm/llvm-project/commit/82dc463bb356200fd46b90d6d5a439c3c9b31c92.diff LO

[Lldb-commits] [PATCH] D107255: [lldb] Get rid of HAVE_SIGACTION

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82dc463bb356: [lldb] Get rid of HAVE_SIGACTION (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Yeah this is a lot cleaner. Thanks for taking the time to refactor this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107206/new/ https://reviews.llvm.org/D107206

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

JDevlieghere updated this revision to Diff 363536. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Thanks, updated the diff accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107295/new/ https://reviews.llvm.org/D107295 Files: lldb/include/lldb/Co

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107295/new/ https://reviews.llvm.org/D107295 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D107297: [RFC/WIP] Only look at the symbol table when resolving JIT symbols

clayborg added a comment. Yeah, any symbol that isn't exported might not be in the symbol table, but it might have a mangled name in the debug info that we can easily lookup. Static function, non-exported classes/functions, static variables, etc. That being said, in the IRExecutionUnit do we cu

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

vsk added a comment. Hey @jj10306, thanks for working on this. @wallace @clayborg -- It seems like there are a ton of logic changes introduced in this patch that are tested at too coarse a level. I'm not confident in the changes being made here. For example, there's a bunch of subtle work being

[Lldb-commits] [lldb] ea97066 - [test] [lldb] Use filename instead of index in test

Author: Eric Leese Date: 2021-08-02T21:12:57+02:00 New Revision: ea9706626ce3f83b8433849049cc3c64b6b7297c URL: https://github.com/llvm/llvm-project/commit/ea9706626ce3f83b8433849049cc3c64b6b7297c DIFF: https://github.com/llvm/llvm-project/commit/ea9706626ce3f83b8433849049cc3c64b6b7297c.diff LO

[Lldb-commits] [PATCH] D107300: Use filename instead of index in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGea9706626ce3: [test] [lldb] Use filename instead of index in test (authored by Eric, committed by jankratochvil). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LL

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

wallace added a comment. Sure thing. Sorry for not being that thorough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D107165: Support moving support files instead of copy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG437e37dd5539: [nfc] [lldb] Support moving support files instead of copy (authored by Eric, committed by jankratochvil). Herald added a project: LLDB.

[Lldb-commits] [lldb] 437e37d - [nfc] [lldb] Support moving support files instead of copy

Author: Eric Leese Date: 2021-08-02T21:43:34+02:00 New Revision: 437e37dd553917ef890821d5045f898f065e4d47 URL: https://github.com/llvm/llvm-project/commit/437e37dd553917ef890821d5045f898f065e4d47 DIFF: https://github.com/llvm/llvm-project/commit/437e37dd553917ef890821d5045f898f065e4d47.diff LO

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

shafik added a comment. Thank you for refactoring this, besides my comment on the lambda the rest makes sense. Comment at: lldb/source/Expression/IRExecutionUnit.cpp:785 + auto get_external_load_address = + [target, &symbol_was_missing_weak]( + lldb::addr_t &loa

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

shafik added inline comments. Comment at: lldb/source/API/SBModule.cpp:401-403 +ModuleFunctionOptions function_options; +function_options.include_symbols = true; +function_options.include_inlines = true; bulbazord wrote: > nit: IMO this looks cleaner,