shafik added inline comments.

================
Comment at: lldb/source/API/SBModule.cpp:401-403
+    ModuleFunctionOptions function_options;
+    function_options.include_symbols = true;
+    function_options.include_inlines = true;
----------------
bulbazord wrote:
> nit: IMO this looks cleaner, but no big deal:
> ```
> ModuleFunctionOptions function_options = { .include_symbols = true, 
> .include_inlines = true };
> ```
I love designated initializers (this is a nice use) but this is a C++20 feature 
and so we would be using this as a GNU extension, which might break some builds.

godbolt: https://godbolt.org/z/TKMddMrq3


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107295/new/

https://reviews.llvm.org/D107295

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to