[Lldb-commits] [lldb] d510b5f - [lldb][AArch64] Annotate synchronous tag faults

Author: David Spickett Date: 2021-07-29T10:26:37+01:00 New Revision: d510b5f199d6e7a3062b5a6ea43181c4cc00a605 URL: https://github.com/llvm/llvm-project/commit/d510b5f199d6e7a3062b5a6ea43181c4cc00a605 DIFF: https://github.com/llvm/llvm-project/commit/d510b5f199d6e7a3062b5a6ea43181c4cc00a605.diff

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd510b5f199d6: [lldb][AArch64] Annotate synchronous tag faults (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

teemperor added inline comments. Comment at: lldb/source/Plugins/TraceExporter/ctf/CommandObjectThreadTraceExportCTF.cpp:78 + : LLDB_INVALID_THREAD_ID; +result.AppendErrorWithFormat( +"Thread index %lu is out of range (valid v

[Lldb-commits] [PATCH] D106985: [lldb] [gdb-remote] Sync vFile:open mode constants with GDB

mgorny updated this revision to Diff 362729. mgorny added a comment. Removed obsolete FIXME from server as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106985/new/ https://reviews.llvm.org/D106985 Files: lldb/docs/lldb-platform-packets.txt lldb/include/lldb/Host/File.h lld

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 updated this revision to Diff 362735. augusto2112 added a comment. Add test to test/Shell/lit-lldb-init.in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 Files: lldb/include/lldb/Core/Secti

[Lldb-commits] [lldb] 77e9d10 - [lldb] Assert filecache and live memory match on debug under a setting

Author: Augusto Noronha Date: 2021-07-29T10:29:34-03:00 New Revision: 77e9d10f0fbfe04a14e6ce61753376dd78e0c2f0 URL: https://github.com/llvm/llvm-project/commit/77e9d10f0fbfe04a14e6ce61753376dd78e0c2f0 DIFF: https://github.com/llvm/llvm-project/commit/77e9d10f0fbfe04a14e6ce61753376dd78e0c2f0.dif

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

augusto2112 closed this revision. augusto2112 added a comment. Commit 77e9d10f0fbfe04a14e6ce61753376dd78e0c2f0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev updated this revision to Diff 362755. OmarEmaraDev added a comment. - Generalize the implementation to any Mapping field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://reviews.llvm.org/D106999 Files: lldb/source/C

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev marked an inline comment as done. OmarEmaraDev added a comment. I generalized the implementation as suggested and added a ready to use list version of the field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://review

[Lldb-commits] [lldb] 2e9853e - [DWARF5] Only fallback to manual index if no entry was found

Author: Kim-Anh Tran Date: 2021-07-29T16:16:42+02:00 New Revision: 2e9853e0e9ff263a948ebef70221fd0cec9c4830 URL: https://github.com/llvm/llvm-project/commit/2e9853e0e9ff263a948ebef70221fd0cec9c4830 DIFF: https://github.com/llvm/llvm-project/commit/2e9853e0e9ff263a948ebef70221fd0cec9c4830.diff

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e9853e0e9ff: [DWARF5] Only fallback to manual index if no entry was found (authored by kimanh, committed by jankratochvil). Repository: rG LLVM G

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. You can also consider coding `lldb-add-index` for better performance as that is too much for my available time. In D106355#2909462 , @kimanh wrote: > Otherwise, could you help me to land this change (since I do not have >

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. LLDB has a quite extensive logging framework that is mostly used to help with bug reporting where users are usu

[Lldb-commits] [PATCH] D106584: [lldb] Assert file cache and live memory are equal on debug builds

jankratochvil added a comment. It broke some Linux buildbots and it also broke testsuite on my Fedora machine: `functionalities/gdb_remote_client/TestTargetXMLArch.py` - lldb-x86_64-fedora: https://lab.llvm.org/staging/#/builders/16/builds/8988 - lldb-aarch64-ubuntu: https://lab.llvm.org/buildbot

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

teemperor added a comment. I hacked together a quick example log viewer in HTML here: https://teemperor.de/pub/logviewer.html (I already loaded in a log from my machine, so you can just hit "parse log"). Note that you can search the log messages and you can click each one of them to reveal thei

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

teemperor added a comment. Actually forgot this one: Having the ability to log the current channel in each message is also planned. This originally came up when I kept telling people to do 'log enable lldb all' and people were tired of filtering through the very verbose logs (and Jim suggested

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

DavidSpickett added a comment. > With the added channels in each message we could just do the filtering on our > side and tell people to just enable every channel in every category. +1 to this, was the first thing I tried to do on the viewer you linked. > Will there be an upstream log viewer? I

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1579 +# Remove the suffix that isn't part of the JSON payload +reply = reply[:-3] +dylib_info = json.loads(reply) Coul

[Lldb-commits] [PATCH] D106880: [lldb][AArch64] Mark mismatched tags in tag read output

DavidSpickett updated this revision to Diff 362794. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106880/new/ https://reviews.llvm.org/D106880 Files: lldb/source/Commands/CommandObjectMemoryTag.cpp lldb/t

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

mib added a comment. This looks like a great effort to improve logging and debugging! Have you considered also adding logging levels (info, debug, warning, error ...) ? I think the `CommandReturnObject` and `Status` classes already makes the distinction between warnings and errors messages. We

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

mib added a comment. Quick side-note: `Status` only has an "Error String". I guess this is for historical reason but I think we could change it (on another patch) to convey more information inside the debugger. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107079/new/ https://reviews.

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

JDevlieghere added a comment. I'm supportive of this effort, but if we're removing the plaintext format, I think it's worth sending this out as an RFC. In D107079#2913760 , @teemperor wrote: > Some general notes: > > - Why JSON? In LLVM we have pretty m

[Lldb-commits] [lldb] 172a55e - [lldb] Fix FunctionDecl::Create after D102343

Author: Fangrui Song Date: 2021-07-29T09:57:10-07:00 New Revision: 172a55e7a40d27c7882be2e86d515696d8e12427 URL: https://github.com/llvm/llvm-project/commit/172a55e7a40d27c7882be2e86d515696d8e12427 DIFF: https://github.com/llvm/llvm-project/commit/172a55e7a40d27c7882be2e86d515696d8e12427.diff

[Lldb-commits] [lldb] 72a8367 - Replace LLVM_ATTRIBUTE_NORETURN with C++11 [[noreturn]]. NFC

Author: Fangrui Song Date: 2021-07-29T09:59:45-07:00 New Revision: 72a83674dd3a13b59442cd7cb07b53902f7d6a33 URL: https://github.com/llvm/llvm-project/commit/72a83674dd3a13b59442cd7cb07b53902f7d6a33 DIFF: https://github.com/llvm/llvm-project/commit/72a83674dd3a13b59442cd7cb07b53902f7d6a33.diff

Re: [Lldb-commits] [lldb] 172a55e - [lldb] Fix FunctionDecl::Create after D102343

Thanks for catching and fixing this! > On Jul 29, 2021, at 9:57 AM, Fangrui Song via lldb-commits > wrote: > > > Author: Fangrui Song > Date: 2021-07-29T09:57:10-07:00 > New Revision: 172a55e7a40d27c7882be2e86d515696d8e12427 > > URL: > https://github.com/llvm/llvm-project/commit/172a55e7a40d

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

aprantl added a comment. More a comment than anything else: One thing I always wanted to explore was to implement LLDB's logging on Darwin on top of os_log (https://developer.apple.com/documentation/os/logging) which is also structured and also faster since it moves the the formatting out of pr

[Lldb-commits] [lldb] 66ba4e3 - Revert "[lldb] Assert filecache and live memory match on debug under a setting"

Author: Stella Stamenova Date: 2021-07-29T10:48:57-07:00 New Revision: 66ba4e3dc608156797df8f863d61fa106608e45c URL: https://github.com/llvm/llvm-project/commit/66ba4e3dc608156797df8f863d61fa106608e45c DIFF: https://github.com/llvm/llvm-project/commit/66ba4e3dc608156797df8f863d61fa106608e45c.di

[Lldb-commits] [PATCH] D107079: [lldb] Change the log format to JSON instead of plain text

jingham added a comment. When you are using the logging for a reliably reproducible problem (some parsing issue, for instance) then there's no harm to the general "turn on all logging and we'll sort it out on our end". But for any issues that are timing sensitive the problem is that too much l

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Very nice! Looks great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://reviews.llvm.org/D106999

[Lldb-commits] [lldb] 18c25cd - [LLDB][GUI] Add Create Target form

Author: Omar Emara Date: 2021-07-29T13:27:53-07:00 New Revision: 18c25cd376b6ea38971abb407751cdf08e1e5622 URL: https://github.com/llvm/llvm-project/commit/18c25cd376b6ea38971abb407751cdf08e1e5622 DIFF: https://github.com/llvm/llvm-project/commit/18c25cd376b6ea38971abb407751cdf08e1e5622.diff LO

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18c25cd376b6: [LLDB][GUI] Add Create Target form (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [lldb] 62bd331 - [LLDB][GUI] Add Environment Variable Field

Author: Omar Emara Date: 2021-07-29T13:28:49-07:00 New Revision: 62bd33158d924f907dfe2ccd250f20ddb8ed09a9 URL: https://github.com/llvm/llvm-project/commit/62bd33158d924f907dfe2ccd250f20ddb8ed09a9 DIFF: https://github.com/llvm/llvm-project/commit/62bd33158d924f907dfe2ccd250f20ddb8ed09a9.diff LO

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62bd33158d92: [LLDB][GUI] Add Environment Variable Field (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

kastiglione updated this revision to Diff 362880. kastiglione added a comment. - Reword comment using Jonas's suggestion - Pop the last plan right away, and thus change from WillPop to DidPop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/

[Lldb-commits] [lldb] 993220a - [lldb] Remove CPlusPlusLanguage from Mangled

Author: Alex Langford Date: 2021-07-29T13:58:35-07:00 New Revision: 993220a99ccef6657d6d5d04dc51c06255f285f2 URL: https://github.com/llvm/llvm-project/commit/993220a99ccef6657d6d5d04dc51c06255f285f2 DIFF: https://github.com/llvm/llvm-project/commit/993220a99ccef6657d6d5d04dc51c06255f285f2.diff

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG993220a99cce: [lldb] Remove CPlusPlusLanguage from Mangled (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

jingham accepted this revision. jingham added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D106171: [lldb] Avoid moving ThreadPlanSP from plans vector

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] 26ba774 - Simplify testcase to use v instead of p (NFC)

Author: Adrian Prantl Date: 2021-07-29T15:15:00-07:00 New Revision: 26ba774f6865f0c6bb15dbbe80dc23e1db33d54b URL: https://github.com/llvm/llvm-project/commit/26ba774f6865f0c6bb15dbbe80dc23e1db33d54b DIFF: https://github.com/llvm/llvm-project/commit/26ba774f6865f0c6bb15dbbe80dc23e1db33d54b.diff

[Lldb-commits] [lldb] 0fd813c - Fix typo

Author: Adrian Prantl Date: 2021-07-29T16:23:13-07:00 New Revision: 0fd813cf19c754a6cb3f2483332038a49eac33bd URL: https://github.com/llvm/llvm-project/commit/0fd813cf19c754a6cb3f2483332038a49eac33bd DIFF: https://github.com/llvm/llvm-project/commit/0fd813cf19c754a6cb3f2483332038a49eac33bd.diff

[Lldb-commits] [lldb] 648844f - Make testcase more robust against codegen changes

Author: Adrian Prantl Date: 2021-07-29T16:23:13-07:00 New Revision: 648844fd69fa304a04aab2e39dcb114c89d078bf URL: https://github.com/llvm/llvm-project/commit/648844fd69fa304a04aab2e39dcb114c89d078bf DIFF: https://github.com/llvm/llvm-project/commit/648844fd69fa304a04aab2e39dcb114c89d078bf.diff

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

wallace added inline comments. Herald added a subscriber: dang. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:21 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528") -def test_brea

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:21 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528") -def test_breakpoint_command_sequence(self): +

[Lldb-commits] [PATCH] D107126: [source map] fix relative path breakpoints

wallace created this revision. wallace added a reviewer: clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D45592 added a nice feature to be able to specify a breakpoint by a relative path. E.g. pas

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:21 @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24528") -def test_breakpoint_command_sequence(self): +

[Lldb-commits] [PATCH] D107126: [source map] fix relative path breakpoints

wallace updated this revision to Diff 362943. wallace added a comment. Herald added a subscriber: JDevlieghere. add a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107126/new/ https://reviews.llvm.org/D107126 Files: lldb/source/Breakpoin

[Lldb-commits] [PATCH] D107126: [source map] fix relative path breakpoints

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107126/new/ https://reviews.llvm.org/D107126

[Lldb-commits] [PATCH] D107126: [source map] fix relative path breakpoints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a68443bd07c: [source map] fix relative path breakpoints (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [lldb] 0a68443 - [source map] fix relative path breakpoints

Author: Walter Erquinigo Date: 2021-07-29T18:36:06-07:00 New Revision: 0a68443bd07c48dbaf554f6e3b26b3ab5ed1d383 URL: https://github.com/llvm/llvm-project/commit/0a68443bd07c48dbaf554f6e3b26b3ab5ed1d383 DIFF: https://github.com/llvm/llvm-project/commit/0a68443bd07c48dbaf554f6e3b26b3ab5ed1d383.di

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

wallace added inline comments. Comment at: lldb/source/Plugins/TraceExporter/ctf/CommandObjectThreadTraceExportCTF.cpp:78 + : LLDB_INVALID_THREAD_ID; +result.AppendErrorWithFormat( +"Thread index %lu is out of range (valid val

[Lldb-commits] [lldb] 5839976 - [nfc][trace] use formatv instead of the old Printf

Author: Walter Erquinigo Date: 2021-07-29T19:04:59-07:00 New Revision: 5839976976bc018b674f45f56f8a13707b870443 URL: https://github.com/llvm/llvm-project/commit/5839976976bc018b674f45f56f8a13707b870443 DIFF: https://github.com/llvm/llvm-project/commit/5839976976bc018b674f45f56f8a13707b870443.di

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh added a comment. In D106355#2913605 , @jankratochvil wrote: > You can also consider coding `lldb-add-index` for better performance as that > is too much for my available time. I don't think that I'll get to it either. But we'll also evaluate the