mib added a comment.

This looks like a great effort to improve logging and debugging! Have you 
considered also adding logging levels (info, debug, warning, error ...) ? I 
think the `CommandReturnObject` and `Status` classes already makes the 
distinction between warnings and errors messages. We could enrich logging 
further more by having logging levels to filter / color-code the messages.



================
Comment at: lldb/include/lldb/Utility/Log.h:188-189
+  ///
+  /// Meta-information includes things such as the source file/function that
+  /// is trying to write to the log, the current pid/tid and the backtrace.
+  ///
----------------
+1 to this! We should standardise the log message format to always have the 
source info, as a follow-up (May be clang-tidy check ?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107079/new/

https://reviews.llvm.org/D107079

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to