[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added a reviewer: mgorny. DavidSpickett added a subscriber: mgorny. DavidSpickett added a comment. @mgorny Does FreeBSD do anything with the top byte ignore feature? Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp:476 + retur

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett added a comment. The code LGTM but others should decide if this fits with their efforts. Comment at: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/Makefile:3 + +CFLAGS := -g -Os -march=armv8.5-a -mbranch-protection=pac-ret+leaf + Nit: `a

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp:476 + return hit_addr & ((1ULL << 56) - 1); +} DavidSpickett wrote: > I think it was fine where it was, my point was just to check whether FreeB

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

wallace updated this revision to Diff 342754. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 Files: lldb/tools/lldb-vscode/ProgressEvent.cpp lldb/tools/lldb-vscode/Progr

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace marked 6 inline comments as done. wallace added inline comments. Comment at: lldb/source/Target/Trace.cpp:173 + // instruction's disassembler when possible. + auto calculate_disass = [&](const Address &address, const SymbolContext &sc) { +if (prev_insn.disassembler

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

wallace updated this revision to Diff 342770. wallace marked an inline comment as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100740/new/ https://reviews.llvm.org/D100740 Files: lldb/include/lldb

[Lldb-commits] [lldb] 0c3f762 - [lldb/Utility] Update path in FileSpec documentation (NFC)

Author: Med Ismail Bennani Date: 2021-05-04T16:34:44Z New Revision: 0c3f762c8fd142464f9f3146091045a9b63db2c1 URL: https://github.com/llvm/llvm-project/commit/0c3f762c8fd142464f9f3146091045a9b63db2c1 DIFF: https://github.com/llvm/llvm-project/commit/0c3f762c8fd142464f9f3146091045a9b63db2c1.diff

[Lldb-commits] [lldb] 1435f6b - [lldb] Move and clean-up the Declaration class (NFC)

Author: Med Ismail Bennani Date: 2021-05-04T16:34:44Z New Revision: 1435f6b00be79f1042818da8714ad4de2aef7848 URL: https://github.com/llvm/llvm-project/commit/1435f6b00be79f1042818da8714ad4de2aef7848 DIFF: https://github.com/llvm/llvm-project/commit/1435f6b00be79f1042818da8714ad4de2aef7848.diff

[Lldb-commits] [lldb] adfffeb - [lldb/Core] Add SourceLocationSpec class (NFC)

Author: Med Ismail Bennani Date: 2021-05-04T16:34:45Z New Revision: adfffebec6d6910304e4b1ccdbef78e226a8fd32 URL: https://github.com/llvm/llvm-project/commit/adfffebec6d6910304e4b1ccdbef78e226a8fd32 DIFF: https://github.com/llvm/llvm-project/commit/adfffebec6d6910304e4b1ccdbef78e226a8fd32.diff

[Lldb-commits] [PATCH] D101556: [lldb] Move and clean-up the Declaration class (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1435f6b00be7: [lldb] Move and clean-up the Declaration class (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D100962: [lldb/Core] Add SourceLocationSpec class (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadfffebec6d6: [lldb/Core] Add SourceLocationSpec class (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:143-148 + // The event finished before we were able to report it. + if (!m_start_event.Reported() &&

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just fix the one issue where we use the FileSpec operator== and this is good to go! Comment at: lldb/source/Core/AddressRange.cpp:59 + // the file addresses in this cas

[Lldb-commits] [lldb] 3e2ed74 - [lldb] Refactor argument group by SourceLocationSpec (NFCI)

Author: Med Ismail Bennani Date: 2021-05-04T23:04:31Z New Revision: 3e2ed7440569d59e073d4799b310255547bd2dd2 URL: https://github.com/llvm/llvm-project/commit/3e2ed7440569d59e073d4799b310255547bd2dd2 DIFF: https://github.com/llvm/llvm-project/commit/3e2ed7440569d59e073d4799b310255547bd2dd2.diff

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e2ed7440569: [lldb] Refactor argument group by SourceLocationSpec (NFCI) (authored by mib). Changed prior to commit: https://reviews.llvm.org/D10

[Lldb-commits] [lldb] 30fcdf0 - [lldb/Symbol] Update SymbolFilePDB unitest with SourceLocationSpec

Author: Med Ismail Bennani Date: 2021-05-05T00:34:44Z New Revision: 30fcdf0b19661ca77767bd41ceba03f5dd33 URL: https://github.com/llvm/llvm-project/commit/30fcdf0b19661ca77767bd41ceba03f5dd33 DIFF: https://github.com/llvm/llvm-project/commit/30fcdf0b19661ca77767bd41ceba03f5dd33.diff

[Lldb-commits] [lldb] d5069da - [lldb/Symbol] Fix typo in SymbolFilePDBTests (NFC)

Author: Med Ismail Bennani Date: 2021-05-05T00:38:41Z New Revision: d5069dace7c254a6c2c878bde465344eb6c0cf56 URL: https://github.com/llvm/llvm-project/commit/d5069dace7c254a6c2c878bde465344eb6c0cf56 DIFF: https://github.com/llvm/llvm-project/commit/d5069dace7c254a6c2c878bde465344eb6c0cf56.diff

[Lldb-commits] [lldb] ade59d5 - [trace] Dedup different source lines when dumping instructions + refactor

Author: Walter Erquinigo Date: 2021-05-04T19:40:52-07:00 New Revision: ade59d530964e28498051ab20e44cbf6594be595 URL: https://github.com/llvm/llvm-project/commit/ade59d530964e28498051ab20e44cbf6594be595 DIFF: https://github.com/llvm/llvm-project/commit/ade59d530964e28498051ab20e44cbf6594be595.di

[Lldb-commits] [PATCH] D100740: [trace] Dedup different source lines when dumping instructions + refactor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGade59d530964: [trace] Dedup different source lines when dumping instructions + refactor (authored by wallace, committed by Walter Erquinigo

[Lldb-commits] [PATCH] D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/include/lldb/Symbol/LineTable.h:344 + template + uint32_t FindLineEntryIndexByFileIndexImpl( + uint32_t start_idx, T file_idx, JDevlieghere wrote: > It seems like this metho

[Lldb-commits] [PATCH] D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match

mib updated this revision to Diff 342940. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101221/new/ https://reviews.llvm.org/D101221 Files: lldb/includ

[Lldb-commits] [lldb] 3a62d4f - Fix typo, arvm7 -> armv7

Author: Brad Smith Date: 2021-05-05T00:56:44-04:00 New Revision: 3a62d4fde88544125ce9ceff990db108ee91148a URL: https://github.com/llvm/llvm-project/commit/3a62d4fde88544125ce9ceff990db108ee91148a DIFF: https://github.com/llvm/llvm-project/commit/3a62d4fde88544125ce9ceff990db108ee91148a.diff LO

[Lldb-commits] [PATCH] D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101221/new/ https://reviews.llvm.org/D101221 ___

[Lldb-commits] [lldb] 35ecfda - [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match

Author: Med Ismail Bennani Date: 2021-05-05T05:07:50Z New Revision: 35ecfda01ccd19e1222c065056f68bbd2575e4ac URL: https://github.com/llvm/llvm-project/commit/35ecfda01ccd19e1222c065056f68bbd2575e4ac DIFF: https://github.com/llvm/llvm-project/commit/35ecfda01ccd19e1222c065056f68bbd2575e4ac.diff

[Lldb-commits] [PATCH] D101221: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35ecfda01ccd: [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [lldb] 9775582 - [lldb/Test] Disable testBreakpointByLineAndColumnNearestCode on Windows

Author: Med Ismail Bennani Date: 2021-05-05T06:04:08Z New Revision: 9775582e347c08f79f84748d143eb8c2e4258afb URL: https://github.com/llvm/llvm-project/commit/9775582e347c08f79f84748d143eb8c2e4258afb DIFF: https://github.com/llvm/llvm-project/commit/9775582e347c08f79f84748d143eb8c2e4258afb.diff